mirror of
https://github.com/HifiExperiments/overte.git
synced 2025-05-07 08:00:18 +02:00
196b665e22
* Removes unregister tools switch which was never reached.
* Rolls all code rotation handle related code within mousePressEvent
to the respective rotation handler onBegin functions.
* onBegin call site updated accordingly to provide intersection
data that code depends upon.
* Moves all translateXZTool code explicitly within mousePressEvent
to the tool's onBegin function.
* onBegin signature updated accordingly to provide intersect
results that the tool relies upon.
* Found and fixed a bug with translateXZTool
where its startingElevation and startingDistance properties
were _only_ set when local _debug_ var was set.
* This appears to have been responsible for being able
to move the object farther than was visible. Re-tested
with fix and wasn't able to get that behavior any longer.
* Wrap intersect tests within more reader friendly functions.
NOTE(s):
* Tested GrabberMoveUp and Rotation Handles. They work as they
did previously as expected.
* Tested selection behavior and it currently maintains as expected.
* Tested translationXZTool and it maintains its prior behavior with
the improvement noted above.
Reviewed-by: Leander Hasty <leander@1stplayable.com>
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
|
||
|---|---|---|
| .. | ||
| assets | ||
| commerce | ||
| controllers | ||
| html | ||
| libraries | ||
| marketplaces | ||
| particle_explorer | ||
| tablet-ui | ||
| attachedEntitiesManager.js | ||
| audio.js | ||
| audioMuteOverlay.js | ||
| audioScope.js | ||
| avatarFinderBeacon.js | ||
| away.js | ||
| bubble.js | ||
| chat.js | ||
| dialTone.js | ||
| directory.js | ||
| edit.js | ||
| fingerPaint.js | ||
| firstPersonHMD.js | ||
| generalSettings.js | ||
| goto.js | ||
| help.js | ||
| hmd.js | ||
| makeUserConnection.js | ||
| menu.js | ||
| mod.js | ||
| nameTag.js | ||
| notifications.js | ||
| pal.js | ||
| progress.js | ||
| snapshot.js | ||
| tablet-goto.js | ||
| tablet-users.js | ||
| voxels.js | ||