overte-HifiExperiments/scripts/system/libraries
LaShonda Hopper 196b665e22 [Case 6491] Cleanup of mousePressEvent/tool(s) onBegin (details below).
* Removes unregister tools switch which was never reached.
* Rolls all code rotation handle related code within mousePressEvent
  to the respective rotation handler onBegin functions.
    * onBegin call site updated accordingly to provide intersection
      data that code depends upon.
* Moves all translateXZTool code explicitly within mousePressEvent
  to the tool's onBegin function.
    * onBegin signature updated accordingly to provide intersect
      results that the tool relies upon.
    * Found and fixed a bug with translateXZTool
      where its startingElevation and startingDistance properties
      were _only_ set when local _debug_ var was set.
          * This appears to have been responsible for being able
            to move the object farther than was visible.  Re-tested
            with fix and wasn't able to get that behavior any longer.
* Wrap intersect tests within more reader friendly functions.

NOTE(s):
* Tested GrabberMoveUp and Rotation Handles.  They work as they
  did previously as expected.
* Tested selection behavior and it currently maintains as expected.
* Tested translationXZTool and it maintains its prior behavior with
  the improvement noted above.

Reviewed-by: Leander Hasty <leander@1stplayable.com>

Changes Committed:
    modified:   scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:04:20 -04:00
..
accountUtils.js fix wallet login (and share code with snapshot login) 2017-08-29 16:05:01 -07:00
cloneEntityUtils.js fix grab entity methods + jshint cleanups 2017-09-15 10:50:46 -07:00
controllerDispatcherUtils.js Merge pull request #11430 from sethalves/fix-parent-grab 2017-09-26 13:00:16 -07:00
controllers.js Bug fixes for laser offset and avatar hold action 2017-08-31 17:26:00 -07:00
dataViewHelpers.js move default to system 2016-04-26 14:47:02 -07:00
entityCameraTool.js change all references of Quat.getFront to Quat.getForward in scripts directory 2017-03-21 22:25:30 +00:00
entityIconOverlayManager.js Fixed Icons not being selectable while not highlighted. 2017-07-08 02:52:27 -07:00
entityList.js Keep old function names for compatibility 2017-08-16 22:17:34 +02:00
entitySelectionTool.js [Case 6491] Cleanup of mousePressEvent/tool(s) onBegin (details below). 2017-09-28 15:04:20 -04:00
globals.js move default to system 2016-04-26 14:47:02 -07:00
gridTool.js Merge pull request #10569 from ctrlaltdavid/21312 2017-06-02 15:45:18 -07:00
overlayUtils.js move default to system 2016-04-26 14:47:02 -07:00
progressDialog.js move default to system 2016-04-26 14:47:02 -07:00
soundArray.js change all references of Quat.getFront to Quat.getForward in scripts directory 2017-03-21 22:25:30 +00:00
stringHelpers.js move default to system 2016-04-26 14:47:02 -07:00
toolBars.js Make the time and slider follow the record.js toolbar 2017-03-08 01:14:11 +01:00
ToolTip.js move default to system 2016-04-26 14:47:02 -07:00
touchEventUtils.js fixing and cleanup tablet inputs 2017-09-19 17:03:53 -07:00
Trigger.js Make hand pointer lasers 'click' on fully pressing and clicking the vive controller 2016-07-14 10:30:35 -07:00
utils.js Fixes for scaling controller display 2017-09-05 15:03:41 -07:00
WebTablet.js 7723 Tablet Should Rotate Faster when using Create app 2017-09-21 16:26:54 +03:00
Xform.js WIP, equip-points work but they don't use the proper attach point. 2016-06-29 13:53:06 -07:00