mirror of
https://github.com/overte-org/overte.git
synced 2025-08-10 20:33:09 +02:00
23aa626755
Many render items/payloads contain smart pointers back to the objects that added them to the scene, including entity and avatar objects. Currently, those render items are destroyed when the scene is destroyed very late in the application life-cycle. There are rare crashes that can occur when these render items are destroyed. Possibly, due to them referencing objects that have already been destroyed via raw pointers. In an effort to eliminate these crashes, we now destroy the scene earlier, within Application::aboutToQuit() which is connected to the QCoreApplication::aboutToQuit signal. Also, we guard against null scene pointer dereferences. Any location that accesses the scene off the main thread, now checks the validity of the scene pointer.
117 lines
4.3 KiB
C++
117 lines
4.3 KiB
C++
//
|
|
// RenderableEntityItem.h
|
|
// interface/src
|
|
//
|
|
// Created by Brad Hefta-Gaub on 12/6/13.
|
|
// Copyright 2013 High Fidelity, Inc.
|
|
//
|
|
// Distributed under the Apache License, Version 2.0.
|
|
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
|
|
//
|
|
|
|
#ifndef hifi_RenderableEntityItem_h
|
|
#define hifi_RenderableEntityItem_h
|
|
|
|
#include <render/Scene.h>
|
|
#include <EntityItem.h>
|
|
#include "AbstractViewStateInterface.h"
|
|
#include "EntitiesRendererLogging.h"
|
|
|
|
|
|
// These or the icon "name" used by the render item status value, they correspond to the atlas texture used by the DrawItemStatus
|
|
// job in the current rendering pipeline defined as of now (11/2015) in render-utils/RenderDeferredTask.cpp.
|
|
enum class RenderItemStatusIcon {
|
|
ACTIVE_IN_BULLET = 0,
|
|
PACKET_SENT = 1,
|
|
PACKET_RECEIVED = 2,
|
|
SIMULATION_OWNER = 3,
|
|
HAS_ACTIONS = 4,
|
|
OTHER_SIMULATION_OWNER = 5,
|
|
CLIENT_ONLY = 6,
|
|
NONE = 255
|
|
};
|
|
|
|
void makeEntityItemStatusGetters(EntityItemPointer entity, render::Item::Status::Getters& statusGetters);
|
|
|
|
|
|
class RenderableEntityItemProxy {
|
|
public:
|
|
RenderableEntityItemProxy(EntityItemPointer entity) : entity(entity) { }
|
|
typedef render::Payload<RenderableEntityItemProxy> Payload;
|
|
typedef Payload::DataPointer Pointer;
|
|
|
|
EntityItemPointer entity;
|
|
};
|
|
|
|
namespace render {
|
|
template <> const ItemKey payloadGetKey(const RenderableEntityItemProxy::Pointer& payload);
|
|
template <> const Item::Bound payloadGetBound(const RenderableEntityItemProxy::Pointer& payload);
|
|
template <> void payloadRender(const RenderableEntityItemProxy::Pointer& payload, RenderArgs* args);
|
|
}
|
|
|
|
// Mixin class for implementing basic single item rendering
|
|
class SimpleRenderableEntityItem {
|
|
public:
|
|
bool addToScene(EntityItemPointer self, std::shared_ptr<render::Scene> scene, render::PendingChanges& pendingChanges) {
|
|
_myItem = scene->allocateID();
|
|
|
|
auto renderData = std::make_shared<RenderableEntityItemProxy>(self);
|
|
auto renderPayload = std::make_shared<RenderableEntityItemProxy::Payload>(renderData);
|
|
|
|
render::Item::Status::Getters statusGetters;
|
|
makeEntityItemStatusGetters(self, statusGetters);
|
|
renderPayload->addStatusGetters(statusGetters);
|
|
|
|
pendingChanges.resetItem(_myItem, renderPayload);
|
|
|
|
return true;
|
|
}
|
|
|
|
void removeFromScene(EntityItemPointer self, std::shared_ptr<render::Scene> scene, render::PendingChanges& pendingChanges) {
|
|
pendingChanges.removeItem(_myItem);
|
|
render::Item::clearID(_myItem);
|
|
}
|
|
|
|
void notifyChanged() {
|
|
if (!render::Item::isValidID(_myItem)) {
|
|
return;
|
|
}
|
|
|
|
render::PendingChanges pendingChanges;
|
|
render::ScenePointer scene = AbstractViewStateInterface::instance()->getMain3DScene();
|
|
|
|
if (scene) {
|
|
pendingChanges.updateItem<RenderableEntityItemProxy>(_myItem, [](RenderableEntityItemProxy& data) {
|
|
});
|
|
|
|
scene->enqueuePendingChanges(pendingChanges);
|
|
} else {
|
|
qCWarning(entitiesrenderer) << "SimpleRenderableEntityItem::notifyChanged(), Unexpected null scene, possibly during application shutdown";
|
|
}
|
|
}
|
|
|
|
private:
|
|
render::ItemID _myItem { render::Item::INVALID_ITEM_ID };
|
|
};
|
|
|
|
|
|
#define SIMPLE_RENDERABLE() \
|
|
public: \
|
|
virtual bool addToScene(EntityItemPointer self, std::shared_ptr<render::Scene> scene, render::PendingChanges& pendingChanges) override { return _renderHelper.addToScene(self, scene, pendingChanges); } \
|
|
virtual void removeFromScene(EntityItemPointer self, std::shared_ptr<render::Scene> scene, render::PendingChanges& pendingChanges) override { _renderHelper.removeFromScene(self, scene, pendingChanges); } \
|
|
virtual void locationChanged(bool tellPhysics = true) override { EntityItem::locationChanged(tellPhysics); _renderHelper.notifyChanged(); } \
|
|
virtual void dimensionsChanged() override { EntityItem::dimensionsChanged(); _renderHelper.notifyChanged(); } \
|
|
void checkFading() { \
|
|
bool transparent = isTransparent(); \
|
|
if (transparent != _prevIsTransparent) { \
|
|
_renderHelper.notifyChanged(); \
|
|
_isFading = false; \
|
|
_prevIsTransparent = transparent; \
|
|
} \
|
|
} \
|
|
private: \
|
|
SimpleRenderableEntityItem _renderHelper; \
|
|
bool _prevIsTransparent { isTransparent() };
|
|
|
|
|
|
#endif // hifi_RenderableEntityItem_h
|