Commit graph

78264 commits

Author SHA1 Message Date
Shannon Romano
32d3014d0d
Merge pull request #15301 from SaracenOne/disable_away_on_focus_loss_push_2
case 22190: Disable triggering away state when interface focus lost
2019-05-13 13:22:28 -07:00
Shannon Romano
8aee64c102
Merge pull request #15540 from jherico/fix/gl_crash
BUGZ-125: Error message instead of crash if the GL version is too low
2019-05-13 13:12:30 -07:00
Shannon Romano
46d75a61b3
Merge pull request #15541 from SimonWalton-HiFi/clear-connections-on-NodeID-change
Clear any reliable connection state upon Node ID change
2019-05-13 13:11:05 -07:00
Shannon Romano
d37beec6d2
Merge pull request #15535 from Atlante45/fix/warnings
Fix mac build warnings
2019-05-13 13:09:59 -07:00
Shannon Romano
b1060bcb83
Merge pull request #15508 from dback2/materialTargetTooltip
Case 22467: Fix material target tooltip
2019-05-13 13:08:28 -07:00
Shannon Romano
12bb073d14
Merge pull request #15485 from sabrina-shanman/crash_hfm_normals
(case 22026) Fix crash due to invalid indices in baker::calculateNormals
2019-05-13 13:06:01 -07:00
Sam Gondelman
4c4589271c
Merge pull request #15469 from SamGondelman/switch
Case 22379: Run-time switch for deferred/forward rendering
2019-05-13 11:14:26 -07:00
SamGondelman
eb8c722080 fix runtime switch 2019-05-13 09:58:55 -07:00
Shannon Romano
5c58cec5af
Merge pull request #15522 from SaracenOne/forward_lightmapping
Case 22494, BUGZ-127: Render lightmaps in the forward renderer
2019-05-13 09:13:34 -07:00
Brad Hefta-Gaub
52eec19d50
Merge pull request #15543 from SamGondelman/zone
BUGZ-139, Case 22502: Fix zone inheritance
2019-05-13 08:12:41 -07:00
Shannon Romano
99239f6415
Merge pull request #15542 from hyperlogic/bug-fix/dependency-manager-thread-safety
Make DependencyManager thread-safe
2019-05-13 07:43:55 -07:00
Anthony Thibault
b46378e0b6 Compile error fix 2019-05-10 15:51:42 -07:00
Anthony Thibault
fe17550a80 Code review feedback
In DependencyManager::set<>() destroy the clear the previous before allocating the new instance.
2019-05-10 15:41:52 -07:00
SamGondelman
dfdace8cdc fix zones for real this time 2019-05-10 15:24:02 -07:00
Shannon Romano
5c9570cffb
Merge pull request #15539 from jherico/fix/watchdog_spam
BUGZ-131: Reduce spam from watchdog thread
2019-05-10 14:24:15 -07:00
Anthony Thibault
442a679108 Make DepenencyManager thread-safe again
Before this PR, there were no locks around the two internal QHash data structures.
Races are rare, due to the fact that the DependencyManager is initialized on the main thread on startup and the fact that a static QWeakPointer was used as an internal cache.
However, there have been reported crashes where the render thread uses DependencyManager::isSet() perhaps while the main thread is adding a late dependency.
DependencyManager::isSet() did not use the static QWeakPointer cache and was more prone to race conditions.

To avoid this and perhaps other data races, mutexes now guard both of the internal QHash data structures.
Also, as an optimization, the most frequent call to DependencyManager::isSet was removed (Profile.cpp).
2019-05-10 14:12:10 -07:00
Roxanne Skelly
7dfbbf55e9
Merge pull request #15530 from roxanneskelly/bugz85b
BUGZ-85 - extrapolate audio on network lag spike to reduce pop
2019-05-10 13:51:30 -07:00
Simon Walton
4b51d81b42 Clear any reliable connection state upon Node ID change 2019-05-10 12:06:38 -07:00
Brad Davis
0f8ddae9df Reduce spam from watchdog thread 2019-05-10 12:01:07 -07:00
Shannon Romano
0d28932181
Merge pull request #15529 from Atlante45/feat/more-ice-logging
Add instrumentation to help track down connection issues
2019-05-10 11:57:24 -07:00
Brad Davis
db88f14e13 Error message instead of crash if the GL version is too low 2019-05-10 11:51:50 -07:00
Roxanne Skelly
53a1425ab1 Merge branch 'master' of https://github.com/highfidelity/hifi into bugz85b 2019-05-09 17:56:21 -07:00
Clement
07372f102c Add logging on silent node removal 2019-05-09 17:19:10 -07:00
Clement
0a7352074c Fix android build 2019-05-09 17:17:43 -07:00
Shannon Romano
930032bcc6
Merge pull request #15511 from AndrewMeadows/build-shapes-off-mainloop
case 22166: Build complex shapes in ThreadPool instead of MainLoop
2019-05-09 17:14:50 -07:00
Sam Gondelman
78f086bc58
Merge pull request #15536 from SamGondelman/click
BUGZ-135: Edit entity icons ignorePickIntersection when not visible
2019-05-09 16:23:01 -07:00
Shannon Romano
6aa8dc7c42
Merge pull request #15534 from kencooke/audio-PTT-output-ducking
Reduce echo when push-to-talk is used
2019-05-09 15:54:15 -07:00
Roxanne Skelly
7a4e3557b0 Use TryLocker instead of explicitly using tryLock on mutexes 2019-05-09 15:21:43 -07:00
Andrew Meadows
a0b34e4f15 more correct clearing of dirty flags for AvatarMotionState 2019-05-09 14:45:36 -07:00
SamGondelman
2bb522eea6 entity icons ignorePickIntersection when not visible 2019-05-09 14:16:59 -07:00
Clement
ad36df0455 Fix build warnings 2019-05-09 13:59:49 -07:00
Clement
c691ee496e CR 2019-05-09 13:58:50 -07:00
Shannon Romano
367c4cffee
Merge pull request #15532 from danteruiz/dock-widget-fix-context
Bugz-129 JS APIs accessible to new dockable windows QML items is not the same as JS APIs accessible to floating / overlay QML windows
2019-05-09 13:58:42 -07:00
Andrew Meadows
c7432ffe5f also update easy flags when rebuilding avatar shape 2019-05-09 13:48:07 -07:00
Ken Cooke
1b733d3fb3 While PTT is active, duck the audio output by 20dB to reduce echo 2019-05-09 12:56:07 -07:00
SamGondelman
59e7db2d6b Merge remote-tracking branch 'upstream/master' into switch 2019-05-09 11:42:05 -07:00
Saracen
b730c457ca Replace tabs with spaces 2019-05-09 18:08:36 +01:00
Ken Cooke
85f425a93b Apply variable output gain using cubic smoothing 2019-05-09 10:05:02 -07:00
danteruiz
0fae615cb4 fix dock widget context 2019-05-09 09:20:50 -07:00
Roxanne Skelly
3a4241b290 Unnecessary spacing changes. 2019-05-08 22:16:18 -07:00
Roxanne Skelly
dc7ec35544 BUGZ-85 - handle thread safety issues with calling the decoder from the
real-time thread.
2019-05-08 22:16:10 -07:00
Roxanne Skelly
4a4a92c009 BUGZ-85 - audio pipeline interpolation on ring buffer starve
Kick the PLC so that it generates a more pleasing 'fade' frame
when ring buffer starves.
2019-05-08 22:16:05 -07:00
Clement
5c42838261 Change timeouts to try to prevent ICE disconnects 2019-05-08 18:38:35 -07:00
Clement
b3d0705e39 Extend ICE logging + make it more searchable 2019-05-08 18:38:00 -07:00
Anthony Thibault
4ee39355f1
Merge pull request #15525 from hyperlogic/feature/backtrace-gpu-ident
Add gpu_name, gpu_driver & gpu_memory to crash annotations
2019-05-08 16:09:13 -07:00
Shannon Romano
6cca095e5b
Merge pull request #15526 from mattr1x/add-flock
Add FLock to lock files another way
2019-05-08 16:04:14 -07:00
Matt Hardcastle
0ddfd6fe2b Add FLock to lock files another way
The build system uses a class called Singleton to handle file locking. This class has a few potential issues:

1) An instance of Single could delete a file owned by another instance
2) Calling `print` in `__enter__` doesn't write to STDOUT
3) If the lock file already exists but the process that "owned" it died without deleting it every process will be locked

This change is an attempt to resolve these issues and provide some lock debugging code.

The code is structured to default to using the current Singleton class unless the USE_FLOCK_CLS environmental variable is set. In the event the environment variable is set the Singleton class is replaced with FLock.

The FLock class is designed to work while running on a machine that's also using the real Singleton class. It does this at the expense of not solving issue number #1. If FLock is proven successful and completely deployed to the cluster it should be made the default and the code that deletes the lock file in `__exit__` should be removed.
2019-05-08 15:00:50 -07:00
Shannon Romano
4bd41a1aa3
Merge pull request #15523 from SamGondelman/zone
Case 22466, BUGZ-102: Fix zone rendering issues
2019-05-08 14:52:33 -07:00
Andrew Meadows
f60dbda25e clear all HARD flags when reinserting object in PhysicsEngine 2019-05-08 14:48:49 -07:00
Anthony Thibault
78403e4436 Add gpu_name, gpu_driver & gpu_memory to crash annotations
This may help us identify the hardware causing early gl initialization errors.
2019-05-08 13:33:45 -07:00