Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-14 07:47:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

use const references when querying plugin metadata

Browse source
This commit is contained in:
Seth Alves 2019-01-10 15:20:53 -08:00
parent 0603431ac8
commit fd8702d5a6
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libraries/plugins/src/plugins/PluginManager.cpp
View file

@ -44,7 +44,7 @@ PluginManagerPointer PluginManager::getInstance() {
return DependencyManager::get<PluginManager>(); return DependencyManager::get<PluginManager>();
} }
QString getPluginNameFromMetaData(QJsonObject object) { QString getPluginNameFromMetaData(const QJsonObject& object) {
static const char* METADATA_KEY = "MetaData"; static const char* METADATA_KEY = "MetaData";
static const char* NAME_KEY = "name"; static const char* NAME_KEY = "name";
@ -61,7 +61,7 @@ QString getPluginNameFromMetaData(QJsonObject object) {
return metaDataObject[NAME_KEY].toString(); return metaDataObject[NAME_KEY].toString();
} }
QString getPluginIIDFromMetaData(QJsonObject object) { QString getPluginIIDFromMetaData(const QJsonObject& object) {
static const char* IID_KEY = "IID"; static const char* IID_KEY = "IID";
if (!object.contains(IID_KEY) || !object[IID_KEY].isString()) { if (!object.contains(IID_KEY) || !object[IID_KEY].isString()) {
@ -71,7 +71,7 @@ QString getPluginIIDFromMetaData(QJsonObject object) {
return object[IID_KEY].toString(); return object[IID_KEY].toString();
} }
int getPluginInterfaceVersionFromMetaData(QJsonObject object) { int getPluginInterfaceVersionFromMetaData(const QJsonObject& object) {
static const char* METADATA_KEY = "MetaData"; static const char* METADATA_KEY = "MetaData";
static const char* NAME_KEY = "version"; static const char* NAME_KEY = "version";