From fd8702d5a6b4bfb120c2821b53c283d8bc2b397c Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Thu, 10 Jan 2019 15:20:53 -0800 Subject: [PATCH] use const references when querying plugin metadata --- libraries/plugins/src/plugins/PluginManager.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/plugins/src/plugins/PluginManager.cpp b/libraries/plugins/src/plugins/PluginManager.cpp index ece8ccd528..854ae62ea1 100644 --- a/libraries/plugins/src/plugins/PluginManager.cpp +++ b/libraries/plugins/src/plugins/PluginManager.cpp @@ -44,7 +44,7 @@ PluginManagerPointer PluginManager::getInstance() { return DependencyManager::get(); } -QString getPluginNameFromMetaData(QJsonObject object) { +QString getPluginNameFromMetaData(const QJsonObject& object) { static const char* METADATA_KEY = "MetaData"; static const char* NAME_KEY = "name"; @@ -61,7 +61,7 @@ QString getPluginNameFromMetaData(QJsonObject object) { return metaDataObject[NAME_KEY].toString(); } -QString getPluginIIDFromMetaData(QJsonObject object) { +QString getPluginIIDFromMetaData(const QJsonObject& object) { static const char* IID_KEY = "IID"; if (!object.contains(IID_KEY) || !object[IID_KEY].isString()) { @@ -71,7 +71,7 @@ QString getPluginIIDFromMetaData(QJsonObject object) { return object[IID_KEY].toString(); } -int getPluginInterfaceVersionFromMetaData(QJsonObject object) { +int getPluginInterfaceVersionFromMetaData(const QJsonObject& object) { static const char* METADATA_KEY = "MetaData"; static const char* NAME_KEY = "version";