CR feedback

libraries/render-utils/src/DeferredBufferWrite.slh

@@ -21,6 +21,9 @@ float evalOpaqueFinalAlpha(float alpha, float mapAlpha) {
     return mix(alpha * glowIntensity, 1.0 - alpha * glowIntensity, step(mapAlpha, alphaThreshold));
 }
 
+const DEFAULT_SPECULAR = vec3(0.1);
+const DEFAULT_SHININESS = 10;
+
 void packDeferredFragment(vec3 normal, float alpha, vec3 diffuse, vec3 specular, float shininess) {
     if (alpha != glowIntensity) {
         discard;

libraries/render-utils/src/simple.slf

@@ -22,6 +22,5 @@ void main(void) {
         normalize(interpolatedNormal.xyz), 
         glowIntensity,
         gl_Color.rgb,
-        vec3(0.1),
+         DEFAULT_SPECULAR, DEFAULT_SHININESS);
-        10);
 }

libraries/render-utils/src/simple_textured.slf

@@ -27,6 +27,5 @@ void main(void) {
          normalize(interpolatedNormal.xyz),
          glowIntensity * texel.a,
          gl_Color.rgb * texel.rgb,
-         vec3(0.1),
+         DEFAULT_SPECULAR, DEFAULT_SHININESS);
-         10);
 }

libraries/render-utils/src/simple_textured_emisive.slf

@@ -27,7 +27,6 @@ void main(void) {
          normalize(interpolatedNormal.xyz),
          glowIntensity * texel.a,
          gl_Color.rgb,
-         vec3(0.1),
+         DEFAULT_SPECULAR, DEFAULT_SHININESS,
-         10,
          texel.rgb);
 }