From e6262de864f1607c3be7ba52153ee6f21240e462 Mon Sep 17 00:00:00 2001
From: ZappoMan <bradh@konamoxt.com>
Date: Thu, 23 Jul 2015 14:56:52 -0700
Subject: [PATCH] CR feedback

---
 libraries/render-utils/src/DeferredBufferWrite.slh     | 3 +++
 libraries/render-utils/src/simple.slf                  | 3 +--
 libraries/render-utils/src/simple_textured.slf         | 3 +--
 libraries/render-utils/src/simple_textured_emisive.slf | 3 +--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/libraries/render-utils/src/DeferredBufferWrite.slh b/libraries/render-utils/src/DeferredBufferWrite.slh
index a7f4055bba..ab070db9e9 100755
--- a/libraries/render-utils/src/DeferredBufferWrite.slh
+++ b/libraries/render-utils/src/DeferredBufferWrite.slh
@@ -21,6 +21,9 @@ float evalOpaqueFinalAlpha(float alpha, float mapAlpha) {
     return mix(alpha * glowIntensity, 1.0 - alpha * glowIntensity, step(mapAlpha, alphaThreshold));
 }
 
+const DEFAULT_SPECULAR = vec3(0.1);
+const DEFAULT_SHININESS = 10;
+
 void packDeferredFragment(vec3 normal, float alpha, vec3 diffuse, vec3 specular, float shininess) {
     if (alpha != glowIntensity) {
         discard;
diff --git a/libraries/render-utils/src/simple.slf b/libraries/render-utils/src/simple.slf
index 1d77dde0d3..84f1752c37 100644
--- a/libraries/render-utils/src/simple.slf
+++ b/libraries/render-utils/src/simple.slf
@@ -22,6 +22,5 @@ void main(void) {
         normalize(interpolatedNormal.xyz), 
         glowIntensity,
         gl_Color.rgb,
-        vec3(0.1),
-        10);
+         DEFAULT_SPECULAR, DEFAULT_SHININESS);
 }
diff --git a/libraries/render-utils/src/simple_textured.slf b/libraries/render-utils/src/simple_textured.slf
index 88b196543c..68d235050d 100644
--- a/libraries/render-utils/src/simple_textured.slf
+++ b/libraries/render-utils/src/simple_textured.slf
@@ -27,6 +27,5 @@ void main(void) {
          normalize(interpolatedNormal.xyz),
          glowIntensity * texel.a,
          gl_Color.rgb * texel.rgb,
-         vec3(0.1),
-         10);
+         DEFAULT_SPECULAR, DEFAULT_SHININESS);
 }
\ No newline at end of file
diff --git a/libraries/render-utils/src/simple_textured_emisive.slf b/libraries/render-utils/src/simple_textured_emisive.slf
index c5749114f3..d2c7d403c3 100644
--- a/libraries/render-utils/src/simple_textured_emisive.slf
+++ b/libraries/render-utils/src/simple_textured_emisive.slf
@@ -27,7 +27,6 @@ void main(void) {
          normalize(interpolatedNormal.xyz),
          glowIntensity * texel.a,
          gl_Color.rgb,
-         vec3(0.1),
-         10,
+         DEFAULT_SPECULAR, DEFAULT_SHININESS,
          texel.rgb);
 }
\ No newline at end of file