mirror of
https://github.com/overte-org/overte.git
synced 2025-04-25 20:16:16 +02:00
Address comments from review
This commit is contained in:
parent
3efa92b48e
commit
b922331b05
1 changed files with 6 additions and 4 deletions
|
@ -203,7 +203,7 @@ const gpu::PipelinePointer GameWorkloadRenderItem::getViewsPipeline() {
|
||||||
const gpu::BufferPointer GameWorkloadRenderItem::getDrawViewBuffer() {
|
const gpu::BufferPointer GameWorkloadRenderItem::getDrawViewBuffer() {
|
||||||
if (!_drawViewBuffer) {
|
if (!_drawViewBuffer) {
|
||||||
int numSegments = 64;
|
int numSegments = 64;
|
||||||
float angleStep = M_PI * 2.0 / (float)numSegments;
|
float angleStep = (float)M_PI * 2.0f / (float)numSegments;
|
||||||
|
|
||||||
struct Vert {
|
struct Vert {
|
||||||
glm::vec4 p;
|
glm::vec4 p;
|
||||||
|
@ -214,10 +214,10 @@ const gpu::BufferPointer GameWorkloadRenderItem::getDrawViewBuffer() {
|
||||||
verts[i].p.x = cos(angle);
|
verts[i].p.x = cos(angle);
|
||||||
verts[i].p.y = sin(angle);
|
verts[i].p.y = sin(angle);
|
||||||
verts[i].p.z = angle;
|
verts[i].p.z = angle;
|
||||||
verts[i].p.w = 1.0;
|
verts[i].p.w = 1.0f;
|
||||||
}
|
}
|
||||||
verts[numSegments] = verts[0];
|
verts[numSegments] = verts[0];
|
||||||
verts[numSegments].p.w = 0.0;
|
verts[numSegments].p.w = 0.0f;
|
||||||
|
|
||||||
_drawViewBuffer = std::make_shared<gpu::Buffer>(verts.size() * sizeof(Vert), (const gpu::Byte*) verts.data());
|
_drawViewBuffer = std::make_shared<gpu::Buffer>(verts.size() * sizeof(Vert), (const gpu::Byte*) verts.data());
|
||||||
_numDrawViewVerts = numSegments + 1;
|
_numDrawViewVerts = numSegments + 1;
|
||||||
|
@ -246,7 +246,9 @@ void GameWorkloadRenderItem::render(RenderArgs* args) {
|
||||||
batch.setPipeline(getViewsPipeline());
|
batch.setPipeline(getViewsPipeline());
|
||||||
|
|
||||||
batch.setUniformBuffer(0, getDrawViewBuffer());
|
batch.setUniformBuffer(0, getDrawViewBuffer());
|
||||||
batch.draw(gpu::TRIANGLE_STRIP, _numDrawViewVerts * 3 * 2, 0);
|
static const int NUM_VERTICES_PER_DRAWVIEWVERT = 2;
|
||||||
|
static const int NUM_REGIONS = 3;
|
||||||
|
batch.draw(gpu::TRIANGLE_STRIP, NUM_REGIONS * NUM_VERTICES_PER_DRAWVIEWVERT * _numDrawViewVerts, 0);
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue