Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 16:14:35 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
This commit is contained in:
Kalila 2021-03-10 01:27:05 -05:00 committed by GitHub
parent b5d89c44bf
commit 3dc11637ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libraries/script-engine/src/ScriptGatekeeper.cpp
View file

@ -15,14 +15,14 @@
#include "SettingHandle.h" #include "SettingHandle.h"
void ScriptGatekeeper::initialize() { void ScriptGatekeeper::initialize() {
if (_initialized == true) { if (_initialized) {
return; return;
} }
QVariant rawCurrentWhitelistValues = Setting::Handle<QVariant>(SCRIPT_WHITELIST_ENTRIES_KEY).get(); QVariant rawCurrentWhitelistValues = Setting::Handle<QVariant>(SCRIPT_WHITELIST_ENTRIES_KEY).get();
QString settingsSafeValues = rawCurrentWhitelistValues.toString(); QString settingsSafeValues = rawCurrentWhitelistValues.toString();
Setting::Handle<bool> whitelistEnabled{ SCRIPT_WHITELIST_ENABLED_KEY, false }; Setting::Handle<bool> whitelistEnabled { SCRIPT_WHITELIST_ENABLED_KEY, false };
Setting::Handle<bool> isFirstRun { Settings::firstRun, true }; Setting::Handle<bool> isFirstRun { Settings::firstRun, true };
QString preloadedVal = BuildInfo::PRELOADED_SCRIPT_WHITELIST; QString preloadedVal = BuildInfo::PRELOADED_SCRIPT_WHITELIST;

2
libraries/script-engine/src/ScriptGatekeeper.h
View file

@ -23,7 +23,7 @@ public:
QString SCRIPT_WHITELIST_ENTRIES_KEY{ "private/settingsSafeURLS" }; QString SCRIPT_WHITELIST_ENTRIES_KEY{ "private/settingsSafeURLS" };
private: private:
bool _initialized{ false }; bool _initialized { false };
}; };
#endif // vircadia_ScriptGatekeeper_h #endif // vircadia_ScriptGatekeeper_h