From 3dc11637ed99003232d9ae98c0f9badb570bc07a Mon Sep 17 00:00:00 2001 From: Kalila <69767640+digisomni@users.noreply.github.com> Date: Wed, 10 Mar 2021 01:27:05 -0500 Subject: [PATCH] Apply suggestions from code review Co-authored-by: David Rowe --- libraries/script-engine/src/ScriptGatekeeper.cpp | 4 ++-- libraries/script-engine/src/ScriptGatekeeper.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/script-engine/src/ScriptGatekeeper.cpp b/libraries/script-engine/src/ScriptGatekeeper.cpp index d69e8c9561..d7ee1addd4 100644 --- a/libraries/script-engine/src/ScriptGatekeeper.cpp +++ b/libraries/script-engine/src/ScriptGatekeeper.cpp @@ -15,14 +15,14 @@ #include "SettingHandle.h" void ScriptGatekeeper::initialize() { - if (_initialized == true) { + if (_initialized) { return; } QVariant rawCurrentWhitelistValues = Setting::Handle(SCRIPT_WHITELIST_ENTRIES_KEY).get(); QString settingsSafeValues = rawCurrentWhitelistValues.toString(); - Setting::Handle whitelistEnabled{ SCRIPT_WHITELIST_ENABLED_KEY, false }; + Setting::Handle whitelistEnabled { SCRIPT_WHITELIST_ENABLED_KEY, false }; Setting::Handle isFirstRun { Settings::firstRun, true }; QString preloadedVal = BuildInfo::PRELOADED_SCRIPT_WHITELIST; diff --git a/libraries/script-engine/src/ScriptGatekeeper.h b/libraries/script-engine/src/ScriptGatekeeper.h index a73ef5995a..22bda8d5d5 100644 --- a/libraries/script-engine/src/ScriptGatekeeper.h +++ b/libraries/script-engine/src/ScriptGatekeeper.h @@ -23,7 +23,7 @@ public: QString SCRIPT_WHITELIST_ENTRIES_KEY{ "private/settingsSafeURLS" }; private: - bool _initialized{ false }; + bool _initialized { false }; }; #endif // vircadia_ScriptGatekeeper_h