Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-09 03:17:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Apply suggestions from code review

Browse source 
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
This commit is contained in:
kasenvr 2020-07-20 14:25:52 -04:00 committed by GitHub
parent f1d731da11
commit 1c545dffca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
domain-server/resources/metadata_exporter/index.html
View file

@ -1,10 +1,10 @@
<html> <html>
<head> <head>
<title>Vircadia Metadata exporter</title> <title>Vircadia Metadata Exporter</title>
</head> </head>
<body> <body>
<h1>Vircadia Metadata exporter</h1> <h1>Vircadia Metadata Exporter</h1>
<p>If you can see this page, this means that your domain's metadata is available to be exported.</p> <p>If you can see this page, this means that your domain's metadata is available to be exported.</p>
<p> <p>

3
domain-server/src/DomainMetadata.h
View file

@ -44,12 +44,11 @@ public:
DomainMetadata(QObject* domainServer); DomainMetadata(QObject* domainServer);
~DomainMetadata() = default; ~DomainMetadata() = default;
// Get cached metadata // Get cached metadata
QJsonObject get(); QJsonObject get();
QJsonObject get(const QString& group); QJsonObject get(const QString& group);
bool handleHTTPRequest(HTTPConnection* connection, const QUrl& url, bool skipSubHandler = false); bool handleHTTPRequest(HTTPConnection* connection, const QUrl& url, bool skipSubHandler = false) override;
public slots: public slots:
void descriptorsChanged(); void descriptorsChanged();

4
domain-server/src/DomainServer.cpp
View file

@ -3079,14 +3079,14 @@ void DomainServer::initializeMetadataExporter() {
int metadataExporterPort = _settingsManager.valueOrDefaultValueForKeyPath(EXPORTER_PORT).toInt(); int metadataExporterPort = _settingsManager.valueOrDefaultValueForKeyPath(EXPORTER_PORT).toInt();
if (metadataExporterPort < MIN_PORT || metadataExporterPort > MAX_PORT) { if (metadataExporterPort < MIN_PORT || metadataExporterPort > MAX_PORT) {
qCWarning(domain_server) << "Metadata exporter port " << metadataExporterPort << " is out of range."; qCWarning(domain_server) << "Metadata exporter port" << metadataExporterPort << "is out of range.";
isMetadataExporterEnabled = false; isMetadataExporterEnabled = false;
} }
qCDebug(domain_server) << "Setting up Metadata exporter."; qCDebug(domain_server) << "Setting up Metadata exporter.";
if (isMetadataExporterEnabled && !_httpMetadataExporterManager) { if (isMetadataExporterEnabled && !_httpMetadataExporterManager) {
qCInfo(domain_server) << "Starting Metadata exporter on port " << metadataExporterPort; qCInfo(domain_server) << "Starting Metadata exporter on port" << metadataExporterPort;
_httpMetadataExporterManager = new HTTPManager(QHostAddress::Any, (quint16)metadataExporterPort, QString("%1/resources/metadata_exporter/").arg(QCoreApplication::applicationDirPath()), _metadata); _httpMetadataExporterManager = new HTTPManager(QHostAddress::Any, (quint16)metadataExporterPort, QString("%1/resources/metadata_exporter/").arg(QCoreApplication::applicationDirPath()), _metadata);
} }
} }