From 1c545dffca5355bbc8f04524fe000bc4d5cf9967 Mon Sep 17 00:00:00 2001 From: kasenvr <52365539+kasenvr@users.noreply.github.com> Date: Mon, 20 Jul 2020 14:25:52 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: David Rowe --- domain-server/resources/metadata_exporter/index.html | 4 ++-- domain-server/src/DomainMetadata.h | 3 +-- domain-server/src/DomainServer.cpp | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/domain-server/resources/metadata_exporter/index.html b/domain-server/resources/metadata_exporter/index.html index acc7aae23a..c75cc711e8 100644 --- a/domain-server/resources/metadata_exporter/index.html +++ b/domain-server/resources/metadata_exporter/index.html @@ -1,10 +1,10 @@ - Vircadia Metadata exporter + Vircadia Metadata Exporter -

Vircadia Metadata exporter

+

Vircadia Metadata Exporter

If you can see this page, this means that your domain's metadata is available to be exported.

diff --git a/domain-server/src/DomainMetadata.h b/domain-server/src/DomainMetadata.h index 6fae29248d..70f17348df 100644 --- a/domain-server/src/DomainMetadata.h +++ b/domain-server/src/DomainMetadata.h @@ -44,12 +44,11 @@ public: DomainMetadata(QObject* domainServer); ~DomainMetadata() = default; - // Get cached metadata QJsonObject get(); QJsonObject get(const QString& group); - bool handleHTTPRequest(HTTPConnection* connection, const QUrl& url, bool skipSubHandler = false); + bool handleHTTPRequest(HTTPConnection* connection, const QUrl& url, bool skipSubHandler = false) override; public slots: void descriptorsChanged(); diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp index 1d61449897..bad9c96e6b 100644 --- a/domain-server/src/DomainServer.cpp +++ b/domain-server/src/DomainServer.cpp @@ -3079,14 +3079,14 @@ void DomainServer::initializeMetadataExporter() { int metadataExporterPort = _settingsManager.valueOrDefaultValueForKeyPath(EXPORTER_PORT).toInt(); if (metadataExporterPort < MIN_PORT || metadataExporterPort > MAX_PORT) { - qCWarning(domain_server) << "Metadata exporter port " << metadataExporterPort << " is out of range."; + qCWarning(domain_server) << "Metadata exporter port" << metadataExporterPort << "is out of range."; isMetadataExporterEnabled = false; } qCDebug(domain_server) << "Setting up Metadata exporter."; if (isMetadataExporterEnabled && !_httpMetadataExporterManager) { - qCInfo(domain_server) << "Starting Metadata exporter on port " << metadataExporterPort; + qCInfo(domain_server) << "Starting Metadata exporter on port" << metadataExporterPort; _httpMetadataExporterManager = new HTTPManager(QHostAddress::Any, (quint16)metadataExporterPort, QString("%1/resources/metadata_exporter/").arg(QCoreApplication::applicationDirPath()), _metadata); } }