Apply suggestions from code review

Co-authored-by: David Rowe <david@ctrlaltstudio.com>
This commit is contained in:
kasenvr 2020-08-30 13:56:09 -04:00 committed by GitHub
parent abac59c09b
commit 0b1dce14a0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -535,21 +535,17 @@ semanticVersionCompare = function(versionA, versionB) {
var splitA = versionAParts[i].split('-')[0];
var splitB = versionBParts[i].split('-')[0];
if (splitA == splitB) {
continue;
if (splitA < splitB) {
return -1;
} else if (splitA > splitB) {
return 1;
} else {
return -1;
}
}
} else { // Else, they're both numbers so compare the strings as if they were.
if (versionAParts[i] == versionBParts[i]) {
continue;
if (versionAParts[i] < versionBParts[i]) {
return -1;
} else if (versionAParts[i] > versionBParts[i]) {
return 1;
} else {
return -1;
}
}
}