From 0b1dce14a0b526f1b90866a40bf2349797371dd2 Mon Sep 17 00:00:00 2001
From: kasenvr <52365539+kasenvr@users.noreply.github.com>
Date: Sun, 30 Aug 2020 13:56:09 -0400
Subject: [PATCH] Apply suggestions from code review
Co-authored-by: David Rowe <david@ctrlaltstudio.com>
---
scripts/system/libraries/utils.js | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/scripts/system/libraries/utils.js b/scripts/system/libraries/utils.js
index ff467b1f5b..c7c30a58dd 100644
--- a/scripts/system/libraries/utils.js
+++ b/scripts/system/libraries/utils.js
@@ -535,21 +535,17 @@ semanticVersionCompare = function(versionA, versionB) {
var splitA = versionAParts[i].split('-')[0];
var splitB = versionBParts[i].split('-')[0];
- if (splitA == splitB) {
- continue;
+ if (splitA < splitB) {
+ return -1;
} else if (splitA > splitB) {
return 1;
- } else {
- return -1;
}
}
} else { // Else, they're both numbers so compare the strings as if they were.
- if (versionAParts[i] == versionBParts[i]) {
- continue;
+ if (versionAParts[i] < versionBParts[i]) {
+ return -1;
} else if (versionAParts[i] > versionBParts[i]) {
return 1;
- } else {
- return -1;
}
}
}