Mirrors/community-apps
3
0
Fork 0
mirror of https://github.com/overte-org/community-apps.git synced 2025-04-05 21:22:00 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Handle ties.

Browse source 
Fix running without casted votes causing exception.
This commit is contained in:
armored-dragon 2024-09-18 06:18:30 -05:00
parent 5ef98c7c5b
commit 71ed32cb19
No known key found for this signature in database
GPG key ID: C7207ACC3382AD8B
2 changed files with 39 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
applications/voting/vote.js
View file

@ -12,8 +12,6 @@
/* global Script Tablet Messages MyAvatar AvatarList Uuid SoundCache*/
// TODO: Documentation
// FIXME: Handle ties: kill both of tied results
// FIXME: Handle ties: Last two standing are tied.
// FIXME: Make the candidate name have reserved value "-1", or change to uncommon name.
(() => {
@ -232,10 +230,13 @@
});
const winner = voteEngine.preformVote(votesFormatted);
console.log(`Winner: ${winner.name}`);
if (!winner) return;
const winnerName = winner?.tie ? winner.name.join(', ') : winner.name;
console.log(`Winner: ${winnerName}`);
// Update the stats
pollStats.winnerName = winner.name;
pollStats.winnerName = winnerName;
pollStats.winnerSelected = true;
pollStats.votesCounted = Object.keys(pollStats.responses).length;
pollStats.iterations = winner.iterations;
@ -323,7 +324,7 @@
case "run_election":
// Debug: Create a lot of fake ballots
if (debug) {
for (let i = 0; i < 25; ++i) {
for (let i = 0; i < 26; ++i) {
_debugDummyBallot();
}
}

38
applications/voting/vote_engine.js
View file

@ -19,7 +19,7 @@ function preformVote(arrayOfBallots) {
const totalAmountOfVotes = ballotsStorage.length;
let firstChoices = {};
if (totalAmountOfVotes === 0) return; // No votes, no results.
if (totalAmountOfVotes === 0) return null; // No votes, no results.
iterations++;
// Go though each ballot and count the first choice for each
@ -45,7 +45,7 @@ function preformVote(arrayOfBallots) {
let lowestVoteAmount = Infinity;
let highestVoteAmount = -Infinity;
let highestVoteCandidate = "";
// let highestVoteCandidateTied = false; // If there are multiple candidates with the same amount of votes. TODO
let candidatesWithSameHighestVote = []; // Array of the highest voted for candidates
// Find the lowest amount of votes for a candidate
Object.keys(firstChoices).forEach((candidate) => {
@ -58,15 +58,43 @@ function preformVote(arrayOfBallots) {
if (firstChoices[candidate] < lowestVoteAmount) lowestVoteAmount = firstChoices[candidate];
});
// print(JSON.stringify(firstChoices, null, 4));
// Check to see if there are multiple candidates with the highest amount of votes
Object.keys(firstChoices).forEach((candidate) => {
// print(`Is ${firstChoices[candidate]} == ${highestVoteAmount}?`);
if (firstChoices[candidate] == highestVoteAmount) {
candidatesWithSameHighestVote.push(candidate);
// print(`Pushing ${candidate}`);
}
});
// Check to see if we have a winner.
// A winner is chosen when they have a total vote amount that is more than half of the total votes.
// print(JSON.stringify(firstChoices, null, 4));
// print(`Is ${highestVoteAmount} > ${Math.floor(ballotsStorage.length / 2)}`);
// TODO: Check for ties
if (highestVoteAmount > Math.floor(ballotsStorage.length / 2)) {
// Simple check for a winner.
if (highestVoteAmount > Math.floor(ballotsStorage.length / 2) && candidatesWithSameHighestVote.length == 1) {
const returnValue = {name: highestVoteCandidate, iterations: iterations};
iterations = 0; // Reset iterations.
ballotsStorage = []; // Reset the ballots array.
print("Normal exit");
return returnValue;
}
/*
[ "Hello", "World", "Goodbye", "-1" ],
[ "World", "Hello", "Goodbye", "-1" ],
[ "Hello", "World", "Goodbye" ],
[ "World", ],
[ ],
*/
// TODO: Check to see if this tie handling works.
if(candidatesWithSameHighestVote.length > 1 && candidatesWithSameHighestVote.length == Object.keys(firstChoices).length){
// We have a tie, show the tie
const returnValue = {name: candidatesWithSameHighestVote, iterations: iterations, tie: true};
iterations = 0; // Reset iterations.
ballotsStorage = []; // Reset the ballots array.
print("Tie exit");
return returnValue;
}