From 71ed32cb19697e5ff33cc6df8397f53321fd5893 Mon Sep 17 00:00:00 2001
From: armored-dragon <publicmail@armoreddragon.com>
Date: Wed, 18 Sep 2024 06:18:30 -0500
Subject: [PATCH] Handle ties. Fix running without casted votes causing
 exception.

---
 applications/voting/vote.js        | 11 +++++----
 applications/voting/vote_engine.js | 38 ++++++++++++++++++++++++++----
 2 files changed, 39 insertions(+), 10 deletions(-)

diff --git a/applications/voting/vote.js b/applications/voting/vote.js
index 455fdd3..9077295 100644
--- a/applications/voting/vote.js
+++ b/applications/voting/vote.js
@@ -12,8 +12,6 @@
 /* global Script Tablet Messages MyAvatar AvatarList Uuid SoundCache*/
 
 // TODO: Documentation
-// FIXME: Handle ties: kill both of tied results
-// FIXME: Handle ties: Last two standing are tied.
 // FIXME: Make the candidate name have reserved value "-1", or change to uncommon name.
 
 (() => {
@@ -232,10 +230,13 @@
 		});
 
 		const winner = voteEngine.preformVote(votesFormatted);
-		console.log(`Winner: ${winner.name}`);
+		if (!winner) return;
+		const winnerName = winner?.tie ? winner.name.join(', ') : winner.name;
+
+		console.log(`Winner: ${winnerName}`);
 
 		// Update the stats
-		pollStats.winnerName = winner.name;
+		pollStats.winnerName = winnerName;
 		pollStats.winnerSelected = true;
 		pollStats.votesCounted = Object.keys(pollStats.responses).length;
 		pollStats.iterations = winner.iterations;
@@ -323,7 +324,7 @@
 		case "run_election":
 			// Debug: Create a lot of fake ballots
 			if (debug) {
-				for (let i = 0; i < 25; ++i) {
+				for (let i = 0; i < 26; ++i) {
 					_debugDummyBallot();
 				}
 			}
diff --git a/applications/voting/vote_engine.js b/applications/voting/vote_engine.js
index 0dfc5bc..f414a61 100644
--- a/applications/voting/vote_engine.js
+++ b/applications/voting/vote_engine.js
@@ -19,7 +19,7 @@ function preformVote(arrayOfBallots) {
 	const totalAmountOfVotes = ballotsStorage.length;
 	let firstChoices = {};
 
-	if (totalAmountOfVotes === 0) return; // No votes, no results.
+	if (totalAmountOfVotes === 0) return null; // No votes, no results.
 	iterations++;
 
 	// Go though each ballot and count the first choice for each
@@ -45,7 +45,7 @@ function preformVote(arrayOfBallots) {
 	let lowestVoteAmount = Infinity;
 	let highestVoteAmount = -Infinity;
 	let highestVoteCandidate = "";
-	// let highestVoteCandidateTied = false; // If there are multiple candidates with the same amount of votes. TODO
+	let candidatesWithSameHighestVote = []; // Array of the highest voted for candidates
 
 	// Find the lowest amount of votes for a candidate
 	Object.keys(firstChoices).forEach((candidate) => { 
@@ -58,15 +58,43 @@ function preformVote(arrayOfBallots) {
 		if (firstChoices[candidate] < lowestVoteAmount) lowestVoteAmount = firstChoices[candidate];
 	});
 
+	// print(JSON.stringify(firstChoices, null, 4));
+	// Check to see if there are multiple candidates with the highest amount of votes
+	Object.keys(firstChoices).forEach((candidate) => { 
+		// print(`Is ${firstChoices[candidate]} == ${highestVoteAmount}?`);
+		if (firstChoices[candidate] == highestVoteAmount) {
+			candidatesWithSameHighestVote.push(candidate);
+			// print(`Pushing ${candidate}`);
+		}
+	});
+
 	// Check to see if we have a winner.
 	// A winner is chosen when they have a total vote amount that is more than half of the total votes.
-	// print(JSON.stringify(firstChoices, null, 4));
 	// print(`Is ${highestVoteAmount} > ${Math.floor(ballotsStorage.length / 2)}`);
-	// TODO: Check for ties
-	if (highestVoteAmount > Math.floor(ballotsStorage.length / 2)) {
+	// Simple check for a winner.
+	if (highestVoteAmount > Math.floor(ballotsStorage.length / 2) && candidatesWithSameHighestVote.length == 1) {
 		const returnValue = {name: highestVoteCandidate, iterations: iterations};
 		iterations = 0; // Reset iterations.
 		ballotsStorage = []; // Reset the ballots array.
+		print("Normal exit");
+		return returnValue;
+	}
+
+	/* 
+	[ "Hello", "World", "Goodbye", "-1" ],
+	[ "World", "Hello", "Goodbye", "-1" ],
+	[ "Hello", "World", "Goodbye"      	],
+	[ "World", 							],	
+	[ 		 							],	
+	*/
+
+	// TODO: Check to see if this tie handling works. 
+	if(candidatesWithSameHighestVote.length > 1 && candidatesWithSameHighestVote.length == Object.keys(firstChoices).length){
+		// We have a tie, show the tie
+		const returnValue = {name: candidatesWithSameHighestVote, iterations: iterations, tie: true};
+		iterations = 0; // Reset iterations.
+		ballotsStorage = []; // Reset the ballots array.
+		print("Tie exit");
 		return returnValue;
 	}