overte/scripts/system/libraries
LaShonda Hopper fe171af31b [Case 6491] entitySelectionTool mousePressEvent refactor/cleanup (details below).
Fixes situations where attempting to click on a rotate, grab,
or scale handle that was in front of others might unexpectedly
activate the obscured handle.

As of this commit the flow of mousePressEvent such that the
first item whether it be a tool or selection is what reacts
and absorbs the click/touch.  This is counter to the prior
behavior where whichever item or tool last passed the check
would determine what was hit and handled the touch _even_
when it wasn't the first thing to be touched.

* Got rid of some unused/stale vars
* Added some convenience functions
    * setRotationHandlesVisible function
    * setStretchHandlesVisible function
    * setGrabberMoveUpVisible function
* Removed checkIntersectWith helper functions as they're
  no longer used.
* Normalized onBegin signatures for all GrabberTools to
  support the new flow within mousePressEvent.
    * These are tools registered via addGrabberTool/makeStretchTool.
    * The onBegin signature changes from onBegin( event ) to
      onBegin( event, intersectResult ).
        * This allows for a simpler tool triggering where tools which
          utilized the additional information provided will have it,
          those which may need it the future shall have it with little
          issue, and those that don't care may ignore it.

NOTE(s):
* Tested normal movement within opening creation menu:  Passed
* With Creation Menu Open:
    * Tested clicking around the world in empty space: Passed
    * Tested single selection: Passed
    * Tested single selection rotation (pitch, yaw, roll): Passed
    * Tested single selection translation (xz, y): Passed
    * Tested multiple selection: Passed
    * Tested multiple selection rotation (pitch, yaw, roll): Passed
    * Tested multiple selection translation (xz, y): Passed

Reviewed-by: Leander Hasty <leander@1stplayable.com>

Changes Committed:
	modified:   scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:04:27 -04:00
..
accountUtils.js fix wallet login (and share code with snapshot login) 2017-08-29 16:05:01 -07:00
cloneEntityUtils.js fix grab entity methods + jshint cleanups 2017-09-15 10:50:46 -07:00
controllerDispatcherUtils.js Merge pull request #11430 from sethalves/fix-parent-grab 2017-09-26 13:00:16 -07:00
controllers.js Bug fixes for laser offset and avatar hold action 2017-08-31 17:26:00 -07:00
dataViewHelpers.js move default to system 2016-04-26 14:47:02 -07:00
entityCameraTool.js change all references of Quat.getFront to Quat.getForward in scripts directory 2017-03-21 22:25:30 +00:00
entityIconOverlayManager.js Fixed Icons not being selectable while not highlighted. 2017-07-08 02:52:27 -07:00
entityList.js Keep old function names for compatibility 2017-08-16 22:17:34 +02:00
entitySelectionTool.js [Case 6491] entitySelectionTool mousePressEvent refactor/cleanup (details below). 2017-09-28 15:04:27 -04:00
globals.js move default to system 2016-04-26 14:47:02 -07:00
gridTool.js Merge pull request #10569 from ctrlaltdavid/21312 2017-06-02 15:45:18 -07:00
overlayUtils.js move default to system 2016-04-26 14:47:02 -07:00
progressDialog.js move default to system 2016-04-26 14:47:02 -07:00
soundArray.js change all references of Quat.getFront to Quat.getForward in scripts directory 2017-03-21 22:25:30 +00:00
stringHelpers.js move default to system 2016-04-26 14:47:02 -07:00
toolBars.js Make the time and slider follow the record.js toolbar 2017-03-08 01:14:11 +01:00
ToolTip.js move default to system 2016-04-26 14:47:02 -07:00
touchEventUtils.js fixing and cleanup tablet inputs 2017-09-19 17:03:53 -07:00
Trigger.js Make hand pointer lasers 'click' on fully pressing and clicking the vive controller 2016-07-14 10:30:35 -07:00
utils.js Fixes for scaling controller display 2017-09-05 15:03:41 -07:00
WebTablet.js 7723 Tablet Should Rotate Faster when using Create app 2017-09-21 16:26:54 +03:00
Xform.js WIP, equip-points work but they don't use the proper attach point. 2016-06-29 13:53:06 -07:00