Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-30 00:23:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
overte/interface/src/scripting
History
Anthony J. Thibault 70a3c9ce3c Fix for heap-corruption in Settings::saveAll due to implicitly shared QStrings 
Using gflags on windows and enabling full page heap verification, I was able to detect this as a source of
memory corruption.

https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/enable-page-heap

Running interface with pageheap before and after, this change leads me to believe that this is a source of
some of our heap-corruption crashes on backtrace.

Specifically these 19 crashes in the last month, and possibly more.

https://highfidelity.sp.backtrace.io/dashboard/highfidelity/project/Interface/query-builder?qb=%7B%22mode%22%3A%22aggregate%22%2C%22sorting%22%3A%7B%22aggFactor%22%3A%22count%22%2C%22aggSortOrder%22%3A%22descending%22%2C%22selectFactor%22%3A%22timestamp%22%2C%22selectSortOrder%22%3A%22descending%22%2C%22sortedColumnNames%22%3A%5B%5D%7D%2C%22dateTimePicker%22%3A%7B%22granularity%22%3A%221M%22%2C%22start%22%3A%222018-05-27T07%3A00%3A00.000Z%22%2C%22end%22%3A%222018-06-27T23%3A05%3A29.399Z%22%7D%7D&qn=&query=%7B%22filter%22%3A%5B%7B%22callstack%22%3A%5B%5B%22contains%22%2C%22saveAll%22%5D%5D%2C%22timestamp%22%3A%5B%5B%22at-least%22%2C1527404400%5D%2C%5B%22at-most%22%2C1530140729%5D%5D%7D%5D%2C%22fold%22%3A%7B%22timestamp%22%3A%5B%5B%22range%22%5D%2C%5B%22bin%22%2C32%2C1527404400%2C1530140729%5D%5D%7D%2C%22group%22%3A%5B%22classifiers%22%5D%2C%22select%22%3A%5B%22timestamp%22%2C%22fingerprint%22%2C%22_deleted%22%2C%22callstack%22%2C%22object%22%5D%7D
2018-06-27 16:06:23 -07:00
..
AccountServicesScriptingInterface.cpp Fix non self-sufficient headers 2018-05-04 16:26:41 -07:00
AccountServicesScriptingInterface.h Fix non self-sufficient headers 2018-05-04 16:26:41 -07:00
AssetMappingsScriptingInterface.cpp Merge pull request #12684 from vladest/assetserver_wrong_dialog 2018-04-02 15:28:46 -07:00
AssetMappingsScriptingInterface.h fix sorting 2018-03-14 09:17:22 -07:00
Audio.cpp fix copy error 2018-04-23 12:05:30 -07:00
Audio.h AudioEffectOptions API JSDoc stubs 2018-05-11 20:36:10 +12:00
AudioDevices.cpp Fix non self-sufficient headers 2018-05-04 16:26:41 -07:00
AudioDevices.h temporarily select 'similar-by-title' device if previously selected one was unlplugged; re-select originally selected device if it was re-plugged 2018-03-27 00:44:17 +03:00
ClipboardScriptingInterface.cpp Update JSDoc for Clipboard JavaScript API 2017-11-10 21:53:55 +13:00
ClipboardScriptingInterface.h List which contexts each namespace and object is available in 2018-04-28 20:00:28 +12:00
ControllerScriptingInterface.cpp Android - Make joystick move up when showing the bottom bar 2018-02-28 18:52:13 -03:00
ControllerScriptingInterface.h Remove some deprecated functions from the Controller API 2018-06-05 10:56:19 +12:00
DesktopScriptingInterface.cpp
DesktopScriptingInterface.h
DialogsManagerScriptingInterface.cpp
DialogsManagerScriptingInterface.h
GooglePolyScriptingInterface.cpp Fix non self-sufficient headers 2018-05-04 16:26:41 -07:00
GooglePolyScriptingInterface.h List which contexts each namespace and object is available in 2018-04-28 20:00:28 +12:00
HMDScriptingInterface.cpp reset tablet contextual mode back to false when toggling tablet show/hide 2017-10-24 15:50:09 -07:00
HMDScriptingInterface.h making requested changes 2018-06-07 14:04:39 -07:00
MenuScriptingInterface.cpp Remove Menu.isInfoViewVisible() and closeInfoView() from JavaScript API 2018-02-04 15:38:33 +13:00
MenuScriptingInterface.h List which contexts each namespace and object is available in 2018-04-28 20:00:28 +12:00
RatesScriptingInterface.h
SelectionScriptingInterface.cpp Interim JSDoc for Selection 2018-04-23 13:53:35 +12:00
SelectionScriptingInterface.h Merge branch 'master' of https://github.com/highfidelity/hifi into gravprep-redo 2018-05-03 23:08:06 -07:00
SettingsScriptingInterface.cpp Fix for heap-corruption in Settings::saveAll due to implicitly shared QStrings 2018-06-27 16:06:23 -07:00
SettingsScriptingInterface.h List which contexts each namespace and object is available in 2018-04-28 20:00:28 +12:00
TestScriptingInterface.cpp Added hide/show for task bar (Windows only). 2018-05-24 16:48:03 -07:00
TestScriptingInterface.h Updated jsdoc 2018-05-29 11:50:23 -07:00
WalletScriptingInterface.cpp changing back to avatar only and making some changes to avoid multiple calls to dependency manager 2018-01-29 12:46:00 -08:00
WalletScriptingInterface.h Fix Wallet JSDoc stubs 2018-05-14 10:43:55 +12:00
WindowScriptingInterface.cpp MS15529: Add secondary camera snapshot notification flag 2018-06-01 13:38:41 -07:00
WindowScriptingInterface.h Be a bit more specific in the docs 2018-06-18 11:47:26 -07:00