* Added getDomainMaxScale() and getDomainMinScale() to JS api.
* Updated scaleAvatar controller module to use this to prevent scaling past the limits.
* Made sure that getDomainMaxScale() getDomainMinScale() and getUnscaledEyeHeight are thread safe,
so that they can be invoked on the script thread.
* Added signals to Model class that can be used to let observers know when the Rig has finished initializing it's skeleton.
and also when the skeleton is no longer valid. These hooks are used to cache the unscaled eye height of the avatar.
When creating or selecting an object entityProperties.html's properties-list is
updated to have and entity type specific class. This class is used within
edit-style.css to specify rules for the Properties Tab when a certain type of
entity is currently selected.
This resolves the issue with duplicate/misleading color fields for Particle
Effects by adding .ParticleEffectMenu rules to edit-style.css to control the
visible sections.
When the Properties Tab is in the ParticleEffectMenu mode only the following
sections are shown (listed as ordered):
General Section
Collision Section
Physical Section
Spatial Section
Behavior Section
Changes Committed:
modified: scripts/system/html/css/edit-style.css
modified: scripts/system/html/js/entityProperties.js
* Fixes the following:
* 1775:5 error 'augmentSpinButtons' is not defined no-undef
* 1777:5 error 'setUpKeyboardControl' is not defined no-undef
ESLint Issue Count is now 0.
Changes Committed:
modified: scripts/system/html/js/entityProperties.js
* Fixes the following errors:
* 590:13 error 'elJSONEditor' is assigned a value but never used no-unused-vars
* 592:13 error 'elColorSections' is assigned a value but never used no-unused-vars
* 641:13 error 'elHyperlinkSections' is assigned a value but never used no-unused-vars
* 653:13 error 'elTextBackgroundColor' is assigned a value but never used no-unused-vars
* 670:13 error 'elZoneKeyLightDirectionZ' is assigned a value but never used no-unused-vars
* 695:13 error 'elZoneHazeAttenuateKeyLight' is assigned a value but never used no-unused-vars
* 696:13 error 'elZoneHazeKeyLightRange' is assigned a value but never used no-unused-vars
* 697:13 error 'elZoneHazeKeyLightAltitude' is assigned a value but never used no-unused-vars
* This reduces eslint errors from 67 to 50
* Removes instances of stale commented code found when removing the above related items.
* Removes allSections array which doesn't appear to be actively used save registering _certain_ sections.
* Removed registered section vars which weren't actually in use aside from being registered.
Changes Committed:
modified: scripts/system/html/js/entityProperties.js
* 3 JSHint issues remain as of this commit, 3 instances of the same error.
* Error: Functions declared within loops referencing an outer scoped
variable may lead to confusing semantics.
* scripts/system/html/js/entityProperties.js: line 469, col 27
* scripts/system/html/js/entityProperties.js: line 1634, col 30
* scripts/system/html/js/entityProperties.js: line 1641, col 32
Tested and prior fix to remove duplicate color fields for entity types is
preserved for non-particle entity types.
Changes Committed:
modified: scripts/system/html/js/entityProperties.js
There are 2 types or styles of color picker controls.
* color-control1: Composed of only a color picker
* color-control2: Composed of a color picker and rgb fields. The color can be
manipulated by either.
Previously for shapes, the Properties tab utilized both types of color controls.
Color-control1 was displayed within the quick properties section; whereas, color-control2 was
displayed farther down within the more detailed sections of Properties tab.
This commit removes the duplication of the fields, opting to utilize color-control2 within
the quick properties portion of the Properties tab.
Changes Committed:
modified: scripts/system/html/entityProperties.html
modified: scripts/system/html/js/entityProperties.js