Merge branch 'master' of github.com:highfidelity/hifi into kinematic-grab

assignment-client/src/entities/EntityServer.h

@@ -26,28 +26,28 @@ public:
     ~EntityServer();
 
     // Subclasses must implement these methods
-    virtual OctreeQueryNode* createOctreeQueryNode();
+    virtual OctreeQueryNode* createOctreeQueryNode() override ;
-    virtual char getMyNodeType() const { return NodeType::EntityServer; }
+    virtual char getMyNodeType() const override { return NodeType::EntityServer; }
-    virtual PacketType getMyQueryMessageType() const { return PacketType::EntityQuery; }
+    virtual PacketType getMyQueryMessageType() const override { return PacketType::EntityQuery; }
-    virtual const char* getMyServerName() const { return MODEL_SERVER_NAME; }
+    virtual const char* getMyServerName() const override { return MODEL_SERVER_NAME; }
-    virtual const char* getMyLoggingServerTargetName() const { return MODEL_SERVER_LOGGING_TARGET_NAME; }
+    virtual const char* getMyLoggingServerTargetName() const override { return MODEL_SERVER_LOGGING_TARGET_NAME; }
-    virtual const char* getMyDefaultPersistFilename() const { return LOCAL_MODELS_PERSIST_FILE; }
+    virtual const char* getMyDefaultPersistFilename() const override { return LOCAL_MODELS_PERSIST_FILE; }
-    virtual PacketType getMyEditNackType() const { return PacketType::EntityEditNack; }
+    virtual PacketType getMyEditNackType() const override { return PacketType::EntityEditNack; }
-    virtual QString getMyDomainSettingsKey() const { return QString("entity_server_settings"); }
+    virtual QString getMyDomainSettingsKey() const override { return QString("entity_server_settings"); }
 
     // subclass may implement these method
-    virtual void beforeRun();
+    virtual void beforeRun() override;
-    virtual bool hasSpecialPacketsToSend(const SharedNodePointer& node);
+    virtual bool hasSpecialPacketsToSend(const SharedNodePointer& node) override;
-    virtual int sendSpecialPackets(const SharedNodePointer& node, OctreeQueryNode* queryNode, int& packetsSent);
+    virtual int sendSpecialPackets(const SharedNodePointer& node, OctreeQueryNode* queryNode, int& packetsSent) override;
 
-    virtual void entityCreated(const EntityItem& newEntity, const SharedNodePointer& senderNode);
+    virtual void entityCreated(const EntityItem& newEntity, const SharedNodePointer& senderNode) override;
     virtual bool readAdditionalConfiguration(const QJsonObject& settingsSectionObject) override;
 
 public slots:
     void pruneDeletedEntities();
 
 protected:
-    virtual OctreePointer createTree();
+    virtual OctreePointer createTree() override;
 
 private slots:
     void handleEntityPacket(QSharedPointer<NLPacket> packet, SharedNodePointer senderNode);

domain-server/src/DomainServer.cpp

@@ -133,33 +133,14 @@ bool DomainServer::optionallyReadX509KeyAndCertificate() {
     QString keyPath = _settingsManager.getSettingsMap().value(X509_PRIVATE_KEY_OPTION).toString();
 
     if (!certPath.isEmpty() && !keyPath.isEmpty()) {
-        // the user wants to use DTLS to encrypt communication with nodes
+        // the user wants to use the following cert and key for HTTPS
+        // this is used for Oauth callbacks when authorizing users against a data server
         // let's make sure we can load the key and certificate
-//        _x509Credentials = new gnutls_certificate_credentials_t;
-//        gnutls_certificate_allocate_credentials(_x509Credentials);
 
         QString keyPassphraseString = QProcessEnvironment::systemEnvironment().value(X509_KEY_PASSPHRASE_ENV);
 
-        qDebug() << "Reading certificate file at" << certPath << "for DTLS.";
+        qDebug() << "Reading certificate file at" << certPath << "for HTTPS.";
-        qDebug() << "Reading key file at" << keyPath << "for DTLS.";
+        qDebug() << "Reading key file at" << keyPath << "for HTTPS.";    
-
-//        int gnutlsReturn = gnutls_certificate_set_x509_key_file2(*_x509Credentials,
-//                                                                 certPath.toLocal8Bit().constData(),
-//                                                                 keyPath.toLocal8Bit().constData(),
-//                                                                 GNUTLS_X509_FMT_PEM,
-//                                                                 keyPassphraseString.toLocal8Bit().constData(),
-//                                                                 0);
-//
-//        if (gnutlsReturn < 0) {
-//            qDebug() << "Unable to load certificate or key file." << "Error" << gnutlsReturn << "- domain-server will now quit.";
-//            QMetaObject::invokeMethod(this, "quit", Qt::QueuedConnection);
-//            return false;
-//        }
-
-//        qDebug() << "Successfully read certificate and private key.";
-
-        // we need to also pass this certificate and private key to the HTTPS manager
-        // this is used for Oauth callbacks when authorizing users against a data server
 
         QFile certFile(certPath);
         certFile.open(QIODevice::ReadOnly);

examples/example/hmd/ipdScalingTest.js

@@ -0,0 +1,42 @@
+//
+//  Created by Bradley Austin Davis on 2015/10/04
+//  Copyright 2013-2015 High Fidelity, Inc.
+//
+//  Distributed under the Apache License, Version 2.0.
+//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
+//
+
+IPDScalingTest = function() {
+    // Switch every 5 seconds between normal IPD and 0 IPD (in seconds)
+    this.UPDATE_INTERVAL = 10.0;
+    this.lastUpdateInterval = 0;
+    this.scaled = false;
+
+    var that = this;
+    Script.scriptEnding.connect(function() {
+        that.onCleanup();
+    });
+
+    Script.update.connect(function(deltaTime) {
+        that.lastUpdateInterval += deltaTime;
+        if (that.lastUpdateInterval >= that.UPDATE_INTERVAL) {
+            that.onUpdate(that.lastUpdateInterval);
+            that.lastUpdateInterval = 0;
+        }
+    });
+}
+
+IPDScalingTest.prototype.onCleanup = function() {
+    HMD.setIPDScale(1.0);
+}
+
+IPDScalingTest.prototype.onUpdate = function(deltaTime) {
+    this.scaled = !this.scaled;
+    if (this.scaled) {
+        HMD.ipdScale = 0.0;
+    } else {
+        HMD.ipdScale = 1.0;
+    }
+}
+
+new IPDScalingTest();

examples/utilities/tools/MonoHMD.js

@@ -0,0 +1,68 @@
+//
+//  MonoHMD.js
+//
+//  Created by Chris Collins on 10/5/15
+//  Copyright 2015 High Fidelity, Inc.
+//
+//  This script allows you to switch between mono and stereo mode within the HMD.
+//  It will add adition menu to Tools called "IPD". 
+//
+//  Distributed under the Apache License, Version 2.0.
+//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
+
+
+
+
+function setupipdMenu() {
+    if (!Menu.menuExists("Tools > IPD")) {
+        Menu.addMenu("Tools > IPD");
+    }
+    if (!Menu.menuItemExists("Tools > IPD", "Stereo")) {
+        Menu.addMenuItem({
+            menuName: "Tools > IPD",
+            menuItemName: "Stereo",
+            isCheckable: true,
+            isChecked: true
+        });
+    }
+    if (!Menu.menuItemExists("Tools > IPD", "Mono")) {
+        Menu.addMenuItem({
+            menuName: "Tools > IPD",
+            menuItemName: "Mono",
+            isCheckable: true,
+            isChecked: false
+        });
+    }
+
+}
+
+
+function menuItemEvent(menuItem) {
+    if (menuItem == "Stereo") {
+        Menu.setIsOptionChecked("Mono", false);
+        HMD.ipdScale = 1.0;
+
+    }
+    if (menuItem == "Mono") {
+        Menu.setIsOptionChecked("Stereo", false);
+        HMD.ipdScale = 0.0;
+    }
+
+}
+
+
+
+function scriptEnding() {
+
+    Menu.removeMenuItem("Tools > IPD", "Stereo");
+    Menu.removeMenuItem("Tools > IPD", "Mono");
+    Menu.removeMenu("Tools > IPD");
+    //reset the HMD to stereo mode
+    HMD.setIPDScale(1.0);
+
+}
+
+
+setupipdMenu();
+Menu.menuItemEvent.connect(menuItemEvent);
+Script.scriptEnding.connect(scriptEnding);

interface/src/Application.cpp

@@ -300,6 +300,7 @@ bool setupEssentials(int& argc, char** argv) {
     auto desktopScriptingInterface = DependencyManager::set<DesktopScriptingInterface>();
     auto entityScriptingInterface = DependencyManager::set<EntityScriptingInterface>();
     auto windowScriptingInterface = DependencyManager::set<WindowScriptingInterface>();
+    auto hmdScriptingInterface = DependencyManager::set<HMDScriptingInterface>();
 #if defined(Q_OS_MAC) || defined(Q_OS_WIN)
     auto speechRecognizer = DependencyManager::set<SpeechRecognizer>();
 #endif
@@ -1203,9 +1204,11 @@ void Application::paintGL() {
             // right eye.  There are FIXMEs in the relevant plugins
             _myCamera.setProjection(displayPlugin->getProjection(Mono, _myCamera.getProjection()));
             renderArgs._context->enableStereo(true);
-            mat4 eyeViews[2];
+            mat4 eyeOffsets[2];
             mat4 eyeProjections[2];
             auto baseProjection = renderArgs._viewFrustum->getProjection();
+            auto hmdInterface = DependencyManager::get<HMDScriptingInterface>();
+            float IPDScale = hmdInterface->getIPDScale();
             // FIXME we probably don't need to set the projection matrix every frame,
             // only when the display plugin changes (or in non-HMD modes when the user 
             // changes the FOV manually, which right now I don't think they can.
@@ -1214,14 +1217,24 @@ void Application::paintGL() {
                 // applied to the avatar, so we need to get the difference between the head 
                 // pose applied to the avatar and the per eye pose, and use THAT as
                 // the per-eye stereo matrix adjustment.
-                mat4 eyePose = displayPlugin->getEyePose(eye);
+                mat4 eyeToHead = displayPlugin->getEyeToHeadTransform(eye);
+                // Grab the translation
+                vec3 eyeOffset = glm::vec3(eyeToHead[3]);
+                // Apply IPD scaling
+                mat4 eyeOffsetTransform = glm::translate(mat4(), eyeOffset * -1.0f * IPDScale);
+                eyeOffsets[eye] = eyeOffsetTransform;
+
+                // Tell the plugin what pose we're using to render.  In this case we're just using the 
+                // unmodified head pose because the only plugin that cares (the Oculus plugin) uses it 
+                // for rotational timewarp.  If we move to support positonal timewarp, we need to 
+                // ensure this contains the full pose composed with the eye offsets.  
                 mat4 headPose = displayPlugin->getHeadPose();
-                mat4 eyeView = glm::inverse(eyePose) * headPose;
+                displayPlugin->setEyeRenderPose(eye, headPose);
-                eyeViews[eye] = eyeView;
+
                 eyeProjections[eye] = displayPlugin->getProjection(eye, baseProjection);
             });
             renderArgs._context->setStereoProjections(eyeProjections);
-            renderArgs._context->setStereoViews(eyeViews);
+            renderArgs._context->setStereoViews(eyeOffsets);
         }
         displaySide(&renderArgs, _myCamera);
         renderArgs._context->enableStereo(false);
@@ -4130,7 +4143,7 @@ void Application::registerScriptEngineWithApplicationServices(ScriptEngine* scri
 
     scriptEngine->registerGlobalObject("Paths", DependencyManager::get<PathUtils>().data());
 
-    scriptEngine->registerGlobalObject("HMD", &HMDScriptingInterface::getInstance());
+    scriptEngine->registerGlobalObject("HMD", DependencyManager::get<HMDScriptingInterface>().data());
     scriptEngine->registerFunction("HMD", "getHUDLookAtPosition2D", HMDScriptingInterface::getHUDLookAtPosition2D, 0);
     scriptEngine->registerFunction("HMD", "getHUDLookAtPosition3D", HMDScriptingInterface::getHUDLookAtPosition3D, 0);
 
@@ -4980,19 +4993,25 @@ mat4 Application::getEyeProjection(int eye) const {
 
 mat4 Application::getEyePose(int eye) const {
     if (isHMDMode()) {
-        return getActiveDisplayPlugin()->getEyePose((Eye)eye);
+        auto hmdInterface = DependencyManager::get<HMDScriptingInterface>();
+        float IPDScale = hmdInterface->getIPDScale();
+        auto displayPlugin = getActiveDisplayPlugin();
+        mat4 headPose = displayPlugin->getHeadPose();
+        mat4 eyeToHead = displayPlugin->getEyeToHeadTransform((Eye)eye);
+        {
+            vec3 eyeOffset = glm::vec3(eyeToHead[3]);
+            // Apply IPD scaling
+            mat4 eyeOffsetTransform = glm::translate(mat4(), eyeOffset * -1.0f * IPDScale);
+            eyeToHead[3] = vec4(eyeOffset, 1.0);
+        }
+        return eyeToHead * headPose;
     }
-
     return mat4();
 }
 
 mat4 Application::getEyeOffset(int eye) const {
-    if (isHMDMode()) {
+    // FIXME invert?
-        mat4 identity;
+    return getActiveDisplayPlugin()->getEyeToHeadTransform((Eye)eye);
-        return getActiveDisplayPlugin()->getView((Eye)eye, identity);
-    }
-
-    return mat4();
 }
 
 mat4 Application::getHMDSensorPose() const {

interface/src/PluginContainerProxy.cpp

@@ -16,6 +16,9 @@ PluginContainerProxy::PluginContainerProxy() {
     Plugin::setContainer(this);
 }
 
+PluginContainerProxy::~PluginContainerProxy() {
+}
+
 bool PluginContainerProxy::isForeground() {
     return qApp->_isForeground && !qApp->getWindow()->isMinimized();
 }
@@ -139,6 +142,10 @@ void PluginContainerProxy::unsetFullscreen(const QScreen* avoid) {
 #endif
 }
 
+void PluginContainerProxy::requestReset() {
+    // We could signal qApp to sequence this, but it turns out that requestReset is only used from within the main thread anyway.
+    qApp->resetSensors();
+}
 
 void PluginContainerProxy::showDisplayPluginsTools() {
     DependencyManager::get<DialogsManager>()->hmdTools(true);
@@ -147,3 +154,7 @@ void PluginContainerProxy::showDisplayPluginsTools() {
 QGLWidget* PluginContainerProxy::getPrimarySurface() {
     return qApp->_glWidget;
 }
+
+const DisplayPlugin* PluginContainerProxy::getActiveDisplayPlugin() const {
+    return qApp->getActiveDisplayPlugin();
+}

interface/src/PluginContainerProxy.h

@@ -11,17 +11,21 @@
 class PluginContainerProxy : public QObject, PluginContainer {
     Q_OBJECT
     PluginContainerProxy();
+    virtual ~PluginContainerProxy();
     virtual void addMenu(const QString& menuName) override;
     virtual void removeMenu(const QString& menuName) override;
     virtual QAction* addMenuItem(const QString& path, const QString& name, std::function<void(bool)> onClicked, bool checkable = false, bool checked = false, const QString& groupName = "") override;
     virtual void removeMenuItem(const QString& menuName, const QString& menuItem) override;
     virtual bool isOptionChecked(const QString& name) override;
-    virtual void setIsOptionChecked(const QString& path, bool checked);
+    virtual void setIsOptionChecked(const QString& path, bool checked) override;
     virtual void setFullscreen(const QScreen* targetScreen, bool hideMenu = true) override;
     virtual void unsetFullscreen(const QScreen* avoidScreen = nullptr) override;
     virtual void showDisplayPluginsTools() override;
+    virtual void requestReset() override;
     virtual QGLWidget* getPrimarySurface() override;
     virtual bool isForeground() override;
+    virtual const DisplayPlugin* getActiveDisplayPlugin() const override;
+
     QRect _savedGeometry{ 10, 120, 800, 600 };
 
     friend class Application;

interface/src/avatar/MyAvatar.cpp

@@ -1341,11 +1341,13 @@ void MyAvatar::renderBody(RenderArgs* renderArgs, ViewFrustum* renderFrustum, fl
     if (qApp->isHMDMode()) {
         glm::vec3 cameraPosition = Application::getInstance()->getCamera()->getPosition();
 
-        glm::mat4 leftEyePose = Application::getInstance()->getActiveDisplayPlugin()->getEyePose(Eye::Left);
-        glm::vec3 leftEyePosition = glm::vec3(leftEyePose[3]);
-        glm::mat4 rightEyePose = Application::getInstance()->getActiveDisplayPlugin()->getEyePose(Eye::Right);
-        glm::vec3 rightEyePosition = glm::vec3(rightEyePose[3]);
         glm::mat4 headPose = Application::getInstance()->getActiveDisplayPlugin()->getHeadPose();
+        glm::mat4 leftEyePose = Application::getInstance()->getActiveDisplayPlugin()->getEyeToHeadTransform(Eye::Left);
+        leftEyePose = leftEyePose * headPose;
+        glm::vec3 leftEyePosition = glm::vec3(leftEyePose[3]);
+        glm::mat4 rightEyePose = Application::getInstance()->getActiveDisplayPlugin()->getEyeToHeadTransform(Eye::Right);
+        rightEyePose = rightEyePose * headPose;
+        glm::vec3 rightEyePosition = glm::vec3(rightEyePose[3]);
         glm::vec3 headPosition = glm::vec3(headPose[3]);
 
         getHead()->renderLookAts(renderArgs,

interface/src/avatar/MyAvatar.h

@@ -139,19 +139,19 @@ public:
     void updateLookAtTargetAvatar();
     void clearLookAtTargetAvatar();
 
-    virtual void setJointRotations(QVector<glm::quat> jointRotations);
+    virtual void setJointRotations(QVector<glm::quat> jointRotations) override;
-    virtual void setJointTranslations(QVector<glm::vec3> jointTranslations);
+    virtual void setJointTranslations(QVector<glm::vec3> jointTranslations) override;
-    virtual void setJointData(int index, const glm::quat& rotation, const glm::vec3& translation);
+    virtual void setJointData(int index, const glm::quat& rotation, const glm::vec3& translation) override;
-    virtual void setJointRotation(int index, const glm::quat& rotation);
+    virtual void setJointRotation(int index, const glm::quat& rotation) override;
-    virtual void setJointTranslation(int index, const glm::vec3& translation);
+    virtual void setJointTranslation(int index, const glm::vec3& translation) override;
-    virtual void clearJointData(int index);
+    virtual void clearJointData(int index) override;
-    virtual void clearJointsData();
+    virtual void clearJointsData() override;
 
     Q_INVOKABLE void useFullAvatarURL(const QUrl& fullAvatarURL, const QString& modelName = QString());
     Q_INVOKABLE const QUrl& getFullAvatarURLFromPreferences() const { return _fullAvatarURLFromPreferences; }
     Q_INVOKABLE const QString& getFullAvatarModelName() const { return _fullAvatarModelName; }
 
-    virtual void setAttachmentData(const QVector<AttachmentData>& attachmentData);
+    virtual void setAttachmentData(const QVector<AttachmentData>& attachmentData) override;
 
     DynamicCharacterController* getCharacterController() { return &_characterController; }
 
@@ -218,7 +218,7 @@ public slots:
     void saveRecording(QString filename);
     void loadLastRecording();
 
-    virtual void rebuildSkeletonBody();
+    virtual void rebuildSkeletonBody() override;
 
     bool getEnableRigAnimations() const { return _rig->getEnableRig(); }
     void setEnableRigAnimations(bool isEnabled);
@@ -243,7 +243,7 @@ private:
 
     glm::vec3 getWorldBodyPosition() const;
     glm::quat getWorldBodyOrientation() const;
-    QByteArray toByteArray(bool cullSmallChanges, bool sendAll);
+    QByteArray toByteArray(bool cullSmallChanges, bool sendAll) override;
     void simulate(float deltaTime);
     void updateFromTrackers(float deltaTime);
     virtual void render(RenderArgs* renderArgs, const glm::vec3& cameraPositio) override;
@@ -252,9 +252,9 @@ private:
     void setShouldRenderLocally(bool shouldRender) { _shouldRender = shouldRender; }
     bool getShouldRenderLocally() const { return _shouldRender; }
     bool getDriveKeys(int key) { return _driveKeys[key] != 0.0f; };
-    bool isMyAvatar() const { return true; }
+    bool isMyAvatar() const override { return true; }
-    virtual int parseDataFromBuffer(const QByteArray& buffer);
+    virtual int parseDataFromBuffer(const QByteArray& buffer) override;
-    virtual glm::vec3 getSkeletonPosition() const;
+    virtual glm::vec3 getSkeletonPosition() const override;
 
     glm::vec3 getScriptedMotorVelocity() const { return _scriptedMotorVelocity; }
     float getScriptedMotorTimescale() const { return _scriptedMotorTimescale; }
@@ -264,7 +264,7 @@ private:
     void setScriptedMotorFrame(QString frame);
     virtual void attach(const QString& modelURL, const QString& jointName = QString(),
                         const glm::vec3& translation = glm::vec3(), const glm::quat& rotation = glm::quat(), float scale = 1.0f,
-                        bool allowDuplicates = false, bool useSaved = true);
+                        bool allowDuplicates = false, bool useSaved = true) override;
 
     void renderLaserPointers(gpu::Batch& batch);
     const RecorderPointer getRecorder() const { return _recorder; }
@@ -273,8 +273,8 @@ private:
     bool cameraInsideHead() const;
 
     // These are made private for MyAvatar so that you will use the "use" methods instead
-    virtual void setFaceModelURL(const QUrl& faceModelURL);
+    virtual void setFaceModelURL(const QUrl& faceModelURL) override;
-    virtual void setSkeletonModelURL(const QUrl& skeletonModelURL);
+    virtual void setSkeletonModelURL(const QUrl& skeletonModelURL) override;
 
     void setVisibleInSceneIfReady(Model* model, render::ScenePointer scene, bool visiblity);
 

interface/src/avatar/SkeletonModel.h

@@ -27,10 +27,10 @@ public:
     SkeletonModel(Avatar* owningAvatar, QObject* parent = nullptr, RigPointer rig = nullptr);
     ~SkeletonModel();
 
-    virtual void initJointStates(QVector<JointState> states);
+    virtual void initJointStates(QVector<JointState> states) override;
 
-    virtual void simulate(float deltaTime, bool fullUpdate = true);
+    virtual void simulate(float deltaTime, bool fullUpdate = true) override;
-    virtual void updateRig(float deltaTime, glm::mat4 parentTransform);
+    virtual void updateRig(float deltaTime, glm::mat4 parentTransform) override;
     void updateAttitude();
 
     void renderIKConstraints(gpu::Batch& batch);

interface/src/scripting/HMDScriptingInterface.cpp

@@ -10,12 +10,46 @@
 //
 
 #include "HMDScriptingInterface.h"
+
+#include <QtScript/QScriptContext>
+
 #include "display-plugins/DisplayPlugin.h"
 #include <avatar/AvatarManager.h>
+#include "Application.h"
 
-HMDScriptingInterface& HMDScriptingInterface::getInstance() {
+HMDScriptingInterface::HMDScriptingInterface() {
-    static HMDScriptingInterface sharedInstance;
+}
-    return sharedInstance;
+
+QScriptValue HMDScriptingInterface::getHUDLookAtPosition2D(QScriptContext* context, QScriptEngine* engine) {
+    glm::vec3 hudIntersection;
+    auto instance = DependencyManager::get<HMDScriptingInterface>();
+    if (instance->getHUDLookAtPosition3D(hudIntersection)) {
+        MyAvatar* myAvatar = DependencyManager::get<AvatarManager>()->getMyAvatar();
+        glm::vec3 sphereCenter = myAvatar->getDefaultEyePosition();
+        glm::vec3 direction = glm::inverse(myAvatar->getOrientation()) * (hudIntersection - sphereCenter);
+        glm::quat rotation = ::rotationBetween(glm::vec3(0.0f, 0.0f, -1.0f), direction);
+        glm::vec3 eulers = ::safeEulerAngles(rotation);
+        return qScriptValueFromValue<glm::vec2>(engine, Application::getInstance()->getApplicationCompositor()
+            .sphericalToOverlay(glm::vec2(eulers.y, -eulers.x)));
+    }
+    return QScriptValue::NullValue;
+}
+
+QScriptValue HMDScriptingInterface::getHUDLookAtPosition3D(QScriptContext* context, QScriptEngine* engine) {
+    glm::vec3 result;
+    auto instance = DependencyManager::get<HMDScriptingInterface>();
+    if (instance->getHUDLookAtPosition3D(result)) {
+        return qScriptValueFromValue<glm::vec3>(engine, result);
+    }
+    return QScriptValue::NullValue;
+}
+
+void HMDScriptingInterface::toggleMagnifier() {
+    qApp->getApplicationCompositor().toggleMagnifier();
+}
+
+bool HMDScriptingInterface::getMagnifier() const {
+    return Application::getInstance()->getApplicationCompositor().hasMagnifier();
 }
 
 bool HMDScriptingInterface::getHUDLookAtPosition3D(glm::vec3& result) const {
@@ -29,31 +63,3 @@ bool HMDScriptingInterface::getHUDLookAtPosition3D(glm::vec3& result) const {
 
     return compositor.calculateRayUICollisionPoint(position, direction, result);
 }
-
-QScriptValue HMDScriptingInterface::getHUDLookAtPosition2D(QScriptContext* context, QScriptEngine* engine) {
-
-    glm::vec3 hudIntersection;
-
-    if ((&HMDScriptingInterface::getInstance())->getHUDLookAtPosition3D(hudIntersection)) {
-        MyAvatar* myAvatar = DependencyManager::get<AvatarManager>()->getMyAvatar();
-        glm::vec3 sphereCenter = myAvatar->getDefaultEyePosition();
-        glm::vec3 direction = glm::inverse(myAvatar->getOrientation()) * (hudIntersection - sphereCenter);
-        glm::quat rotation = ::rotationBetween(glm::vec3(0.0f, 0.0f, -1.0f), direction);
-        glm::vec3 eulers = ::safeEulerAngles(rotation);
-        return qScriptValueFromValue<glm::vec2>(engine, Application::getInstance()->getApplicationCompositor()
-                                                .sphericalToOverlay(glm::vec2(eulers.y, -eulers.x)));
-    }
-    return QScriptValue::NullValue;
-}
-
-QScriptValue HMDScriptingInterface::getHUDLookAtPosition3D(QScriptContext* context, QScriptEngine* engine) {
-    glm::vec3 result;
-    if ((&HMDScriptingInterface::getInstance())->getHUDLookAtPosition3D(result)) {
-        return qScriptValueFromValue<glm::vec3>(engine, result);
-    }
-    return QScriptValue::NullValue;
-}
-
-float HMDScriptingInterface::getIPD() const {
-    return Application::getInstance()->getActiveDisplayPlugin()->getIPD();
-}

interface/src/scripting/HMDScriptingInterface.h

@@ -12,32 +12,29 @@
 #ifndef hifi_HMDScriptingInterface_h
 #define hifi_HMDScriptingInterface_h
 
+#include <QtScript/QScriptValue>
+class QScriptContext;
+class QScriptEngine;
+
 #include <GLMHelpers.h>
+#include <DependencyManager.h>
+#include <display-plugins/AbstractHMDScriptingInterface.h>
 
-#include "Application.h"
 
-class HMDScriptingInterface : public QObject {
+class HMDScriptingInterface : public AbstractHMDScriptingInterface, public Dependency {
     Q_OBJECT
     Q_PROPERTY(bool magnifier READ getMagnifier)
-    Q_PROPERTY(bool active READ isHMDMode)
-    Q_PROPERTY(float ipd READ getIPD)
 public:
-    static HMDScriptingInterface& getInstance();
+    HMDScriptingInterface();
-
     static QScriptValue getHUDLookAtPosition2D(QScriptContext* context, QScriptEngine* engine);
     static QScriptValue getHUDLookAtPosition3D(QScriptContext* context, QScriptEngine* engine);
 
 public slots:
-    void toggleMagnifier() { Application::getInstance()->getApplicationCompositor().toggleMagnifier(); };
+    void toggleMagnifier();
 
 private:
-    HMDScriptingInterface() {};
+    bool getMagnifier() const; 
-    bool getMagnifier() const { return Application::getInstance()->getApplicationCompositor().hasMagnifier(); };
-    bool isHMDMode() const { return Application::getInstance()->isHMDMode(); }
-    float getIPD() const;
-
     bool getHUDLookAtPosition3D(glm::vec3& result) const;
-
 };
 
 #endif // hifi_HMDScriptingInterface_h

libraries/animation/src/AnimClip.cpp

@@ -159,7 +159,7 @@ void AnimClip::copyFromNetworkAnim() {
 
                 // used to adjust translation offsets, so large translation animatons on the reference skeleton
                 // will be adjusted when played on a skeleton with short limbs.
-                float limbLengthScale = fabs(glm::length(fbxZeroTrans)) <= 0.0001f ? 1.0f : (glm::length(relBindPose.trans) / glm::length(fbxZeroTrans));
+                float limbLengthScale = fabsf(glm::length(fbxZeroTrans)) <= 0.0001f ? 1.0f : (glm::length(relBindPose.trans) / glm::length(fbxZeroTrans));
 
                 AnimPose& pose = _anim[frame][skeletonJoint];
                 const FBXAnimationFrame& fbxAnimFrame = geom.animationFrames[frame];

libraries/animation/src/AnimInverseKinematics.h

@@ -52,7 +52,7 @@ protected:
 
     void computeTargets(const AnimVariantMap& animVars, std::vector<IKTarget>& targets, const AnimPoseVec& underPoses);
     void solveWithCyclicCoordinateDescent(const std::vector<IKTarget>& targets);
-    virtual void setSkeletonInternal(AnimSkeleton::ConstPointer skeleton);
+    virtual void setSkeletonInternal(AnimSkeleton::ConstPointer skeleton) override;
 
     // for AnimDebugDraw rendering
     virtual const AnimPoseVec& getPosesInternal() const override { return _relativePoses; }

libraries/display-plugins/src/display-plugins/AbstractHMDScriptingInterface.cpp

@@ -0,0 +1,52 @@
+//
+//  Created by Bradley Austin Davis on 2015/10/04
+//  Copyright 2013-2015 High Fidelity, Inc.
+//
+//  Distributed under the Apache License, Version 2.0.
+//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
+//
+
+#include "AbstractHMDScriptingInterface.h"
+
+#include <SettingHandle.h>
+
+#include "DisplayPlugin.h"
+#include <plugins/PluginContainer.h>
+#include <OVR_CAPI_Keys.h>
+
+static Setting::Handle<float> IPD_SCALE_HANDLE("hmd.ipdScale", 1.0f);
+
+AbstractHMDScriptingInterface::AbstractHMDScriptingInterface() {
+    _IPDScale = IPD_SCALE_HANDLE.get();
+}
+
+float AbstractHMDScriptingInterface::getIPD() const {
+    return PluginContainer::getInstance().getActiveDisplayPlugin()->getIPD();
+}
+
+float AbstractHMDScriptingInterface::getEyeHeight() const {
+    // FIXME update the display plugin interface to expose per-plugin settings
+    return OVR_DEFAULT_EYE_HEIGHT;
+}
+
+float AbstractHMDScriptingInterface::getPlayerHeight() const {
+    // FIXME update the display plugin interface to expose per-plugin settings
+    return OVR_DEFAULT_PLAYER_HEIGHT;
+}
+
+float AbstractHMDScriptingInterface::getIPDScale() const {
+    return _IPDScale;
+}
+
+void AbstractHMDScriptingInterface::setIPDScale(float IPDScale) {
+    IPDScale = glm::clamp(IPDScale, -1.0f, 3.0f);
+    if (IPDScale != _IPDScale) {
+        _IPDScale = IPDScale;
+        IPD_SCALE_HANDLE.set(IPDScale);
+        emit IPDScaleChanged();
+    }
+}
+
+bool AbstractHMDScriptingInterface::isHMDMode() const {
+    return PluginContainer::getInstance().getActiveDisplayPlugin()->isHmd();
+}

libraries/display-plugins/src/display-plugins/AbstractHMDScriptingInterface.h

@@ -0,0 +1,39 @@
+//
+//  Created by Bradley Austin Davis on 2015/10/04
+//  Copyright 2013-2015 High Fidelity, Inc.
+//
+//  Distributed under the Apache License, Version 2.0.
+//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
+//
+
+#pragma once
+#ifndef hifi_AbstractHMDScriptingInterface_h
+#define hifi_AbstractHMDScriptingInterface_h
+
+#include <GLMHelpers.h>
+
+class AbstractHMDScriptingInterface : public QObject {
+    Q_OBJECT
+    Q_PROPERTY(bool active READ isHMDMode)
+    Q_PROPERTY(float ipd READ getIPD)
+    Q_PROPERTY(float eyeHeight READ getEyeHeight)
+    Q_PROPERTY(float playerHeight READ getPlayerHeight)
+    Q_PROPERTY(float ipdScale READ getIPDScale WRITE setIPDScale NOTIFY IPDScaleChanged)
+
+public:
+    AbstractHMDScriptingInterface();
+    float getIPD() const;
+    float getEyeHeight() const;
+    float getPlayerHeight() const;
+    float getIPDScale() const;
+    void setIPDScale(float ipdScale);
+    bool isHMDMode() const;
+
+signals:
+    void IPDScaleChanged();
+
+private:
+    float _IPDScale{ 1.0 };
+};
+
+#endif // hifi_AbstractHMDScriptingInterface_h

libraries/display-plugins/src/display-plugins/DisplayPlugin.h

@@ -46,6 +46,8 @@ void for_each_eye(F f, FF ff) {
 
 class QWindow;
 
+#define AVERAGE_HUMAN_IPD 0.064f
+
 class DisplayPlugin : public Plugin {
     Q_OBJECT
 public:
@@ -107,21 +109,22 @@ public:
         return baseProjection;
     }
 
-    virtual glm::mat4 getView(Eye eye, const glm::mat4& baseView) const {
-        return glm::inverse(getEyePose(eye)) * baseView;
-    }
-
     // HMD specific methods
     // TODO move these into another class?
-    virtual glm::mat4 getEyePose(Eye eye) const {
+    virtual glm::mat4 getEyeToHeadTransform(Eye eye) const {
-        static const glm::mat4 pose; return pose;
+        static const glm::mat4 transform; return transform;
     }
 
     virtual glm::mat4 getHeadPose() const {
         static const glm::mat4 pose; return pose;
     }
 
-    virtual float getIPD() const { return 0.0f; }
+    // Needed for timewarp style features
+    virtual void setEyeRenderPose(Eye eye, const glm::mat4& pose) {
+        // NOOP
+    }
+
+    virtual float getIPD() const { return AVERAGE_HUMAN_IPD; }
 
     virtual void abandonCalibration() {}
     virtual void resetSensors() {}

libraries/display-plugins/src/display-plugins/oculus/OculusBaseDisplayPlugin.cpp

@@ -19,7 +19,6 @@ void OculusBaseDisplayPlugin::preRender() {
 #if (OVR_MAJOR_VERSION >= 6)
     ovrFrameTiming ftiming = ovr_GetFrameTiming(_hmd, _frameIndex);
     _trackingState = ovr_GetTrackingState(_hmd, ftiming.DisplayMidpointSeconds);
-    ovr_CalcEyePoses(_trackingState.HeadPose.ThePose, _eyeOffsets, _eyePoses);
 #endif
 }
 
@@ -33,14 +32,19 @@ void OculusBaseDisplayPlugin::resetSensors() {
 #endif
 }
 
-glm::mat4 OculusBaseDisplayPlugin::getEyePose(Eye eye) const {
+glm::mat4 OculusBaseDisplayPlugin::getEyeToHeadTransform(Eye eye) const {
-    return toGlm(_eyePoses[eye]);
+    return glm::translate(mat4(), toGlm(_eyeOffsets[eye]));
 }
 
 glm::mat4 OculusBaseDisplayPlugin::getHeadPose() const {
     return toGlm(_trackingState.HeadPose.ThePose);
 }
 
+void OculusBaseDisplayPlugin::setEyeRenderPose(Eye eye, const glm::mat4& pose) {
+    _eyePoses[eye] = ovrPoseFromGlm(pose);
+}
+
+
 bool OculusBaseDisplayPlugin::isSupported() const {
 #if (OVR_MAJOR_VERSION >= 6)
     if (!OVR_SUCCESS(ovr_Initialize(nullptr))) {
@@ -151,9 +155,9 @@ void OculusBaseDisplayPlugin::display(GLuint finalTexture, const glm::uvec2& sce
 }
 
 float OculusBaseDisplayPlugin::getIPD() const {
-    float result = 0.0f;
+    float result = OVR_DEFAULT_IPD;
 #if (OVR_MAJOR_VERSION >= 6)
-    result = ovr_GetFloat(_hmd, OVR_KEY_IPD, OVR_DEFAULT_IPD);
+    result = ovr_GetFloat(_hmd, OVR_KEY_IPD, result);
 #endif
     return result;
-}
+}

libraries/display-plugins/src/display-plugins/oculus/OculusBaseDisplayPlugin.h

@@ -29,8 +29,9 @@ public:
     virtual glm::uvec2 getRecommendedRenderSize() const override final;
     virtual glm::uvec2 getRecommendedUiSize() const override final { return uvec2(1920, 1080); }
     virtual void resetSensors() override final;
-    virtual glm::mat4 getEyePose(Eye eye) const override final;
+    virtual glm::mat4 getEyeToHeadTransform(Eye eye) const override final;
     virtual glm::mat4 getHeadPose() const override final;
+    virtual void setEyeRenderPose(Eye eye, const glm::mat4& pose) override final; 
     virtual float getIPD() const override final;
 
 protected:
@@ -39,6 +40,7 @@ protected:
 
 protected:
     ovrPosef _eyePoses[2];
+    ovrVector3f _eyeOffsets[2];
     
     mat4 _eyeProjections[3];
     mat4 _compositeEyeProjections[2];
@@ -50,13 +52,12 @@ protected:
     ovrHmd _hmd;
     float _ipd{ OVR_DEFAULT_IPD };
     ovrEyeRenderDesc _eyeRenderDescs[2];
-    ovrVector3f _eyeOffsets[2];
     ovrFovPort _eyeFovs[2];
-    ovrHmdDesc       _hmdDesc;
+    ovrHmdDesc _hmdDesc;
-    ovrLayerEyeFov   _sceneLayer;
+    ovrLayerEyeFov _sceneLayer;
 #endif
 #if (OVR_MAJOR_VERSION == 7)
-    ovrGraphicsLuid  _luid;
+    ovrGraphicsLuid _luid;
 #endif
 };
 

libraries/display-plugins/src/display-plugins/oculus/OculusHelpers.h

@@ -79,3 +79,11 @@ inline ovrQuatf ovrFromGlm(const glm::quat & q) {
     return{ q.x, q.y, q.z, q.w };
 }
 
+inline ovrPosef ovrPoseFromGlm(const glm::mat4 & m) {
+    glm::vec3 translation = glm::vec3(m[3]) / m[3].w;
+    glm::quat orientation = glm::quat_cast(m);
+    ovrPosef result;
+    result.Orientation = ovrFromGlm(orientation);
+    result.Position = ovrFromGlm(translation);
+    return result; 
+}

libraries/display-plugins/src/display-plugins/oculus/OculusLegacyDisplayPlugin.cpp

@@ -59,11 +59,11 @@ void OculusLegacyDisplayPlugin::resetSensors() {
 #endif
 }
 
-glm::mat4 OculusLegacyDisplayPlugin::getEyePose(Eye eye) const {
+glm::mat4 OculusLegacyDisplayPlugin::getEyeToHeadTransform(Eye eye) const {
 #if (OVR_MAJOR_VERSION == 5)
     return toGlm(_eyePoses[eye]);
 #else
-    return WindowOpenGLDisplayPlugin::getEyePose(eye);
+    return WindowOpenGLDisplayPlugin::getEyeToHeadTransform(eye);
 #endif
 }
 

libraries/display-plugins/src/display-plugins/oculus/OculusLegacyDisplayPlugin.h

@@ -31,7 +31,7 @@ public:
     virtual glm::uvec2 getRecommendedRenderSize() const override;
     virtual glm::uvec2 getRecommendedUiSize() const override { return uvec2(1920, 1080); }
     virtual void resetSensors() override;
-    virtual glm::mat4 getEyePose(Eye eye) const override;
+    virtual glm::mat4 getEyeToHeadTransform(Eye eye) const override;
     virtual glm::mat4 getHeadPose() const override;
 
 protected:

libraries/display-plugins/src/display-plugins/openvr/OpenVrDisplayPlugin.cpp

@@ -160,8 +160,8 @@ void OpenVrDisplayPlugin::resetSensors() {
     _sensorResetMat = glm::inverse(cancelOutRollAndPitch(_trackedDevicePoseMat4[0]));
 }
 
-glm::mat4 OpenVrDisplayPlugin::getEyePose(Eye eye) const {
+glm::mat4 OpenVrDisplayPlugin::getEyeToHeadTransform(Eye eye) const {
-    return getHeadPose() * _eyesData[eye]._eyeOffset;
+    return _eyesData[eye]._eyeOffset;
 }
 
 glm::mat4 OpenVrDisplayPlugin::getHeadPose() const {

libraries/display-plugins/src/display-plugins/openvr/OpenVrDisplayPlugin.h

@@ -29,7 +29,7 @@ public:
     virtual glm::mat4 getProjection(Eye eye, const glm::mat4& baseProjection) const override;
     virtual void resetSensors() override;
 
-    virtual glm::mat4 getEyePose(Eye eye) const override;
+    virtual glm::mat4 getEyeToHeadTransform(Eye eye) const override;
     virtual glm::mat4 getHeadPose() const override;
 
 protected:

libraries/display-plugins/src/display-plugins/stereo/StereoDisplayPlugin.cpp

@@ -61,10 +61,6 @@ glm::mat4 StereoDisplayPlugin::getProjection(Eye eye, const glm::mat4& baseProje
     return eyeProjection;
 }
 
-glm::mat4 StereoDisplayPlugin::getEyePose(Eye eye) const {
-    return mat4();
-}
-
 std::vector<QAction*> _screenActions;
 void StereoDisplayPlugin::activate() {
     auto screens = qApp->screens();

libraries/display-plugins/src/display-plugins/stereo/StereoDisplayPlugin.h

@@ -21,7 +21,14 @@ public:
 
     virtual float getRecommendedAspectRatio() const override;
     virtual glm::mat4 getProjection(Eye eye, const glm::mat4& baseProjection) const override;
-    virtual glm::mat4 getEyePose(Eye eye) const override;
+    
+    // NOTE, because Stereo displays don't include head tracking, and therefore 
+    // can't include roll or pitch, the eye separation is embedded into the projection
+    // matrix.  However, this eliminates the possibility of easily mainpulating
+    // the IPD at the Application level, the way we now allow with HMDs.
+    // If that becomes an issue then we'll need to break up the functionality similar
+    // to the HMD plugins.  
+    // virtual glm::mat4 getEyeToHeadTransform(Eye eye) const override;
 
 protected:
     void updateScreen();

libraries/entities-renderer/src/RenderableBoxEntityItem.cpp

@@ -56,7 +56,7 @@ void RenderableBoxEntityItem::render(RenderArgs* args) {
 
     if (_procedural->ready()) {
         batch.setModelTransform(getTransformToCenter()); // we want to include the scale as well
-        _procedural->prepare(batch, this->getDimensions());
+        _procedural->prepare(batch, getPosition(), getDimensions());
         auto color = _procedural->getColor(cubeColor);
         batch._glColor4f(color.r, color.g, color.b, color.a);
         DependencyManager::get<GeometryCache>()->renderCube(batch);

libraries/entities-renderer/src/RenderableParticleEffectEntityItem.h

@@ -25,8 +25,8 @@ public:
 
     void updateRenderItem();
 
-    virtual bool addToScene(EntityItemPointer self, render::ScenePointer scene, render::PendingChanges& pendingChanges);
+    virtual bool addToScene(EntityItemPointer self, render::ScenePointer scene, render::PendingChanges& pendingChanges) override;
-    virtual void removeFromScene(EntityItemPointer self, render::ScenePointer scene, render::PendingChanges& pendingChanges);
+    virtual void removeFromScene(EntityItemPointer self, render::ScenePointer scene, render::PendingChanges& pendingChanges) override;
 
 protected:
     render::ItemID _renderItemId;

libraries/entities-renderer/src/RenderableSphereEntityItem.cpp

@@ -62,7 +62,7 @@ void RenderableSphereEntityItem::render(RenderArgs* args) {
     modelTransform.postScale(SPHERE_ENTITY_SCALE);
     if (_procedural->ready()) {
         batch.setModelTransform(modelTransform); // use a transform with scale, rotation, registration point and translation
-        _procedural->prepare(batch, getDimensions());
+        _procedural->prepare(batch, getPosition(), getDimensions());
         auto color = _procedural->getColor(sphereColor);
         batch._glColor4f(color.r, color.g, color.b, color.a);
         DependencyManager::get<GeometryCache>()->renderSphere(batch);

libraries/gpu/src/gpu/Batch.h

@@ -156,24 +156,24 @@ public:
     // Indirect buffer is used by the multiDrawXXXIndirect calls
     // The indirect buffer contains the command descriptions to execute multiple drawcalls in a single call
     void setIndirectBuffer(const BufferPointer& buffer, Offset offset = 0, Offset stride = 0);
-    
+    
-    // multi command desctription for multiDrawIndexedIndirect
+    // multi command desctription for multiDrawIndexedIndirect
-    class DrawIndirectCommand {
+    class DrawIndirectCommand {
-    public:
+    public:
-        uint  _count{ 0 };
+        uint  _count{ 0 };
-        uint  _instanceCount{ 0 };
+        uint  _instanceCount{ 0 };
-        uint  _firstIndex{ 0 };
+        uint  _firstIndex{ 0 };
-        uint  _baseInstance{ 0 };
+        uint  _baseInstance{ 0 };
     };
-
+
-    // multi command desctription for multiDrawIndexedIndirect
+    // multi command desctription for multiDrawIndexedIndirect
-    class DrawIndexedIndirectCommand {
+    class DrawIndexedIndirectCommand {
-    public:
+    public:
-        uint  _count{ 0 };
+        uint  _count{ 0 };
-        uint  _instanceCount{ 0 };
+        uint  _instanceCount{ 0 };
-        uint  _firstIndex{ 0 };
+        uint  _firstIndex{ 0 };
-        uint  _baseVertex{ 0 };
+        uint  _baseVertex{ 0 };
-        uint  _baseInstance{ 0 };
+        uint  _baseInstance{ 0 };
     };
 
     // Transform Stage
@@ -246,6 +246,26 @@ public:
     void _glUniform4iv(int location, int count, const int* value);
     void _glUniformMatrix4fv(int location, int count, unsigned char transpose, const float* value);
 
+    void _glUniform(int location, int v0) {
+        _glUniform1i(location, v0);
+    }
+
+    void _glUniform(int location, float v0) {
+        _glUniform1f(location, v0);
+    }
+
+    void _glUniform(int location, const glm::vec2& v) {
+        _glUniform2f(location, v.x, v.y);
+    }
+
+    void _glUniform(int location, const glm::vec3& v) {
+        _glUniform3f(location, v.x, v.y, v.z);
+    }
+
+    void _glUniform(int location, const glm::vec4& v) {
+        _glUniform4f(location, v.x, v.y, v.z, v.w);
+    }
+
     void _glColor4f(float red, float green, float blue, float alpha);
 
     enum Command {

libraries/gpu/src/gpu/Texture.cpp

@@ -343,9 +343,22 @@ bool Texture::assignStoredMipFace(uint16 level, const Element& format, Size size
 }
 
 uint16 Texture::autoGenerateMips(uint16 maxMip) {
-    _autoGenerateMips = true;
+    bool changed = false;
-    _maxMip = std::min((uint16) (evalNumMips() - 1), maxMip);
+    if (!_autoGenerateMips) {
-    _stamp++;
+        changed = true;
+        _autoGenerateMips = true;
+    }
+
+    auto newMaxMip = std::min((uint16)(evalNumMips() - 1), maxMip);
+    if (newMaxMip != _maxMip) {
+        changed = true;
+        _maxMip = newMaxMip;;
+    }
+
+    if (changed) {
+        _stamp++;
+    }
+
     return _maxMip;
 }
 

libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.h

@@ -59,7 +59,7 @@ public:
     // Plugin functions
     virtual bool isSupported() const override { return true; }
     virtual bool isJointController() const override { return false; }
-    const QString& getName() const { return NAME; }
+    const QString& getName() const override { return NAME; }
 
     virtual void activate() override {};
     virtual void deactivate() override {};

libraries/input-plugins/src/input-plugins/SDL2Manager.h

@@ -30,7 +30,7 @@ public:
     // Plugin functions
     virtual bool isSupported() const override;
     virtual bool isJointController() const override { return false; }
-    const QString& getName() const { return NAME; }
+    const QString& getName() const override { return NAME; }
 
     virtual void init() override;
     virtual void deinit() override;

libraries/input-plugins/src/input-plugins/SixenseManager.cpp

@@ -285,6 +285,7 @@ void SixenseManager::updateCalibration(void* controllersX) {
                 _avatarRotation = glm::inverse(glm::quat_cast(glm::mat3(xAxis, Vectors::UNIT_Y, zAxis)));
                 const float Y_OFFSET_CALIBRATED_HANDS_TO_AVATAR = -0.3f;
                 _avatarPosition.y += Y_OFFSET_CALIBRATED_HANDS_TO_AVATAR;
+                CONTAINER->requestReset();
                 qCDebug(inputplugins, "succeess: sixense calibration");
             }
             break;

libraries/input-plugins/src/input-plugins/SixenseManager.h

@@ -63,7 +63,7 @@ public:
     // Plugin functions
     virtual bool isSupported() const override;
     virtual bool isJointController() const override { return true; }
-    const QString& getName() const { return NAME; }
+    const QString& getName() const override { return NAME; }
 
     virtual void activate() override;
     virtual void deactivate() override;

libraries/input-plugins/src/input-plugins/ViveControllerManager.h

@@ -53,7 +53,7 @@ public:
     // Plugin functions
     virtual bool isSupported() const override;
     virtual bool isJointController() const override { return true; }
-    const QString& getName() const { return NAME; }
+    const QString& getName() const override { return NAME; }
 
     virtual void activate() override;
     virtual void deactivate() override;

libraries/model-networking/CMakeLists.txt

@@ -7,5 +7,5 @@ add_dependency_external_projects(glm)
 find_package(GLM REQUIRED)
 target_include_directories(${TARGET_NAME} PUBLIC ${GLM_INCLUDE_DIRS})
 
-link_hifi_libraries(shared networking gpu model)
+link_hifi_libraries(shared networking gpu model fbx)
 

libraries/octree/src/OctreeHeadlessViewer.h

@@ -30,9 +30,9 @@ class OctreeHeadlessViewer : public OctreeRenderer {
 public:
     OctreeHeadlessViewer();
     virtual ~OctreeHeadlessViewer() {};
-    virtual void renderElement(OctreeElementPointer element, RenderArgs* args) { /* swallow these */ }
+    virtual void renderElement(OctreeElementPointer element, RenderArgs* args) override { /* swallow these */ }
 
-    virtual void init();
+    virtual void init() override ;
     virtual void render(RenderArgs* renderArgs) override { /* swallow these */ }
 
     void setJurisdictionListener(JurisdictionListener* jurisdictionListener) { _jurisdictionListener = jurisdictionListener; }
@@ -58,7 +58,7 @@ public slots:
 
     // getters for LOD and PPS
     float getVoxelSizeScale() const { return _voxelSizeScale; }
-    int getBoundaryLevelAdjust() const { return _boundaryLevelAdjust; }
+    int getBoundaryLevelAdjust() const override { return _boundaryLevelAdjust; }
     int getMaxPacketsPerSecond() const { return _maxPacketsPerSecond; }
 
     unsigned getOctreeElementsCount() const { return _tree->getOctreeElementsCount(); }

libraries/plugins/src/plugins/PluginContainer.cpp

@@ -9,7 +9,17 @@
 
 static PluginContainer* INSTANCE{ nullptr };
 
+PluginContainer& PluginContainer::getInstance() {
+    Q_ASSERT(INSTANCE);
+    return *INSTANCE;
+}
+
 PluginContainer::PluginContainer() {
     Q_ASSERT(!INSTANCE);
     INSTANCE = this;
 };
+
+PluginContainer::~PluginContainer() {
+    Q_ASSERT(INSTANCE == this);
+    INSTANCE = nullptr;
+};

libraries/plugins/src/plugins/PluginContainer.h

@@ -13,10 +13,13 @@
 class QAction;
 class QGLWidget;
 class QScreen;
+class DisplayPlugin;
 
 class PluginContainer {
 public:
+    static PluginContainer& getInstance();
     PluginContainer();
+    virtual ~PluginContainer();
     virtual void addMenu(const QString& menuName) = 0;
     virtual void removeMenu(const QString& menuName) = 0;
     virtual QAction* addMenuItem(const QString& path, const QString& name, std::function<void(bool)> onClicked, bool checkable = false, bool checked = false, const QString& groupName = "") = 0;
@@ -26,6 +29,8 @@ public:
     virtual void setFullscreen(const QScreen* targetScreen, bool hideMenu = false) = 0;
     virtual void unsetFullscreen(const QScreen* avoidScreen = nullptr) = 0;
     virtual void showDisplayPluginsTools() = 0;
+    virtual void requestReset() = 0;
     virtual QGLWidget* getPrimarySurface() = 0;
     virtual bool isForeground() = 0;
+    virtual const DisplayPlugin* getActiveDisplayPlugin() const = 0;
 };

libraries/procedural/src/procedural/Procedural.cpp

@@ -17,20 +17,30 @@
 #include <gpu/Batch.h>
 #include <SharedUtil.h>
 #include <NumericalConstants.h>
+#include <GLMHelpers.h>
 
 #include "ProceduralShaders.h"
 
-static const char* const UNIFORM_TIME_NAME= "iGlobalTime";
+// Userdata parsing constants
-static const char* const UNIFORM_SCALE_NAME = "iWorldScale";
 static const QString PROCEDURAL_USER_DATA_KEY = "ProceduralEntity";
-
 static const QString URL_KEY = "shaderUrl";
 static const QString VERSION_KEY = "version";
 static const QString UNIFORMS_KEY = "uniforms";
+static const QString CHANNELS_KEY = "channels";
+
+// Shader replace strings
 static const std::string PROCEDURAL_BLOCK = "//PROCEDURAL_BLOCK";
 static const std::string PROCEDURAL_COMMON_BLOCK = "//PROCEDURAL_COMMON_BLOCK";
 static const std::string PROCEDURAL_VERSION = "//PROCEDURAL_VERSION";
 
+static const std::string STANDARD_UNIFORM_NAMES[Procedural::NUM_STANDARD_UNIFORMS] = {
+    "iDate",
+    "iGlobalTime",
+    "iFrameCount",
+    "iWorldScale",
+    "iWorldPosition",
+    "iChannelResolution"
+};
 
 // Example
 //{
@@ -100,7 +110,21 @@ void Procedural::parse(const QJsonObject& proceduralData) {
     {
         auto uniforms = proceduralData[UNIFORMS_KEY];
         if (uniforms.isObject()) {
-            _uniforms = uniforms.toObject();;
+            _parsedUniforms = uniforms.toObject();
+        }
+    }
+
+    // Grab any textures
+    {
+        auto channels = proceduralData[CHANNELS_KEY];
+        if (channels.isArray()) {
+            auto textureCache = DependencyManager::get<TextureCache>();
+            _parsedChannels = channels.toArray();
+            size_t channelCount = std::min(MAX_PROCEDURAL_TEXTURE_CHANNELS, (size_t)_parsedChannels.size());
+            for (size_t i = 0; i < channelCount; ++i) {
+                QString url = _parsedChannels.at(i).toString();
+                _channels[i] = textureCache->getTexture(QUrl(url));
+            }
         }
     }
     _enabled = true;
@@ -111,20 +135,26 @@ bool Procedural::ready() {
         return false;
     }
 
-    if (!_shaderPath.isEmpty()) {
+    // Do we have a network or local shader
-        return true;
+    if (_shaderPath.isEmpty() && (!_networkShader || !_networkShader->isLoaded())) {
+        return false;
     }
 
-    if (_networkShader) {
+    // Do we have textures, and if so, are they loaded?
-        return _networkShader->isLoaded();
+    for (size_t i = 0; i < MAX_PROCEDURAL_TEXTURE_CHANNELS; ++i) {
+        if (_channels[i] && !_channels[i]->isLoaded()) {
+            return false;
+        }
     }
 
-    return false;
+    return true;
 }
 
-void Procedural::prepare(gpu::Batch& batch, const glm::vec3& size) {
+void Procedural::prepare(gpu::Batch& batch, const glm::vec3& position, const glm::vec3& size) {
+    _entityDimensions = size;
+    _entityPosition = position;
     if (_shaderUrl.isLocalFile()) {
-        auto lastModified = (quint64) QFileInfo(_shaderPath).lastModified().toMSecsSinceEpoch();
+        auto lastModified = (quint64)QFileInfo(_shaderPath).lastModified().toMSecsSinceEpoch();
         if (lastModified > _shaderModified) {
             QFile file(_shaderPath);
             file.open(QIODevice::ReadOnly);
@@ -164,69 +194,183 @@ void Procedural::prepare(gpu::Batch& batch, const glm::vec3& size) {
         //qDebug() << "FragmentShader:\n" << fragmentShaderSource.c_str();
         _fragmentShader = gpu::ShaderPointer(gpu::Shader::createPixel(fragmentShaderSource));
         _shader = gpu::ShaderPointer(gpu::Shader::createProgram(_vertexShader, _fragmentShader));
-        gpu::Shader::makeProgram(*_shader);
+
+        gpu::Shader::BindingSet slotBindings;
+        slotBindings.insert(gpu::Shader::Binding(std::string("iChannel0"), 0));
+        slotBindings.insert(gpu::Shader::Binding(std::string("iChannel1"), 1));
+        slotBindings.insert(gpu::Shader::Binding(std::string("iChannel2"), 2));
+        slotBindings.insert(gpu::Shader::Binding(std::string("iChannel3"), 3));
+        gpu::Shader::makeProgram(*_shader, slotBindings);
+
         _pipeline = gpu::PipelinePointer(gpu::Pipeline::create(_shader, _state));
-        _timeSlot = _shader->getUniforms().findLocation(UNIFORM_TIME_NAME);
+        for (size_t i = 0; i < NUM_STANDARD_UNIFORMS; ++i) {
-        _scaleSlot = _shader->getUniforms().findLocation(UNIFORM_SCALE_NAME);
+            const std::string& name = STANDARD_UNIFORM_NAMES[i];
+            _standardUniformSlots[i] = _shader->getUniforms().findLocation(name);
+        }
         _start = usecTimestampNow();
+        _frameCount = 0;
     }
 
     batch.setPipeline(_pipeline);
 
     if (_pipelineDirty) {
         _pipelineDirty = false;
-        // Set any userdata specified uniforms 
+        setupUniforms();
-        foreach(QString key, _uniforms.keys()) {
+    }
-            std::string uniformName = key.toLocal8Bit().data();
+
-            int32_t slot = _shader->getUniforms().findLocation(uniformName);
+
-            if (gpu::Shader::INVALID_LOCATION == slot) {
+    for (auto lambda : _uniforms) {
-                continue;
+        lambda(batch);
+    }
+
+    static gpu::Sampler sampler;
+    static std::once_flag once;
+    std::call_once(once, [&] {
+        gpu::Sampler::Desc desc;
+        desc._filter = gpu::Sampler::FILTER_MIN_MAG_MIP_LINEAR;
+    });
+    
+    for (size_t i = 0; i < MAX_PROCEDURAL_TEXTURE_CHANNELS; ++i) {
+        if (_channels[i] && _channels[i]->isLoaded()) {
+            auto gpuTexture = _channels[i]->getGPUTexture();
+            if (gpuTexture) {
+                gpuTexture->setSampler(sampler);
+                gpuTexture->autoGenerateMips(-1);
             }
-            QJsonValue value = _uniforms[key];
+            batch.setResourceTexture(i, gpuTexture);
-            if (value.isDouble()) {
+        }
-                batch._glUniform1f(slot, value.toDouble());
+    }
-            } else if (value.isArray()) {
+}
-                auto valueArray = value.toArray();
-                switch (valueArray.size()) {
-                    case 0:
-                        break;
 
-                    case 1:
+void Procedural::setupUniforms() {
-                        batch._glUniform1f(slot, valueArray[0].toDouble());
+    _uniforms.clear();
-                        break;
+    // Set any userdata specified uniforms 
-                    case 2:
+    foreach(QString key, _parsedUniforms.keys()) {
-                        batch._glUniform2f(slot, 
+        std::string uniformName = key.toLocal8Bit().data();
-                            valueArray[0].toDouble(),
+        int32_t slot = _shader->getUniforms().findLocation(uniformName);
-                            valueArray[1].toDouble());
+        if (gpu::Shader::INVALID_LOCATION == slot) {
-                        break;
+            continue;
-                    case 3:
+        }
-                        batch._glUniform3f(slot, 
+        QJsonValue value = _parsedUniforms[key];
-                            valueArray[0].toDouble(),
+        if (value.isDouble()) {
-                            valueArray[1].toDouble(),
+            float v = value.toDouble();
-                            valueArray[2].toDouble());
+            _uniforms.push_back([=](gpu::Batch& batch) {
-                            break;
+                batch._glUniform1f(slot, v);
-                    case 4:
+            });
-                    default:
+        } else if (value.isArray()) {
-                        batch._glUniform4f(slot,
+            auto valueArray = value.toArray();
-                            valueArray[0].toDouble(),
+            switch (valueArray.size()) {
-                            valueArray[1].toDouble(),
+                case 0:
-                            valueArray[2].toDouble(),
+                    break;
-                            valueArray[3].toDouble());
-                        break;
 
+                case 1: {
+                    float v = valueArray[0].toDouble();
+                    _uniforms.push_back([=](gpu::Batch& batch) {
+                        batch._glUniform1f(slot, v);
+                    });
+                    break;
+                }
+
+                case 2: {
+                    glm::vec2 v{ valueArray[0].toDouble(), valueArray[1].toDouble() };
+                    _uniforms.push_back([=](gpu::Batch& batch) {
+                        batch._glUniform2f(slot, v.x, v.y);
+                    });
+                    break;
+                }
+
+                case 3: {
+                    glm::vec3 v{
+                        valueArray[0].toDouble(),
+                        valueArray[1].toDouble(),
+                        valueArray[2].toDouble(),
+                    };
+                    _uniforms.push_back([=](gpu::Batch& batch) {
+                        batch._glUniform3f(slot, v.x, v.y, v.z);
+                    });
+                    break;
+                }
+
+                default:
+                case 4: {
+                    glm::vec4 v{
+                        valueArray[0].toDouble(),
+                        valueArray[1].toDouble(),
+                        valueArray[2].toDouble(),
+                        valueArray[3].toDouble(),
+                    };
+                    _uniforms.push_back([=](gpu::Batch& batch) {
+                        batch._glUniform4f(slot, v.x, v.y, v.z, v.w);
+                    });
+                    break;
                 }
-                valueArray.size();
             }
         }
     }
 
-    // Minimize floating point error by doing an integer division to milliseconds, before the floating point division to seconds
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[TIME]) {
-    float time = (float)((usecTimestampNow() - _start) / USECS_PER_MSEC) / MSECS_PER_SECOND;
+        _uniforms.push_back([=](gpu::Batch& batch) {
-    batch._glUniform1f(_timeSlot, time);
+            // Minimize floating point error by doing an integer division to milliseconds, before the floating point division to seconds
-    // FIXME move into the 'set once' section, since this doesn't change over time
+            float time = (float)((usecTimestampNow() - _start) / USECS_PER_MSEC) / MSECS_PER_SECOND;
-    batch._glUniform3f(_scaleSlot, size.x, size.y, size.z);
+            batch._glUniform(_standardUniformSlots[TIME], time);
-}
+        });
+    }
 
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[DATE]) {
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            QDateTime now = QDateTime::currentDateTimeUtc();
+            QDate date = now.date();
+            QTime time = now.time();
+            vec4 v;
+            v.x = date.year();
+            // Shadertoy month is 0 based
+            v.y = date.month() - 1;
+            // But not the day... go figure
+            v.z = date.day();
+            v.w = (time.hour() * 3600) + (time.minute() * 60) + time.second();
+            batch._glUniform(_standardUniformSlots[DATE], v);
+        });
+    }
+
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[FRAME_COUNT]) {
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            batch._glUniform(_standardUniformSlots[FRAME_COUNT], ++_frameCount);
+        });
+    }
+
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[SCALE]) {
+        // FIXME move into the 'set once' section, since this doesn't change over time
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            batch._glUniform(_standardUniformSlots[SCALE], _entityDimensions);
+        });
+    }
+
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[SCALE]) {
+        // FIXME move into the 'set once' section, since this doesn't change over time
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            batch._glUniform(_standardUniformSlots[SCALE], _entityDimensions);
+        });
+    }
+
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[POSITION]) {
+        // FIXME move into the 'set once' section, since this doesn't change over time
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            batch._glUniform(_standardUniformSlots[POSITION], _entityPosition);
+        });
+    }
+
+    if (gpu::Shader::INVALID_LOCATION != _standardUniformSlots[CHANNEL_RESOLUTION]) {
+        _uniforms.push_back([=](gpu::Batch& batch) {
+            vec3 channelSizes[MAX_PROCEDURAL_TEXTURE_CHANNELS];
+            for (size_t i = 0; i < MAX_PROCEDURAL_TEXTURE_CHANNELS; ++i) {
+                if (_channels[i]) {
+                    channelSizes[i] = vec3(_channels[i]->getWidth(), _channels[i]->getHeight(), 1.0);
+                }
+            }
+            batch._glUniform3fv(_standardUniformSlots[CHANNEL_RESOLUTION], MAX_PROCEDURAL_TEXTURE_CHANNELS, &channelSizes[0].x);
+        });
+    }
+}
 
 glm::vec4 Procedural::getColor(const glm::vec4& entityColor) {
     if (_version == 1) {

libraries/procedural/src/procedural/Procedural.h

@@ -14,11 +14,16 @@
 #include <QtCore/QString>
 #include <QtCore/QUrl>
 #include <QtCore/QJsonObject>
+#include <QtCore/QJsonArray>
 
 #include <gpu/Shader.h>
 #include <gpu/Pipeline.h>
 #include <gpu/Batch.h>
 #include <model-networking/ShaderCache.h>
+#include <model-networking/TextureCache.h>
+
+using UniformLambdas = std::list<std::function<void(gpu::Batch& batch)>>;
+const size_t MAX_PROCEDURAL_TEXTURE_CHANNELS{ 4 };
 
 // FIXME better encapsulation
 // FIXME better mechanism for extending to things rendered using shaders other than simple.slv
@@ -29,7 +34,8 @@ struct Procedural {
     void parse(const QString& userDataJson);
     void parse(const QJsonObject&);
     bool ready();
-    void prepare(gpu::Batch& batch, const glm::vec3& size);
+    void prepare(gpu::Batch& batch, const glm::vec3& position, const glm::vec3& size);
+    void setupUniforms();
     glm::vec4 getColor(const glm::vec4& entityColor);
 
     bool _enabled{ false };
@@ -43,17 +49,34 @@ struct Procedural {
     QUrl _shaderUrl;
     quint64 _shaderModified{ 0 };
     bool _pipelineDirty{ true };
-    int32_t _timeSlot{ gpu::Shader::INVALID_LOCATION };
-    int32_t _scaleSlot{ gpu::Shader::INVALID_LOCATION };
-    uint64_t _start{ 0 };
-    NetworkShaderPointer _networkShader;
-    QJsonObject _uniforms;
 
+    enum StandardUniforms {
+        DATE,
+        TIME,
+        FRAME_COUNT,
+        SCALE,
+        POSITION,
+        CHANNEL_RESOLUTION,
+        NUM_STANDARD_UNIFORMS
+    };
+
+    int32_t _standardUniformSlots[NUM_STANDARD_UNIFORMS];
+
+    uint64_t _start{ 0 };
+    int32_t _frameCount{ 0 };
+    NetworkShaderPointer _networkShader;
+    QJsonObject _parsedUniforms;
+    QJsonArray _parsedChannels;
+
+    UniformLambdas _uniforms;
+    NetworkTexturePointer _channels[MAX_PROCEDURAL_TEXTURE_CHANNELS];
     gpu::PipelinePointer _pipeline;
     gpu::ShaderPointer _vertexShader;
     gpu::ShaderPointer _fragmentShader;
     gpu::ShaderPointer _shader;
     gpu::StatePointer _state;
+    glm::vec3 _entityDimensions;
+    glm::vec3 _entityPosition;
 };
 
 #endif

libraries/procedural/src/procedural/ProceduralShaders.h

@@ -262,15 +262,39 @@ float snoise(vec2 v) {
     return 130.0 * dot(m, g);
 }
 
-// TODO add more uniforms
+// shader playback time (in seconds)
-uniform float iGlobalTime;           // shader playback time (in seconds)
+uniform float iGlobalTime;
-uniform vec3 iWorldScale;            // the dimensions of the object being rendered
+// the dimensions of the object being rendered
-
+uniform vec3 iWorldScale;            
-// TODO add support for textures
-// TODO document available inputs other than the uniforms
-// TODO provide world scale in addition to the untransformed position
 
 #define PROCEDURAL 1
 
 //PROCEDURAL_VERSION
+
+#ifdef PROCEDURAL_V1
+
+#else
+
+// Unimplemented uniforms
+// Resolution doesn't make sense in the VR context
+const vec3 iResolution = vec3(1.0);
+// Mouse functions not enabled currently
+const vec4 iMouse = vec4(0.0);
+// No support for audio input
+const float iSampleRate = 1.0;
+// No support for video input
+const vec4 iChannelTime = vec4(0.0);
+
+
+uniform vec4 iDate;
+uniform int iFrameCount;
+uniform vec3 iWorldPosition;
+uniform vec3 iChannelResolution[4];
+uniform sampler2D iChannel0;
+uniform sampler2D iChannel1;
+uniform sampler2D iChannel2;
+uniform sampler2D iChannel3;
+
+#endif
+
 )SHADER";

libraries/procedural/src/procedural/ProceduralSkybox.cpp

@@ -1,20 +1,20 @@
-//
+//
-//  ProceduralSkybox.cpp
+//  ProceduralSkybox.cpp
-//  libraries/procedural/src/procedural
+//  libraries/procedural/src/procedural
-//
+//
-//  Created by Sam Gateau on 9/21/2015.
+//  Created by Sam Gateau on 9/21/2015.
-//  Copyright 2015 High Fidelity, Inc.
+//  Copyright 2015 High Fidelity, Inc.
-//
+//
-//  Distributed under the Apache License, Version 2.0.
+//  Distributed under the Apache License, Version 2.0.
-//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
+//  See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
-//
+//
-#include "ProceduralSkybox.h"
+#include "ProceduralSkybox.h"
-
+
-
+
-#include <gpu/Batch.h>
+#include <gpu/Batch.h>
-#include <gpu/Context.h>
+#include <gpu/Context.h>
-#include <ViewFrustum.h>
+#include <ViewFrustum.h>
-
+
 #include "ProceduralSkybox_vert.h"
 #include "ProceduralSkybox_frag.h"
 
@@ -74,7 +74,7 @@ void ProceduralSkybox::render(gpu::Batch& batch, const ViewFrustum& viewFrustum,
             batch.setResourceTexture(0, skybox.getCubemap());
         }
 
-        skybox._procedural->prepare(batch, glm::vec3(1));
+        skybox._procedural->prepare(batch, glm::vec3(0), glm::vec3(1));
         batch.draw(gpu::TRIANGLE_STRIP, 4);
     }
 }

libraries/shared/src/LogHandler.cpp

@@ -120,11 +120,11 @@ QString LogHandler::printMessage(LogMsgType type, const QMessageLogContext& cont
     }
     
     // log prefix is in the following format
-    // [DEBUG] [TIMESTAMP] [PID] [TARGET] logged string
+    // [TIMESTAMP] [DEBUG] [PID] [TARGET] logged string
     
-    QString prefixString = QString("[%1]").arg(stringForLogType(type));
+    QString prefixString = QString("[%1]").arg(QDateTime::currentDateTime().toString(DATE_STRING_FORMAT));
     
-    prefixString.append(QString(" [%1]").arg(QDateTime::currentDateTime().toString(DATE_STRING_FORMAT)));
+    prefixString.append(QString(" [%1]").arg(stringForLogType(type)));
     
     if (_shouldOutputPID) {
         prefixString.append(QString(" [%1]").arg(QCoreApplication::instance()->applicationPid()));

tests/ui/src/main.cpp

@@ -260,7 +260,7 @@ protected:
     }
 
   
-    void keyPressEvent(QKeyEvent* event) {
+    void keyPressEvent(QKeyEvent* event) override {
         _altPressed = Qt::Key_Alt == event->key();
         switch (event->key()) {
             case Qt::Key_B:
@@ -292,13 +292,13 @@ protected:
         QWindow::keyPressEvent(event);
     }
     QQmlContext* menuContext{ nullptr };
-    void keyReleaseEvent(QKeyEvent *event) {
+    void keyReleaseEvent(QKeyEvent *event) override {
         if (_altPressed && Qt::Key_Alt == event->key()) {
             VrMenu::toggle();
         }
     }
 
-    void moveEvent(QMoveEvent* event) {
+    void moveEvent(QMoveEvent* event) override {
         static qreal oldPixelRatio = 0.0;
         if (devicePixelRatio() != oldPixelRatio) {
             oldPixelRatio = devicePixelRatio();

unpublishedScripts/masterReset.js

@@ -71,13 +71,13 @@ function createAllToys() {
 
     createCombinedArmChair({
         x: 549.29,
-        y: 495.05,
+        y: 494.9,
         z: 508.22
     });
 
     createPottedPlant({
         x: 554.26,
-        y: 495.23,
+        y: 495.2,
         z: 504.53
     });
 
@@ -98,7 +98,7 @@ function createAllToys() {
 function deleteAllToys() {
     var entities = Entities.findEntities(MyAvatar.position, 100);
 
-    entities.forEach(function (entity) {
+    entities.forEach(function(entity) {
         //params: customKey, id, defaultValue
         var shouldReset = getEntityCustomData(resetKey, entity, {}).resetMe;
         if (shouldReset === true) {
@@ -831,4 +831,4 @@ function cleanup() {
 if (shouldDeleteOnEndScript) {
 
     Script.scriptEnding.connect(cleanup);
-}
+}