Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-07-22 18:34:56 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix crash for indices out of bounds in GLTF.

Browse source 
Co-Authored-By: hifiexperiments <hifiexperiments@users.noreply.github.com>
This commit is contained in:
Kasen IO 2020-07-02 23:52:26 -04:00
parent fe7f89cc1b
commit fe0109aa13
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libraries/fbx/src/GLTFSerializer.cpp
View file

@ -1055,6 +1055,11 @@ bool GLTFSerializer::buildGeometry(HFMModel& hfmModel, const hifi::VariantHash&
int indicesAccessorIdx = primitive.indices; int indicesAccessorIdx = primitive.indices;
if (indicesAccessorIdx > _file.accessors.size()) {
qWarning(modelformat) << "Indices accessor index is out of bounds for model " << _url;
continue;
}
GLTFAccessor& indicesAccessor = _file.accessors[indicesAccessorIdx]; GLTFAccessor& indicesAccessor = _file.accessors[indicesAccessorIdx];
// Buffers // Buffers
@ -1093,6 +1098,11 @@ bool GLTFSerializer::buildGeometry(HFMModel& hfmModel, const hifi::VariantHash&
foreach(auto &key, keys) { foreach(auto &key, keys) {
int accessorIdx = primitive.attributes.values[key]; int accessorIdx = primitive.attributes.values[key];
if (accessorIdx > _file.accessors.size()) {
qWarning(modelformat) << "Accessor index is out of bounds for model " << _url;
continue;
}
GLTFAccessor& accessor = _file.accessors[accessorIdx]; GLTFAccessor& accessor = _file.accessors[accessorIdx];
if (key == "POSITION") { if (key == "POSITION") {