From fda2cde0067cb6bd9e6e99c3fab8dfd5e0819f5f Mon Sep 17 00:00:00 2001 From: Brad Davis Date: Tue, 15 Nov 2016 14:16:54 -0800 Subject: [PATCH] Fix buffer leak in line entity --- .../entities-renderer/src/RenderableLineEntityItem.cpp | 7 +++++++ libraries/entities-renderer/src/RenderableLineEntityItem.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libraries/entities-renderer/src/RenderableLineEntityItem.cpp b/libraries/entities-renderer/src/RenderableLineEntityItem.cpp index b8815aab7c..4da9efe883 100644 --- a/libraries/entities-renderer/src/RenderableLineEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableLineEntityItem.cpp @@ -24,6 +24,13 @@ EntityItemPointer RenderableLineEntityItem::factory(const EntityItemID& entityID return entity; } +RenderableLineEntityItem::~RenderableLineEntityItem() { + auto geometryCache = DependencyManager::get(); + if (geometryCache) { + geometryCache->releaseID(_lineVerticesID); + } +} + void RenderableLineEntityItem::updateGeometry() { auto geometryCache = DependencyManager::get(); if (_lineVerticesID == GeometryCache::UNKNOWN_ID) { diff --git a/libraries/entities-renderer/src/RenderableLineEntityItem.h b/libraries/entities-renderer/src/RenderableLineEntityItem.h index 1227c6e63d..6282bbbfc0 100644 --- a/libraries/entities-renderer/src/RenderableLineEntityItem.h +++ b/libraries/entities-renderer/src/RenderableLineEntityItem.h @@ -23,6 +23,7 @@ public: LineEntityItem(entityItemID), _lineVerticesID(GeometryCache::UNKNOWN_ID) { } + ~RenderableLineEntityItem(); virtual void render(RenderArgs* args) override;