From 89665d48531d741f1ac1a9261e411dc2e9e7d6a4 Mon Sep 17 00:00:00 2001 From: David Kelly Date: Thu, 13 Oct 2016 12:05:59 -0700 Subject: [PATCH 1/2] Correct audio url for play button Probably this used to be correct? Anyways seems to work now --- .../CellScience/Scripts/showButtonToPlaySound.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unpublishedScripts/DomainContent/CellScience/Scripts/showButtonToPlaySound.js b/unpublishedScripts/DomainContent/CellScience/Scripts/showButtonToPlaySound.js index 6ee3b9645b..6c1533371b 100644 --- a/unpublishedScripts/DomainContent/CellScience/Scripts/showButtonToPlaySound.js +++ b/unpublishedScripts/DomainContent/CellScience/Scripts/showButtonToPlaySound.js @@ -6,7 +6,7 @@ // (function() { - var baseURL = "https://hifi-production.s3.amazonaws.com/hifi-production/DomainContent/CellScience/"; + var baseURL = "https://hifi-production.s3.amazonaws.com/DomainContent/CellScience/"; var self = this; this.buttonImageURL = baseURL + "GUI/play_audio.svg?2"; @@ -116,4 +116,4 @@ Controller.mousePressEvent.connect(this.onClick); Script.update.connect(this.update); -}); \ No newline at end of file +}); From 18849d54166d83094780052a73bb29bcba34ff29 Mon Sep 17 00:00:00 2001 From: David Kelly Date: Fri, 14 Oct 2016 14:42:50 -0700 Subject: [PATCH 2/2] Fixed sound issue Long ago, localOnly didn't change volume based on position, let alone do HTRF. Now it does, though only the former on stereo .wav files. So we were playing the sound at a position far from where you may have been, and also with a really low volume. This addresses both. --- .../DomainContent/CellScience/Scripts/showIdentification.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/unpublishedScripts/DomainContent/CellScience/Scripts/showIdentification.js b/unpublishedScripts/DomainContent/CellScience/Scripts/showIdentification.js index a7a74fa79c..c33caf8b37 100644 --- a/unpublishedScripts/DomainContent/CellScience/Scripts/showIdentification.js +++ b/unpublishedScripts/DomainContent/CellScience/Scripts/showIdentification.js @@ -47,8 +47,7 @@ stereo: true, loop: false, localOnly: true, - volume: 0.035, - position: properties.position + volume: 0.45, }; self.sound = SoundCache.getSound(self.soundURL); self.buttonImageURL = baseURL + "GUI/GUI_audio.png?" + version; @@ -142,6 +141,7 @@ Overlays.editOverlay(self.button, { visible: false }); + self.soundOptions.position = MyAvatar.position; this.soundPlaying = Audio.playSound(self.sound, self.soundOptions); } else { // print("not downloaded"); @@ -162,4 +162,4 @@ Controller.mousePressEvent.connect(this.onClick); -}); \ No newline at end of file +});