From f74725042ed3164be7366ef00ceebf4ea2f0e578 Mon Sep 17 00:00:00 2001 From: Karol Suprynowicz Date: Sun, 15 Oct 2023 18:46:47 +0200 Subject: [PATCH] Better name for LOD options and clearer documentation --- .../hifi/dialogs/graphics/GraphicsSettings.qml | 8 ++++---- interface/src/LODManager.h | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml index 707a890edb..1e1ee376a8 100644 --- a/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml +++ b/interface/resources/qml/hifi/dialogs/graphics/GraphicsSettings.qml @@ -144,7 +144,7 @@ Flickable { HifiStylesUit.RalewayRegular { id: worldDetailHeader - text: "World Detail" + text: "Target frame rate" anchors.left: parent.left anchors.top: parent.top width: 130 @@ -157,13 +157,13 @@ Flickable { id: worldDetailModel ListElement { - text: "Low World Detail" + text: "High Frame Rate/Low Detail" } ListElement { - text: "Medium World Detail" + text: "Medium Frame Rate/Medium Detail" } ListElement { - text: "Full World Detail" + text: "Low Frame Rate/High Detail" } } diff --git a/interface/src/LODManager.h b/interface/src/LODManager.h index f903aa8997..ff453ae28a 100644 --- a/interface/src/LODManager.h +++ b/interface/src/LODManager.h @@ -29,15 +29,15 @@ class ScriptEngine; /*@jsdoc - *

The world detail quality rendered.

+ *

The balance between target framerate and world detail quality rendered.

* * * * * - * - * - * + * + * + * * *
ValueDescription
0Low world detail quality.
1Medium world detail quality.
2High world detail quality.
0High frame rate / Low detail quality.
1Medium frame rate / Medium detail quality.
2Low frame rate / High detail quality.
* @typedef {number} LODManager.WorldDetailQuality @@ -121,11 +121,11 @@ class AABox; * it to be rendered, in degrees. The angular dimension is calculated as a sphere of radius half the diagonal of the * entity's AA box. - * @property {number} lodFarMaxAngleDeg - The upper limit of how big the minimum angular dimension (relative to the camera position) - * of an entity in order for it to be rendered, in degrees at distance specified by lodFarDistance. The angular dimension is + * @property {number} lodFarMaxAngleDeg - The maximum angular size (relative to the camera position) + * of an entity that is allowed to be culled by LOD Manager, in degrees at distance specified by lodFarDistance. The angular dimension is * calculated as a sphere of radius half the diagonal of the entity's AA box. - * @property {number} lodNearMaxAngleDeg - The upper limit of how big the minimum angular dimension (relative to the camera position) - * of an entity in order for it to be rendered, in degrees at distance specified by lodFarDistance. The angular dimension is + * @property {number} lodNearMaxAngleDeg - The maximum angular size (relative to the camera position) +* of an entity that is allowed to be culled by LOD Manager, in degrees at distance specified by lodNearDistance. The angular dimension is * calculated as a sphere of radius half the diagonal of the entity's AA box. * @property {number} lodFarDistance - Distance for which lodFarMaxAngleDeg limit is applied