From f169ab1238a7547636a6c9508afb40c42da03beb Mon Sep 17 00:00:00 2001 From: David Rowe Date: Sat, 21 Feb 2015 11:26:48 -0800 Subject: [PATCH] Tidy and document DDE face tracker UDP socket opening and closing --- interface/src/devices/DdeFaceTracker.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/interface/src/devices/DdeFaceTracker.cpp b/interface/src/devices/DdeFaceTracker.cpp index c4797c4018..87a180bd1e 100644 --- a/interface/src/devices/DdeFaceTracker.cpp +++ b/interface/src/devices/DdeFaceTracker.cpp @@ -93,13 +93,10 @@ void DdeFaceTracker::update() { } void DdeFaceTracker::setEnabled(bool enabled) { + // isOpen() does not work as one might expect on QUdpSocket; don't test isOpen() before closing socket. + _udpSocket.close(); if (enabled) { - if (_udpSocket.isOpen()) { - _udpSocket.close(); - } _udpSocket.bind(_host, _port); - } else { - _udpSocket.close(); } }