more CR feedback

This commit is contained in:
ZappoMan 2017-04-21 13:13:29 -07:00
parent 088cdae320
commit f07884602a
2 changed files with 6 additions and 6 deletions

View file

@ -50,7 +50,7 @@ public:
qint64 getBytesLeftToRead() const { return _data.size() - _position; } qint64 getBytesLeftToRead() const { return _data.size() - _position; }
udt::Packet::MessageNumber getMessageNumber() const { return _messageNumber; } const udt::Packet::MessageNumber& getMessageNumber() const { return _messageNumber; }
void seek(qint64 position) { _position = position; } void seek(qint64 position) { _position = position; }

View file

@ -395,8 +395,8 @@ public:
const QUrl& getURL() const { return _url; } const QUrl& getURL() const { return _url; }
int getDownloadAttempts() { return _attempts; } unsigned int getDownloadAttempts() { return _attempts; }
int getDownloadAttemptsRemaining() { return _attemptsRemaining; } unsigned int getDownloadAttemptsRemaining() { return _attemptsRemaining; }
signals: signals:
/// Fired when the resource begins downloading. /// Fired when the resource begins downloading.
@ -476,11 +476,11 @@ private:
qint64 _bytesReceived{ 0 }; qint64 _bytesReceived{ 0 };
qint64 _bytesTotal{ 0 }; qint64 _bytesTotal{ 0 };
qint64 _bytes{ 0 }; qint64 _bytes{ 0 };
int _attempts{ 0 }; unsigned int _attempts{ 0 };
const int MAX_ATTEMPTS = 8; static const int MAX_ATTEMPTS = 8;
int _attemptsRemaining { MAX_ATTEMPTS }; unsigned int _attemptsRemaining { MAX_ATTEMPTS };
bool _isInScript{ false }; bool _isInScript{ false };
}; };