Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-06 19:59:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Clean-up.

Browse source
This commit is contained in:
NissimHadar 2019-04-02 08:59:05 -07:00
parent cf7eeb7355
commit efd9a8935e
1 changed files with 7 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tools/nitpick/src/TestCreator.cpp
View file

@ -430,8 +430,9 @@ void TestCreator::createTests(const QString& clientProfile) {
parent += "/"; parent += "/";
} }
_testsRootDirectory = QFileDialog::getExistingDirectory(nullptr, "Please select test root folder", parent, if (!createAllFilesSetup()) {
QFileDialog::ShowDirsOnly); return;
}
// If user canceled then restore previous selection and return // If user canceled then restore previous selection and return
if (_testsRootDirectory == "") { if (_testsRootDirectory == "") {
@ -881,23 +882,12 @@ void TestCreator::createRecursiveScript(const QString& directory, bool interacti
} }
void TestCreator::createTestsOutline() { void TestCreator::createTestsOutline() {
QString previousSelection = _testDirectory; if (!createAllFilesSetup()) {
QString parent = previousSelection.left(previousSelection.lastIndexOf('/'));
if (!parent.isNull() && parent.right(1) != "/") {
parent += "/";
}
_testDirectory =
QFileDialog::getExistingDirectory(nullptr, "Please select the tests root folder", parent, QFileDialog::ShowDirsOnly);
// If user canceled then restore previous selection and return
if (_testDirectory == "") {
_testDirectory = previousSelection;
return; return;
} }
const QString testsOutlineFilename { "testsOutline.md" }; const QString testsOutlineFilename { "testsOutline.md" };
QString mdFilename(_testDirectory + "/" + testsOutlineFilename); QString mdFilename(_testsRootDirectory + "/" + testsOutlineFilename);
QFile mdFile(mdFilename); QFile mdFile(mdFilename);
if (!mdFile.open(QIODevice::WriteOnly)) { if (!mdFile.open(QIODevice::WriteOnly)) {
QMessageBox::critical(0, "Internal error: " + QString(__FILE__) + ":" + QString::number(__LINE__), "Failed to create file " + mdFilename); QMessageBox::critical(0, "Internal error: " + QString(__FILE__) + ":" + QString::number(__LINE__), "Failed to create file " + mdFilename);
@ -911,10 +901,10 @@ void TestCreator::createTestsOutline() {
stream << "Directories with an appended (*) have an automatic test\n\n"; stream << "Directories with an appended (*) have an automatic test\n\n";
// We need to know our current depth, as this isn't given by QDirIterator // We need to know our current depth, as this isn't given by QDirIterator
int rootDepth { _testDirectory.count('/') }; int rootDepth { _testsRootDirectory.count('/') };
// Each test is shown as the folder name linking to the matching GitHub URL, and the path to the associated test.md file // Each test is shown as the folder name linking to the matching GitHub URL, and the path to the associated test.md file
QDirIterator it(_testDirectory, QDirIterator::Subdirectories); QDirIterator it(_testsRootDirectory, QDirIterator::Subdirectories);
while (it.hasNext()) { while (it.hasNext()) {
QString directory = it.next(); QString directory = it.next();