From c7022988ead77d049a4e75b95e282436907b37e4 Mon Sep 17 00:00:00 2001 From: sabrina-shanman Date: Fri, 14 Dec 2018 09:14:07 -0800 Subject: [PATCH 1/2] Revert "Add VaryingSet1 to Task aliases" This reverts commit 25e3d4994106c74a14adf38ce1d52cb1b1788be7. --- libraries/task/src/task/Task.h | 1 - libraries/task/src/task/Varying.h | 20 -------------------- 2 files changed, 21 deletions(-) diff --git a/libraries/task/src/task/Task.h b/libraries/task/src/task/Task.h index 9647157a54..fb7012b16c 100644 --- a/libraries/task/src/task/Task.h +++ b/libraries/task/src/task/Task.h @@ -411,7 +411,6 @@ protected: using Task = task::Task; \ using Engine = task::Engine; \ using Varying = task::Varying; \ - template < typename T0 > using VaryingSet1 = task::VaryingSet1; \ template < typename T0, typename T1 > using VaryingSet2 = task::VaryingSet2; \ template < typename T0, typename T1, typename T2 > using VaryingSet3 = task::VaryingSet3; \ template < typename T0, typename T1, typename T2, typename T3 > using VaryingSet4 = task::VaryingSet4; \ diff --git a/libraries/task/src/task/Varying.h b/libraries/task/src/task/Varying.h index 60f3c6dec4..9536db2799 100644 --- a/libraries/task/src/task/Varying.h +++ b/libraries/task/src/task/Varying.h @@ -69,26 +69,6 @@ protected: std::shared_ptr _concept; }; -template < typename T0 > -class VaryingSet1 : public std::tuple { -public: - using Parent = std::tuple; - - VaryingSet1() : Parent(Varying(T0())) {} - VaryingSet1(const VaryingSet1& src) : Parent(std::get<0>(src)) {} - VaryingSet1(const Varying& first) : Parent(first) {} - - const T0& get0() const { return std::get<0>((*this)).template get(); } - T0& edit0() { return std::get<0>((*this)).template edit(); } - - virtual Varying operator[] (uint8_t index) const { - return std::get<0>((*this)); - } - virtual uint8_t length() const { return 1; } - - Varying asVarying() const { return Varying((*this)); } -}; - using VaryingPairBase = std::pair; template < typename T0, typename T1 > class VaryingSet2 : public VaryingPairBase { From a36e75672e71929c92d5967b868ea7c0b3c5e668 Mon Sep 17 00:00:00 2001 From: sabrina-shanman Date: Fri, 14 Dec 2018 09:26:19 -0800 Subject: [PATCH 2/2] Remove dependency on VaryingSet1 --- libraries/model-baker/src/model-baker/Baker.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libraries/model-baker/src/model-baker/Baker.cpp b/libraries/model-baker/src/model-baker/Baker.cpp index 50b635583b..14ec62413e 100644 --- a/libraries/model-baker/src/model-baker/Baker.cpp +++ b/libraries/model-baker/src/model-baker/Baker.cpp @@ -17,23 +17,22 @@ namespace baker { public: using Unused = int; - using Input = VaryingSet1; - using Output = VaryingSet1; + using Input = hfm::Model::Pointer; + using Output = hfm::Model::Pointer; using JobModel = Task::ModelIO; void build(JobModel& model, const Varying& in, Varying& out) { - out = Output(in.getN(0)); + out = in; } }; Baker::Baker(const hfm::Model::Pointer& hfmModel) : _engine(std::make_shared(BakerEngineBuilder::JobModel::create("Baker"), std::make_shared())) { - _engine->feedInput(0, hfmModel); + _engine->feedInput(hfmModel); } void Baker::run() { _engine->run(); - auto& output = _engine->getOutput().get(); - hfmModel = output.get0(); + hfmModel = _engine->getOutput().get(); } };