code review

This commit is contained in:
Seth Alves 2018-03-14 14:33:17 -07:00
parent 93978209d8
commit e63558dc05
3 changed files with 5 additions and 5 deletions

View file

@ -3111,10 +3111,10 @@ bool Application::isServerlessMode() const {
return false;
}
void Application::setIsServerlessDomain(bool isHifiScheme) {
void Application::setIsServerlessDomain(bool serverlessDomain) {
auto tree = getEntities()->getTree();
if (tree) {
tree->setIsServerlessMode(!isHifiScheme);
tree->setIsServerlessMode(serverlessDomain);
}
}

View file

@ -208,7 +208,7 @@ bool AddressManager::handleUrl(const QUrl& lookupUrl, LookupTrigger trigger) {
qCDebug(networking) << "Trying to go to URL" << lookupUrl.toString();
emit urlHandled(true);
emit urlHandled(false);
DependencyManager::get<NodeList>()->flagTimeForConnectionStep(LimitedNodeList::ConnectionStep::LookupAddress);
// there are 4 possible lookup strings
@ -291,7 +291,7 @@ bool AddressManager::handleUrl(const QUrl& lookupUrl, LookupTrigger trigger) {
lookupUrl.scheme() == URL_SCHEME_FILE) {
_previousLookup.clear();
QUrl domainUrl = PathUtils::expandToLocalDataAbsolutePath(lookupUrl);
emit urlHandled(false);
emit urlHandled(true);
setDomainInfo(domainUrl, trigger);
DependencyManager::get<NodeList>()->getDomainHandler().setIsConnected(true);
emit lookupResultsFinished();

View file

@ -406,7 +406,7 @@ signals:
*/
void goForwardPossible(bool isPossible);
void urlHandled(bool isHifiScheme);
void urlHandled(bool isNonHifiScheme);
private slots:
void handleAPIResponse(QNetworkReply& requestReply);