From e3004af61aad58ff306d7182ca82cce445b581fd Mon Sep 17 00:00:00 2001 From: Dale Glass Date: Sat, 10 Jul 2021 01:42:10 +0200 Subject: [PATCH] More logging for crash reporting * Make it clear in cmake if crash reporting is going to be used * Log warning on startup if there's no crash reporting --- cmake/macros/AddCrashpad.cmake | 5 +++++ interface/src/CrashHandler_None.cpp | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/cmake/macros/AddCrashpad.cmake b/cmake/macros/AddCrashpad.cmake index f30e260563..684c842ea2 100644 --- a/cmake/macros/AddCrashpad.cmake +++ b/cmake/macros/AddCrashpad.cmake @@ -11,19 +11,24 @@ macro(add_crashpad) set (USE_CRASHPAD TRUE) + message(STATUS "Checking crashpad config") + if ("$ENV{CMAKE_BACKTRACE_URL}" STREQUAL "") + message(STATUS "Checking crashpad config - CMAKE_BACKTRACE_URL is not set, disabled.") set(USE_CRASHPAD FALSE) else() set(CMAKE_BACKTRACE_URL $ENV{CMAKE_BACKTRACE_URL}) endif() if ("$ENV{CMAKE_BACKTRACE_TOKEN}" STREQUAL "") + message(STATUS "Checking crashpad config - CMAKE_BACKTRACE_TOKEN is not set, disabled.") set(USE_CRASHPAD FALSE) else() set(CMAKE_BACKTRACE_TOKEN $ENV{CMAKE_BACKTRACE_TOKEN}) endif() if (USE_CRASHPAD) + message(STATUS "Checking crashpad config - enabled.") get_property(CRASHPAD_CHECKED GLOBAL PROPERTY CHECKED_FOR_CRASHPAD_ONCE) if (NOT CRASHPAD_CHECKED) diff --git a/interface/src/CrashHandler_None.cpp b/interface/src/CrashHandler_None.cpp index 4fe56cd042..2e86472705 100644 --- a/interface/src/CrashHandler_None.cpp +++ b/interface/src/CrashHandler_None.cpp @@ -17,8 +17,11 @@ #include + +Q_LOGGING_CATEGORY(crash_handler, "vircadia.crash_handler") + bool startCrashHandler(std::string appPath) { - qDebug() << "No crash handler available."; + qCWarning(crash_handler) << "No crash handler available."; return false; }