From df954cab1038507604be9fdbea5b22a21c4d7ca1 Mon Sep 17 00:00:00 2001 From: Brad Hefta-Gaub Date: Mon, 19 Dec 2016 16:15:10 -0800 Subject: [PATCH] remove some log spam, recatargorize script logs to allow fine grain filtering --- interface/src/ui/overlays/Circle3DOverlay.cpp | 3 --- interface/src/ui/overlays/Line3DOverlay.cpp | 3 --- libraries/gl/src/gl/OffscreenQmlSurface.cpp | 1 + libraries/script-engine/src/ScriptEngine.cpp | 4 +++- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/interface/src/ui/overlays/Circle3DOverlay.cpp b/interface/src/ui/overlays/Circle3DOverlay.cpp index bea737baa9..ae0173f054 100644 --- a/interface/src/ui/overlays/Circle3DOverlay.cpp +++ b/interface/src/ui/overlays/Circle3DOverlay.cpp @@ -19,7 +19,6 @@ QString const Circle3DOverlay::TYPE = "circle3d"; Circle3DOverlay::Circle3DOverlay() { memset(&_minorTickMarksColor, 0, sizeof(_minorTickMarksColor)); memset(&_majorTickMarksColor, 0, sizeof(_majorTickMarksColor)); - qDebug() << "Building circle3d overlay"; } Circle3DOverlay::Circle3DOverlay(const Circle3DOverlay* circle3DOverlay) : @@ -40,7 +39,6 @@ Circle3DOverlay::Circle3DOverlay(const Circle3DOverlay* circle3DOverlay) : _majorTicksVerticesID(GeometryCache::UNKNOWN_ID), _minorTicksVerticesID(GeometryCache::UNKNOWN_ID) { - qDebug() << "Building circle3d overlay"; } Circle3DOverlay::~Circle3DOverlay() { @@ -59,7 +57,6 @@ Circle3DOverlay::~Circle3DOverlay() { geometryCache->releaseID(_minorTicksVerticesID); } } - qDebug() << "Destroying circle3d overlay"; } void Circle3DOverlay::render(RenderArgs* args) { if (!_visible) { diff --git a/interface/src/ui/overlays/Line3DOverlay.cpp b/interface/src/ui/overlays/Line3DOverlay.cpp index 795faa2748..97e7d825f2 100644 --- a/interface/src/ui/overlays/Line3DOverlay.cpp +++ b/interface/src/ui/overlays/Line3DOverlay.cpp @@ -19,7 +19,6 @@ QString const Line3DOverlay::TYPE = "line3d"; Line3DOverlay::Line3DOverlay() : _geometryCacheID(DependencyManager::get()->allocateID()) { - qDebug() << "Building line3D overlay"; } Line3DOverlay::Line3DOverlay(const Line3DOverlay* line3DOverlay) : @@ -28,11 +27,9 @@ Line3DOverlay::Line3DOverlay(const Line3DOverlay* line3DOverlay) : _end(line3DOverlay->_end), _geometryCacheID(DependencyManager::get()->allocateID()) { - qDebug() << "Building line3D overlay"; } Line3DOverlay::~Line3DOverlay() { - qDebug() << "Destryoing line3D overlay"; auto geometryCache = DependencyManager::get(); if (_geometryCacheID && geometryCache) { geometryCache->releaseID(_geometryCacheID); diff --git a/libraries/gl/src/gl/OffscreenQmlSurface.cpp b/libraries/gl/src/gl/OffscreenQmlSurface.cpp index e0c3317b55..4ab19744d4 100644 --- a/libraries/gl/src/gl/OffscreenQmlSurface.cpp +++ b/libraries/gl/src/gl/OffscreenQmlSurface.cpp @@ -609,6 +609,7 @@ QObject* OffscreenQmlSurface::finishQmlLoad(std::function(); +Q_LOGGING_CATEGORY(scriptengineScript, "hifi.scriptengine.script") + static QScriptValue debugPrint(QScriptContext* context, QScriptEngine* engine){ QString message = ""; for (int i = 0; i < context->argumentCount(); i++) { @@ -78,7 +80,7 @@ static QScriptValue debugPrint(QScriptContext* context, QScriptEngine* engine){ } message += context->argument(i).toString(); } - qCDebug(scriptengine).noquote() << "script:print()<<" << message; // noquote() so that \n is treated as newline + qCDebug(scriptengineScript).noquote() << "script:print()<<" << message; // noquote() so that \n is treated as newline message = message.replace("\\", "\\\\") .replace("\n", "\\n")