Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-08-07 18:30:42 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #12268 from hyperlogic/bug-fix/rc63-twisted-knees

Browse source 
RC63: Bug fix for twisted knees on some avatars.
This commit is contained in:
John Conklin II 2018-01-26 09:42:24 -08:00 committed by GitHub
commit dd628a4d95
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
libraries/fbx/src/FBXReader.cpp
View file

@ -1733,8 +1733,18 @@ FBXGeometry* FBXReader::extractFBXGeometry(const QVariantHash& mapping, const QS
qCDebug(modelformat) << "Joint not in model list: " << jointID; qCDebug(modelformat) << "Joint not in model list: " << jointID;
fbxCluster.jointIndex = 0; fbxCluster.jointIndex = 0;
} }
fbxCluster.inverseBindMatrix = glm::inverse(cluster.transformLink) * modelTransform; fbxCluster.inverseBindMatrix = glm::inverse(cluster.transformLink) * modelTransform;
// slam bottom row to (0, 0, 0, 1), we KNOW this is not a perspective matrix and
// sometimes floating point fuzz can be introduced after the inverse.
fbxCluster.inverseBindMatrix[0][3] = 0.0f;
fbxCluster.inverseBindMatrix[1][3] = 0.0f;
fbxCluster.inverseBindMatrix[2][3] = 0.0f;
fbxCluster.inverseBindMatrix[3][3] = 1.0f;
fbxCluster.inverseBindTransform = Transform(fbxCluster.inverseBindMatrix); fbxCluster.inverseBindTransform = Transform(fbxCluster.inverseBindMatrix);
extracted.mesh.clusters.append(fbxCluster); extracted.mesh.clusters.append(fbxCluster);
// override the bind rotation with the transform link // override the bind rotation with the transform link
@ -1836,13 +1846,13 @@ FBXGeometry* FBXReader::extractFBXGeometry(const QVariantHash& mapping, const QS
} }
// now that we've accumulated the most relevant weights for each vertex // now that we've accumulated the most relevant weights for each vertex
// normalize and compress to 8-bits // normalize and compress to 16-bits
extracted.mesh.clusterWeights.fill(0, numClusterIndices); extracted.mesh.clusterWeights.fill(0, numClusterIndices);
int numVertices = extracted.mesh.vertices.size(); int numVertices = extracted.mesh.vertices.size();
for (int i = 0; i < numVertices; ++i) { for (int i = 0; i < numVertices; ++i) {
int j = i * WEIGHTS_PER_VERTEX; int j = i * WEIGHTS_PER_VERTEX;
// normalize weights into uint8_t // normalize weights into uint16_t
float totalWeight = weightAccumulators[j]; float totalWeight = weightAccumulators[j];
for (int k = j + 1; k < j + WEIGHTS_PER_VERTEX; ++k) { for (int k = j + 1; k < j + WEIGHTS_PER_VERTEX; ++k) {
totalWeight += weightAccumulators[k]; totalWeight += weightAccumulators[k];

4
libraries/render-utils/src/Skinning.slh
View file

@ -39,12 +39,12 @@ mat4 dualQuatToMat4(vec4 real, vec4 dual) {
twoRealXZ - twoRealYW, twoRealXZ - twoRealYW,
0.0); 0.0);
vec4 col1 = vec4(twoRealXY - twoRealZW, vec4 col1 = vec4(twoRealXY - twoRealZW,
1 - twoRealXSq - twoRealZSq, 1.0 - twoRealXSq - twoRealZSq,
twoRealYZ + twoRealXW, twoRealYZ + twoRealXW,
0.0); 0.0);
vec4 col2 = vec4(twoRealXZ + twoRealYW, vec4 col2 = vec4(twoRealXZ + twoRealYW,
twoRealYZ - twoRealXW, twoRealYZ - twoRealXW,
1 - twoRealXSq - twoRealYSq, 1.0 - twoRealXSq - twoRealYSq,
0.0); 0.0);
vec4 col3 = vec4(2.0 * (-dual.w * real.x + dual.x * real.w - dual.y * real.z + dual.z * real.y), vec4 col3 = vec4(2.0 * (-dual.w * real.x + dual.x * real.w - dual.y * real.z + dual.z * real.y),
2.0 * (-dual.w * real.y + dual.x * real.z + dual.y * real.w - dual.z * real.x), 2.0 * (-dual.w * real.y + dual.x * real.z + dual.y * real.w - dual.z * real.x),