From db14cdbd223a02cb29231dc8c418db8cafc8b264 Mon Sep 17 00:00:00 2001 From: Simon Walton Date: Fri, 4 Oct 2019 09:56:35 -0700 Subject: [PATCH] Tweak 'critical' status for some logging --- domain-server/src/DomainServer.cpp | 3 ++- libraries/networking/src/AccountManager.cpp | 2 +- libraries/networking/src/LimitedNodeList.cpp | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp index 9cbfc0b991..ceb4679137 100644 --- a/domain-server/src/DomainServer.cpp +++ b/domain-server/src/DomainServer.cpp @@ -1636,7 +1636,8 @@ void DomainServer::handleFailedICEServerAddressUpdate(QNetworkReply* requestRepl const int ICE_SERVER_UPDATE_RETRY_MS = 2 * 1000; qCWarning(domain_server_ice) << "PAGE: Failed to update ice-server address (" << _iceServerSocket << - ") with Metaverse (" << requestReply->url() << ") error:" << requestReply->errorString(); + ") with Metaverse (" << requestReply->url() << ") (critical error for auto-networking) error:" << + requestReply->errorString(); qCWarning(domain_server_ice) << "\tRe-attempting in" << ICE_SERVER_UPDATE_RETRY_MS / 1000 << "seconds"; QTimer::singleShot(ICE_SERVER_UPDATE_RETRY_MS, this, SLOT(sendICEServerAddressToMetaverseAPI())); diff --git a/libraries/networking/src/AccountManager.cpp b/libraries/networking/src/AccountManager.cpp index 251ab819a4..5edbc5261d 100644 --- a/libraries/networking/src/AccountManager.cpp +++ b/libraries/networking/src/AccountManager.cpp @@ -1035,7 +1035,7 @@ void AccountManager::publicKeyUploadSucceeded(QNetworkReply* reply) { void AccountManager::publicKeyUploadFailed(QNetworkReply* reply) { // the public key upload has failed - qWarning() << "PAGE: Public key upload failed from AccountManager to" << reply->url() << reply->errorString(); + qCritical() << "PAGE: Public key upload failed from AccountManager to" << reply->url() << reply->errorString(); // we aren't waiting for a response any longer _isWaitingForKeypairResponse = false; diff --git a/libraries/networking/src/LimitedNodeList.cpp b/libraries/networking/src/LimitedNodeList.cpp index cdb52cf422..ecf2218e2f 100644 --- a/libraries/networking/src/LimitedNodeList.cpp +++ b/libraries/networking/src/LimitedNodeList.cpp @@ -1171,7 +1171,7 @@ void LimitedNodeList::stopInitialSTUNUpdate(bool success) { if (!success) { // if we're here this was the last failed STUN request // use our DS as our stun server - qCWarning(networking, "PAGE: Failed to lookup public address via STUN server at %s:%hu.", + qCWarning(networking, "PAGE: Failed to lookup public address via STUN server at %s:%hu (likely a critical error for auto-networking).", STUN_SERVER_HOSTNAME, STUN_SERVER_PORT); qCDebug(networking) << "LimitedNodeList public socket will be set with local port and null QHostAddress."; @@ -1207,7 +1207,7 @@ void LimitedNodeList::updateLocalSocket() { } // attempt to use Google's DNS to confirm that local IP - static const QHostAddress RELIABLE_LOCAL_IP_CHECK_HOST = QHostAddress{ "8.8.8.8" }; + static const QHostAddress RELIABLE_LOCAL_IP_CHECK_HOST = QHostAddress { "8.8.8.8" }; static const int RELIABLE_LOCAL_IP_CHECK_PORT = 53; QTcpSocket* localIPTestSocket = new QTcpSocket;