fix some recently introduced warnings

This commit is contained in:
ZappoMan 2014-09-06 16:03:03 -07:00
parent fe3f0cd358
commit d734655ab6
2 changed files with 3 additions and 3 deletions

View file

@ -88,7 +88,6 @@ ScriptEngine::ScriptEngine(const QString& scriptContents, const QString& fileNam
_isRunning(false),
_isInitialized(false),
_isAvatar(false),
_isUserLoaded(false),
_avatarIdentityTimer(NULL),
_avatarBillboardTimer(NULL),
_timerFunctionMap(),
@ -103,6 +102,7 @@ ScriptEngine::ScriptEngine(const QString& scriptContents, const QString& fileNam
_vec3Library(),
_uuidLibrary(),
_animationCache(this),
_isUserLoaded(false),
_arrayBufferClass(new ArrayBufferClass(this))
{
}
@ -114,7 +114,6 @@ ScriptEngine::ScriptEngine(const QUrl& scriptURL,
_isRunning(false),
_isInitialized(false),
_isAvatar(false),
_isUserLoaded(false),
_avatarIdentityTimer(NULL),
_avatarBillboardTimer(NULL),
_timerFunctionMap(),
@ -129,6 +128,7 @@ ScriptEngine::ScriptEngine(const QUrl& scriptURL,
_vec3Library(),
_uuidLibrary(),
_animationCache(this),
_isUserLoaded(false),
_arrayBufferClass(new ArrayBufferClass(this))
{
QString scriptURLString = scriptURL.toString();

View file

@ -158,7 +158,7 @@ QScriptClass::QueryFlags TypedArray::queryProperty(const QScriptValue& object,
quint32 pos = name.toArrayIndex(&ok);
// Check that name is a valid index and arrayBuffer exists
if (ok && pos >= 0 && pos < length) {
if (ok && pos < length) {
*id = byteOffset + pos * _bytesPerElement; // save pos to avoid recomputation
return HandlesReadAccess | HandlesWriteAccess; // Read/Write access
}