From d5fe6f0bdbac9826a86b3b4ad8861c84a6bc615e Mon Sep 17 00:00:00 2001 From: Brad Davis Date: Thu, 2 Jul 2015 12:34:32 -0700 Subject: [PATCH] Inhibiting log spam unless a menu item is selected --- interface/src/Application.cpp | 4 +++- interface/src/Menu.cpp | 1 + interface/src/Menu.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index f758145a85..2f1797e649 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -1796,7 +1796,9 @@ void Application::idle() { static uint64_t lastReportTime = now; if ((now - lastReportTime) >= (USECS_PER_SECOND)) { static QString LOGLINE("Average inter-idle time: %1 us for %2 samples"); - qCDebug(interfaceapp_timing) << LOGLINE.arg((int)interIdleDurations.getAverage()).arg(interIdleDurations.getCount()); + if (Menu::getInstance()->isOptionChecked(MenuOption::LogExtraTimings)) { + qCDebug(interfaceapp_timing) << LOGLINE.arg((int)interIdleDurations.getAverage()).arg(interIdleDurations.getCount()); + } interIdleDurations.reset(); lastReportTime = now; } diff --git a/interface/src/Menu.cpp b/interface/src/Menu.cpp index 20d88a59c0..c70d11b837 100644 --- a/interface/src/Menu.cpp +++ b/interface/src/Menu.cpp @@ -529,6 +529,7 @@ Menu::Menu() { addCheckableActionToQMenuAndActionHash(timingMenu, MenuOption::FrameTimer); addActionToQMenuAndActionHash(timingMenu, MenuOption::RunTimingTests, 0, qApp, SLOT(runTests())); addCheckableActionToQMenuAndActionHash(timingMenu, MenuOption::PipelineWarnings); + addCheckableActionToQMenuAndActionHash(timingMenu, MenuOption::LogExtraTimings); addCheckableActionToQMenuAndActionHash(timingMenu, MenuOption::SuppressShortTimings); auto audioIO = DependencyManager::get(); diff --git a/interface/src/Menu.h b/interface/src/Menu.h index 0097437107..fae7092989 100644 --- a/interface/src/Menu.h +++ b/interface/src/Menu.h @@ -212,6 +212,7 @@ namespace MenuOption { const QString LodTools = "LOD Tools"; const QString Login = "Login"; const QString Log = "Log"; + const QString LogExtraTimings = "Log Extra Timing Details"; const QString LowVelocityFilter = "Low Velocity Filter"; const QString Mirror = "Mirror"; const QString MuteAudio = "Mute Microphone";