mirror of
https://github.com/overte-org/overte.git
synced 2025-08-09 05:58:27 +02:00
remove some dead code, added a debugging notes comment
This commit is contained in:
parent
2e7a43a7fb
commit
d32fc645e8
1 changed files with 5 additions and 16 deletions
|
@ -63,6 +63,11 @@ EntityTreeRenderer::~EntityTreeRenderer() {
|
||||||
// automatically but we do need to delete our sandbox script engine.
|
// automatically but we do need to delete our sandbox script engine.
|
||||||
|
|
||||||
if (_sandboxScriptEngine) {
|
if (_sandboxScriptEngine) {
|
||||||
|
// NOTE: is it possible this is a problem? I think that we hook the script engine object up to a deleteLater()
|
||||||
|
// call inside of registerScriptEngineWithApplicationServices() but do we not call that for _sandboxScriptEngine???
|
||||||
|
// this _sandboxScriptEngine implementation is confusing and potentially error prone because it's not a full fledged
|
||||||
|
// ScriptEngine that has been fully connected. We did this so that scripts that were ill-formed could be evaluated
|
||||||
|
// but not execute against the application.
|
||||||
qDebug() << "EntityTreeRenderer::~EntityTreeRenderer() delete _sandboxScriptEngine!!!!!";
|
qDebug() << "EntityTreeRenderer::~EntityTreeRenderer() delete _sandboxScriptEngine!!!!!";
|
||||||
delete _sandboxScriptEngine;
|
delete _sandboxScriptEngine;
|
||||||
_sandboxScriptEngine = NULL;
|
_sandboxScriptEngine = NULL;
|
||||||
|
@ -103,22 +108,6 @@ void EntityTreeRenderer::init() {
|
||||||
|
|
||||||
void EntityTreeRenderer::shutdown() {
|
void EntityTreeRenderer::shutdown() {
|
||||||
_shuttingDown = true;
|
_shuttingDown = true;
|
||||||
|
|
||||||
/*
|
|
||||||
if (_entitiesScriptEngine) {
|
|
||||||
_entitiesScriptEngine->stop();
|
|
||||||
|
|
||||||
QEventLoop loop;
|
|
||||||
QObject::connect(_entitiesScriptEngine, &ScriptEngine::doneRunning, &loop, &QEventLoop::quit);
|
|
||||||
|
|
||||||
_entitiesScriptEngine->stop();
|
|
||||||
|
|
||||||
qDebug() << "waiting on Entities sandbox script to stop... ";
|
|
||||||
loop.exec();
|
|
||||||
qDebug() << "done waiting... ";
|
|
||||||
|
|
||||||
}
|
|
||||||
*/
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue