Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-20 02:03:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

remove some dead code, added a debugging notes comment

Browse source
This commit is contained in:
ZappoMan 2015-02-23 09:10:15 -08:00
parent 2e7a43a7fb
commit d32fc645e8
1 changed files with 5 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
libraries/entities-renderer/src/EntityTreeRenderer.cpp
View file

@ -63,6 +63,11 @@ EntityTreeRenderer::~EntityTreeRenderer() {
// automatically but we do need to delete our sandbox script engine.
if (_sandboxScriptEngine) {
// NOTE: is it possible this is a problem? I think that we hook the script engine object up to a deleteLater()
// call inside of registerScriptEngineWithApplicationServices() but do we not call that for _sandboxScriptEngine???
// this _sandboxScriptEngine implementation is confusing and potentially error prone because it's not a full fledged
// ScriptEngine that has been fully connected. We did this so that scripts that were ill-formed could be evaluated
// but not execute against the application.
qDebug() << "EntityTreeRenderer::~EntityTreeRenderer() delete _sandboxScriptEngine!!!!!";
delete _sandboxScriptEngine;
_sandboxScriptEngine = NULL;
@ -103,22 +108,6 @@ void EntityTreeRenderer::init() {
void EntityTreeRenderer::shutdown() {
_shuttingDown = true;
/*
if (_entitiesScriptEngine) {
_entitiesScriptEngine->stop();
QEventLoop loop;
QObject::connect(_entitiesScriptEngine, &ScriptEngine::doneRunning, &loop, &QEventLoop::quit);
_entitiesScriptEngine->stop();
qDebug() << "waiting on Entities sandbox script to stop... ";
loop.exec();
qDebug() << "done waiting... ";
}
*/
}