From d31cdd3779c6f8071667f616ccd02cfca0841a5e Mon Sep 17 00:00:00 2001 From: Seth Alves Date: Thu, 10 Jan 2019 15:35:40 -0800 Subject: [PATCH] review --- libraries/plugins/src/plugins/PluginManager.cpp | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libraries/plugins/src/plugins/PluginManager.cpp b/libraries/plugins/src/plugins/PluginManager.cpp index 9f481d04f1..a75ede3f03 100644 --- a/libraries/plugins/src/plugins/PluginManager.cpp +++ b/libraries/plugins/src/plugins/PluginManager.cpp @@ -47,26 +47,17 @@ PluginManagerPointer PluginManager::getInstance() { QString getPluginNameFromMetaData(const QJsonObject& object) { static const char* METADATA_KEY = "MetaData"; static const char* NAME_KEY = "name"; - if (!object.contains(METADATA_KEY) || !object[METADATA_KEY].isObject()) { - return QString(); - } return object[METADATA_KEY][NAME_KEY].toString(""); } QString getPluginIIDFromMetaData(const QJsonObject& object) { static const char* IID_KEY = "IID"; - if (!object.contains(IID_KEY) || !object[IID_KEY].isString()) { - return QString(); - } - return object[IID_KEY].toString(); + return object[IID_KEY].toString(""); } int getPluginInterfaceVersionFromMetaData(const QJsonObject& object) { static const QString METADATA_KEY = "MetaData"; static const QString NAME_KEY = "version"; - if (!object.contains(METADATA_KEY) || !object[METADATA_KEY].isObject()) { - return 0; - } return object[METADATA_KEY][NAME_KEY].toInt(0); }