From 09981db83461bbadc3f56a78c03af743d3d13a4e Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 28 Apr 2016 18:05:06 -0700 Subject: [PATCH] use a setting handle for UAL disabled to fix startup race --- libraries/networking/src/UserActivityLogger.cpp | 7 ++----- libraries/networking/src/UserActivityLogger.h | 6 ++++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/libraries/networking/src/UserActivityLogger.cpp b/libraries/networking/src/UserActivityLogger.cpp index 09cfc298bc..0d7690840d 100644 --- a/libraries/networking/src/UserActivityLogger.cpp +++ b/libraries/networking/src/UserActivityLogger.cpp @@ -25,15 +25,12 @@ UserActivityLogger& UserActivityLogger::getInstance() { return sharedInstance; } -UserActivityLogger::UserActivityLogger() : _disabled(false) { -} - void UserActivityLogger::disable(bool disable) { - _disabled = disable; + _disabled.set(disable); } void UserActivityLogger::logAction(QString action, QJsonObject details, JSONCallbackParameters params) { - if (_disabled) { + if (_disabled.get()) { return; } diff --git a/libraries/networking/src/UserActivityLogger.h b/libraries/networking/src/UserActivityLogger.h index c48169d207..5c1cb03e3a 100644 --- a/libraries/networking/src/UserActivityLogger.h +++ b/libraries/networking/src/UserActivityLogger.h @@ -19,6 +19,8 @@ #include #include +#include + class UserActivityLogger : public QObject { Q_OBJECT @@ -44,8 +46,8 @@ private slots: void requestError(QNetworkReply& errorReply); private: - UserActivityLogger(); - bool _disabled; + UserActivityLogger() {}; + Setting::Handle _disabled { "UserActivityLoggerDisabled", false }; }; #endif // hifi_UserActivityLogger_h