From cd8ad23dd1860e7118a4da42d53381574c72f3a7 Mon Sep 17 00:00:00 2001
From: ksuprynowicz <ksuprynowicz@post.pl>
Date: Tue, 5 Mar 2024 01:09:57 +0100
Subject: [PATCH] Fix invalid reference

---
 assignment-client/src/avatars/ScriptableAvatar.cpp | 9 +++++----
 libraries/ui/src/QmlWindowClass.cpp                | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/assignment-client/src/avatars/ScriptableAvatar.cpp b/assignment-client/src/avatars/ScriptableAvatar.cpp
index c919d2a2d7..8a15f05bf1 100644
--- a/assignment-client/src/avatars/ScriptableAvatar.cpp
+++ b/assignment-client/src/avatars/ScriptableAvatar.cpp
@@ -138,7 +138,8 @@ static AnimPose composeAnimPose(const HFMJoint& joint, const glm::quat rotation,
 
 void ScriptableAvatar::update(float deltatime) {
     // Run animation
-    if (_animation && _animation->isLoaded() && _animation->getFrames().size() > 0 && !_bind.isNull() && _bind->isLoaded()) {
+    auto frames = _animation->getFrames();
+    if (_animation && _animation->isLoaded() && frames.size() > 0 && !_bind.isNull() && _bind->isLoaded()) {
         if (!_animSkeleton) {
             _animSkeleton = std::make_shared<AnimSkeleton>(_bind->getHFMModel());
         }
@@ -157,9 +158,9 @@ void ScriptableAvatar::update(float deltatime) {
                 _jointData.resize(nJoints);
             }
 
-            const int frameCount = _animation->getFrames().size();
-            const HFMAnimationFrame& floorFrame = _animation->getFrames().at((int)glm::floor(currentFrame) % frameCount);
-            const HFMAnimationFrame& ceilFrame = _animation->getFrames().at((int)glm::ceil(currentFrame) % frameCount);
+            const int frameCount = frames.size();
+            const HFMAnimationFrame& floorFrame = frames.at((int)glm::floor(currentFrame) % frameCount);
+            const HFMAnimationFrame& ceilFrame = frames.at((int)glm::ceil(currentFrame) % frameCount);
             const float frameFraction = glm::fract(currentFrame);
             std::vector<AnimPose> poses = _animSkeleton->getRelativeDefaultPoses();
 
diff --git a/libraries/ui/src/QmlWindowClass.cpp b/libraries/ui/src/QmlWindowClass.cpp
index 474a8f467d..74734fdc43 100644
--- a/libraries/ui/src/QmlWindowClass.cpp
+++ b/libraries/ui/src/QmlWindowClass.cpp
@@ -279,6 +279,7 @@ bool QmlWindowClass::isVisible() {
         return quickItem->isVisible();
     } else {
         qDebug() << "QmlWindowClass::isVisible: asQuickItem() returned NULL";
+        return false;
     }
 }