From cc43112bf320a6e3a8f17bdbe131672d4323b458 Mon Sep 17 00:00:00 2001
From: kasenvr <52365539+kasenvr@users.noreply.github.com>
Date: Sat, 1 Aug 2020 13:46:02 -0400
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: David Rowe <david@ctrlaltstudio.com>
---
 scripts/communityScripts/chat/FloofChat.js                | 8 ++++----
 .../communityScripts/notificationCore/notificationCore.js | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/communityScripts/chat/FloofChat.js b/scripts/communityScripts/chat/FloofChat.js
index 00a55c48a2..d1324bd560 100644
--- a/scripts/communityScripts/chat/FloofChat.js
+++ b/scripts/communityScripts/chat/FloofChat.js
@@ -628,7 +628,7 @@ function setVisible(_visible) {
 function avatarJoinsDomain(sessionID) {
     Script.setTimeout(function () {
         var messageText = AvatarManager.getPalData([sessionID]).data[0].sessionDisplayName + " has joined."
-        var messageColor = {red: 122, green: 122, blue: 122};
+        var messageColor = { red: 122, green: 122, blue: 122 };
         
         addToLog(messageText, "Notice", messageColor, "Domain");
         
@@ -640,7 +640,7 @@ function avatarJoinsDomain(sessionID) {
             Messages.sendLocalMessage(FLOOF_NOTIFICATION_CHANNEL, JSON.stringify({
                 sender: "(D)",
                 text:  messageText,
-                colour: {text: messageColor}
+                colour: { text: messageColor }
             }));
         }
     }, 500); // Wait 500ms for the avatar to load to properly get info about them.
@@ -648,7 +648,7 @@ function avatarJoinsDomain(sessionID) {
 
 function avatarLeavesDomain(sessionID) {
     var messageText = AvatarManager.getPalData([sessionID]).data[0].sessionDisplayName + " has left."
-    var messageColor = {red: 122, green: 122, blue: 122};
+    var messageColor = { red: 122, green: 122, blue: 122 };
     
     addToLog(messageText, "Notice", messageColor, "Domain");
     
@@ -660,7 +660,7 @@ function avatarLeavesDomain(sessionID) {
         Messages.sendLocalMessage(FLOOF_NOTIFICATION_CHANNEL, JSON.stringify({
             sender: "(D)",
             text:  messageText,
-            colour: {text: messageColor}
+            colour: { text: messageColor }
         }));
     }
 }
diff --git a/scripts/communityScripts/notificationCore/notificationCore.js b/scripts/communityScripts/notificationCore/notificationCore.js
index f25d91bd6b..7920a575ec 100644
--- a/scripts/communityScripts/notificationCore/notificationCore.js
+++ b/scripts/communityScripts/notificationCore/notificationCore.js
@@ -181,7 +181,7 @@ Controller.mousePressEvent.connect(function (event) {
     var overlay = Overlays.getOverlayAtPoint({ x: event.x, y: event.y });
     if (overlay) {
         for (var i = 0; i < notificationList.length; i++) {
-            if (overlay == notificationList[i].id) {
+            if (overlay === notificationList[i].id) {
                 Overlays.deleteOverlay(notificationList[i].id)
                 Messages.sendMessage(MAIN_CHAT_APP_CHANNEL, JSON.stringify({
                     type: "ShowChatWindow",
@@ -191,4 +191,4 @@ Controller.mousePressEvent.connect(function (event) {
     }
 });
 
-Script.scriptEnding.connect(cleanUp);
\ No newline at end of file
+Script.scriptEnding.connect(cleanUp);