Mirrors/overte
3
0
Fork 0
mirror of https://github.com/overte-org/overte.git synced 2025-04-05 21:12:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

remove unused parameter

Browse source
This commit is contained in:
HifiExperiments 2024-11-11 23:58:19 -08:00
parent 6dc239d58d
commit c77bcb2d45
5 changed files with 8 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libraries/render-utils/src/FadeEffect.cpp
View file

@ -28,10 +28,8 @@ FadeEffect::FadeEffect() {
}
void FadeEffect::build(JobModel& task, const render::Varying& inputs, render::Varying& outputs) {
auto editedFadeCategory = task.addJob<FadeJob>("Fade");
const auto fadeEditInput = FadeEditJob::Input(inputs, editedFadeCategory).asVarying();
task.addJob<FadeEditJob>("FadeEdit", fadeEditInput);
const auto editedFadeCategory = task.addJob<FadeJob>("Fade");
task.addJob<FadeEditJob>("FadeEdit", editedFadeCategory);
}
render::ShapePipeline::BatchSetter FadeEffect::getBatchSetter() {

3
libraries/render-utils/src/FadeEffect.h
View file

@ -15,8 +15,7 @@
class FadeEffect {
public:
using Input = render::ItemBounds;
using JobModel = render::Task::ModelI<FadeEffect, render::ItemBounds>;
using JobModel = render::Task::Model<FadeEffect>;
FadeEffect();

4
libraries/render-utils/src/FadeEffectJobs.cpp
View file

@ -35,7 +35,7 @@ void FadeEditJob::configure(const Config& config) {
_isEditEnabled = config.editFade;
}
void FadeEditJob::run(const render::RenderContextPointer& renderContext, const FadeEditJob::Input& inputs) {
void FadeEditJob::run(const render::RenderContextPointer& renderContext, const FadeEditJob::Input& input) {
auto scene = renderContext->_scene;
if (_isEditEnabled) {
@ -63,7 +63,7 @@ void FadeEditJob::run(const render::RenderContextPointer& renderContext, const F
render::Transition::AVATAR_CHANGE
};
auto transitionType = categoryToTransition[inputs.get1()];
auto transitionType = categoryToTransition[input];
transaction.queryTransitionOnItem(_editedItem, [transitionType, scene](render::ItemID id, const render::Transition* transition) {
if (transition == nullptr || transition->isFinished || transition->eventType != transitionType) {

4
libraries/render-utils/src/FadeEffectJobs.h
View file

@ -177,13 +177,13 @@ class FadeEditJob {
public:
using Config = FadeEditConfig;
using Input = render::VaryingSet2<render::ItemBounds, FadeCategory>;
using Input = FadeCategory;
using JobModel = render::Job::ModelI<FadeEditJob, Input, Config>;
FadeEditJob() {}
void configure(const Config& config);
void run(const render::RenderContextPointer& renderContext, const FadeEditJob::Input& inputs);
void run(const render::RenderContextPointer& renderContext, const FadeEditJob::Input& input);
private:

3
libraries/render-utils/src/RenderViewTask.cpp
View file

@ -45,8 +45,7 @@ void RenderViewTask::build(JobModel& task, const render::Varying& input, render:
// TODO: This doesn't actually do any rendering, it simply processes the fade transactions. Even though forward rendering
// doesn't support fading right now, we still need to do this once for both paths, otherwise we are left with orphaned objects
// after they fade out. In the future, we should refactor this to happen elsewhere.
const auto& opaques = items.get<RenderFetchCullSortTask::Output>().get0()[RenderFetchCullSortTask::OPAQUE_SHAPE];
task.addJob<FadeEffect>("FadeEffect", opaques);
task.addJob<FadeEffect>("FadeEffect");
}
// Issue the lighting model, aka the big global settings for the view