From c510a8fa3e00f786ed85ba1366faf0c0d0635811 Mon Sep 17 00:00:00 2001 From: HifiExperiments <thingsandstuffblog@gmail.com> Date: Fri, 27 Nov 2020 15:10:14 -0800 Subject: [PATCH] add comment about material sphere scale --- .../entities-renderer/src/RenderableMaterialEntityItem.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libraries/entities-renderer/src/RenderableMaterialEntityItem.cpp b/libraries/entities-renderer/src/RenderableMaterialEntityItem.cpp index 6b9ae6b4cf..3d2e59518c 100644 --- a/libraries/entities-renderer/src/RenderableMaterialEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableMaterialEntityItem.cpp @@ -21,6 +21,8 @@ void MaterialEntityRenderer::doRenderUpdateSynchronousTyped(const ScenePointer& AbstractViewStateInterface::instance()->pushPostUpdateLambda(key, [this, entity] { withWriteLock([&] { _renderTransform = getModelTransform(); + // Material entities should fit inside a cube entity of the same size, so a sphere that has dimensions 1x1x1 + // is a half unit sphere. However, the geometry cache renders a UNIT sphere, so we need to scale down. const float MATERIAL_ENTITY_SCALE = 0.5f; _renderTransform.postScale(MATERIAL_ENTITY_SCALE); _renderTransform.postScale(ENTITY_ITEM_DEFAULT_DIMENSIONS);