Merge branch 'master' of https://github.com/highfidelity/hifi into Case20393

This commit is contained in:
Roxanne Skelly 2019-03-13 16:04:34 -07:00
commit c3ecc29c4b
4 changed files with 20 additions and 7 deletions

3
.gitignore vendored
View file

@ -26,6 +26,9 @@ android/**/src/main/assets
android/**/gradle* android/**/gradle*
*.class *.class
# Visual Studio
/.vs
# VSCode # VSCode
# List taken from Github Global Ignores master@435c4d92 # List taken from Github Global Ignores master@435c4d92
# https://github.com/github/gitignore/commits/master/Global/VisualStudioCode.gitignore # https://github.com/github/gitignore/commits/master/Global/VisualStudioCode.gitignore

Binary file not shown.

View file

@ -510,7 +510,7 @@ Item {
console.log("Create Failed: " + error); console.log("Create Failed: " + error);
if (completeProfileBody.withSteam || completeProfileBody.withOculus) { if (completeProfileBody.withSteam || completeProfileBody.withOculus) {
if (completeProfileBody.loginDialogPoppedUp) { if (completeProfileBody.loginDialogPoppedUp) {
action = completeProfileBody.withSteam ? "Steam" : "Oculus"; var action = completeProfileBody.withSteam ? "Steam" : "Oculus";
var data = { var data = {
"action": "user failed to create a profile with " + action + " from the complete profile screen" "action": "user failed to create a profile with " + action + " from the complete profile screen"
} }

View file

@ -371,6 +371,7 @@ Rectangle {
id: categoriesDropdown id: categoriesDropdown
anchors.fill: parent; anchors.fill: parent;
anchors.topMargin: 2
visible: false visible: false
z: 10 z: 10
@ -409,6 +410,7 @@ Rectangle {
model: categoriesModel model: categoriesModel
delegate: ItemDelegate { delegate: ItemDelegate {
id: categoriesItemDelegate
height: 34 height: 34
width: parent.width width: parent.width
@ -420,6 +422,8 @@ Rectangle {
color: hifi.colors.white color: hifi.colors.white
visible: true visible: true
border.color: hifi.colors.blueHighlight
border.width: 0
RalewaySemiBold { RalewaySemiBold {
id: categoriesItemText id: categoriesItemText
@ -431,7 +435,7 @@ Rectangle {
elide: Text.ElideRight elide: Text.ElideRight
text: model.name text: model.name
color: ListView.isCurrentItem ? hifi.colors.lightBlueHighlight : hifi.colors.baseGray color: categoriesItemDelegate.ListView.isCurrentItem ? hifi.colors.blueHighlight : hifi.colors.baseGray
horizontalAlignment: Text.AlignLeft horizontalAlignment: Text.AlignLeft
verticalAlignment: Text.AlignVCenter verticalAlignment: Text.AlignVCenter
size: 14 size: 14
@ -467,16 +471,22 @@ Rectangle {
MouseArea { MouseArea {
anchors.fill: parent anchors.fill: parent
z: 10 z: 10
hoverEnabled: true hoverEnabled: true
propagateComposedEvents: false propagateComposedEvents: false
onEntered: { onPositionChanged: {
categoriesItem.color = ListView.isCurrentItem ? hifi.colors.white : hifi.colors.lightBlueHighlight; // Must use onPositionChanged and not onEntered
// due to a QML bug where a mouseenter event was
// being fired on open of the categories list even
// though the mouse was outside the borders
categoriesItem.border.width = 2;
}
onExited: {
categoriesItem.border.width = 0;
} }
onExited: { onCanceled: {
categoriesItem.color = ListView.isCurrentItem ? hifi.colors.lightBlueHighlight : hifi.colors.white; categoriesItem.border.width = 0;
} }
onClicked: { onClicked: {