From c0d1953df3bb1f45ea2571ab83852311b57b22de Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Mon, 6 Jul 2015 17:21:02 -0700 Subject: [PATCH] use NLPacket in LimitedNodeList --- libraries/networking/src/LimitedNodeList.cpp | 28 ++++++++++---------- libraries/networking/src/LimitedNodeList.h | 10 +++---- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/libraries/networking/src/LimitedNodeList.cpp b/libraries/networking/src/LimitedNodeList.cpp index 4eaa61b5e3..a6ac2a10c2 100644 --- a/libraries/networking/src/LimitedNodeList.cpp +++ b/libraries/networking/src/LimitedNodeList.cpp @@ -521,7 +521,7 @@ unsigned LimitedNodeList::broadcastToNodes(const QByteArray& packet, const NodeS return n; } -NodeListPacket&& LimitedNodeList::constructPingPacket(PingType_t pingType) { +NLPacket&& LimitedNodeList::constructPingPacket(PingType_t pingType) { int packetSize = sizeof(PingType_t) + sizeof(quint64); NodeListPacket pingPacket = NodeListPacket::create(PacketType::Ping, packetSize); @@ -533,7 +533,7 @@ NodeListPacket&& LimitedNodeList::constructPingPacket(PingType_t pingType) { return pingPacket; } -NodeListPacket&& LimitedNodeList::constructPingReplyPacket(const QByteArray& pingPacket) { +NLPacket&& LimitedNodeList::constructPingReplyPacket(const QByteArray& pingPacket) { QDataStream pingPacketStream(pingPacket); pingPacketStream.skipRawData(numBytesForPacketHeader(pingPacket)); @@ -542,41 +542,41 @@ NodeListPacket&& LimitedNodeList::constructPingReplyPacket(const QByteArray& pin quint64 timeFromOriginalPing; pingPacketStream >> timeFromOriginalPing; - + int packetSize = sizeof(PingType_t) + sizeof(quint64) + sizeof(quint64); - + NodeListPacket replyPacket = NodeListPacket::create(PacketType::Ping, packetSize); - + QDataStream packetStream(&replyPacket, QIODevice::Append); packetStream << typeFromOriginalPing << timeFromOriginalPing << usecTimestampNow(); return replyPacket; } -NodeListPacket&& constructICEPingPacket(PingType_t pingType, const QUuid& iceID) { +NLPacket&& constructICEPingPacket(PingType_t pingType, const QUuid& iceID) { int packetSize = NUM_BYTES_RFC4122_UUID + sizeof(PingType_t); - + NodeListPacket icePingPacket = NodeListPacket::create(PacketType::ICEPing, packetSize); - + icePingPacket.payload().replace(0, NUM_BYTES_RFC4122_UUID, iceID.toRfc4122().data()); memcpy(icePingPacket.payload() + NUM_BYTES_RFC4122_UUID, &pingType, sizeof(PingType_t)); - + return icePingPacket; } -NodeListPacket&& constructICEPingReplyPacket(const QByteArray& pingPacket, const QUuid& iceID) { +NLPacket&& constructICEPingReplyPacket(const QByteArray& pingPacket, const QUuid& iceID) { // pull out the ping type so we can reply back with that PingType_t pingType; - + memcpy(&pingType, pingPacket.data() + NUM_BYTES_RFC4122_UUID, sizeof(PingType_t)); - + int packetSize = NUM_BYTES_RFC4122_UUID + sizeof(PingType_t); NodeListPacket icePingReplyPacket = NodeListPacket::create(PacketType::ICEPingReply, packetSize); - + // pack the ICE ID and then the ping type memcpy(icePingReplyPacket.payload(), iceID.toRfc4122().data(), NUM_BYTES_RFC4122_UUID); memcpy(icePingReplyPacket.payload() + NUM_BYTES_RFC4122_UUID, &pingType, sizeof(PingType_t)); - + return icePingReplyPacket; } diff --git a/libraries/networking/src/LimitedNodeList.h b/libraries/networking/src/LimitedNodeList.h index b705b0e2ea..c72ce4ffd1 100644 --- a/libraries/networking/src/LimitedNodeList.h +++ b/libraries/networking/src/LimitedNodeList.h @@ -170,11 +170,11 @@ public: void getPacketStats(float &packetsPerSecond, float &bytesPerSecond); void resetPacketStats(); - NodeListPacket&& constructPingPacket(PingType_t pingType = PingType::Agnostic); - NodeListPacket&& constructPingReplyPacket(const QByteArray& pingPacket); - - NodeListPacket&& constructICEPingPacket(PingType_t pingType, const QUuid& iceID); - NodeListPacket&& constructICEPingReplyPacket(const QByteArray& pingPacket, const QUuid& iceID); + NLPacket&& constructPingPacket(PingType_t pingType = PingType::Agnostic); + NLPacket&& constructPingReplyPacket(const QByteArray& pingPacket); + + NLPacket&& constructICEPingPacket(PingType_t pingType, const QUuid& iceID); + NLPacket&& constructICEPingReplyPacket(const QByteArray& pingPacket, const QUuid& iceID); virtual bool processSTUNResponse(const QByteArray& packet);