Merge branch 'master' of github.com:highfidelity/hifi into fix-throwing

This commit is contained in:
Seth Alves 2016-07-11 11:12:20 -07:00
commit c034879b74
2 changed files with 260 additions and 264 deletions

View file

@ -43,7 +43,6 @@ ModelOverlay::ModelOverlay(const ModelOverlay* modelOverlay) :
void ModelOverlay::update(float deltatime) { void ModelOverlay::update(float deltatime) {
if (_updateModel) { if (_updateModel) {
_updateModel = false; _updateModel = false;
_model->setSnapModelToCenter(true); _model->setSnapModelToCenter(true);
_model->setScaleToFit(true, getDimensions()); _model->setScaleToFit(true, getDimensions());
_model->setRotation(getRotation()); _model->setRotation(getRotation());
@ -87,23 +86,15 @@ void ModelOverlay::render(RenderArgs* args) {
void ModelOverlay::setProperties(const QVariantMap& properties) { void ModelOverlay::setProperties(const QVariantMap& properties) {
auto position = getPosition(); auto position = getPosition();
auto rotation = getRotation(); auto rotation = getRotation();
auto scale = getDimensions();
Volume3DOverlay::setProperties(properties); Volume3DOverlay::setProperties(properties);
if (position != getPosition() || rotation != getRotation()) { if (position != getPosition() || rotation != getRotation()) {
_updateModel = true; _updateModel = true;
} }
if (scale != getDimensions()) { _updateModel = true;
auto newScale = getDimensions();
if (newScale.x <= 0 || newScale.y <= 0 || newScale.z <= 0) {
setDimensions(scale);
} else {
_updateModel = true;
}
}
auto urlValue = properties["url"]; auto urlValue = properties["url"];
if (urlValue.isValid() && urlValue.canConvert<QString>()) { if (urlValue.isValid() && urlValue.canConvert<QString>()) {
_url = urlValue.toString(); _url = urlValue.toString();

File diff suppressed because it is too large Load diff