From c0052004de51ea04ca9dbe8ba415ca8a5f4a1093 Mon Sep 17 00:00:00 2001 From: Oren Hurvitz Date: Sun, 22 Apr 2018 13:51:41 +0300 Subject: [PATCH] Explained an edge case that can cause us to fail to send some entity properties --- libraries/entities/src/EntityEditPacketSender.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libraries/entities/src/EntityEditPacketSender.cpp b/libraries/entities/src/EntityEditPacketSender.cpp index d458c36f79..3d2f0bd069 100644 --- a/libraries/entities/src/EntityEditPacketSender.cpp +++ b/libraries/entities/src/EntityEditPacketSender.cpp @@ -120,6 +120,10 @@ void EntityEditPacketSender::queueEditEntityMessage(PacketType type, encodeResult = EntityItemProperties::encodeEntityEditPacket(type, entityItemID, propertiesCopy, bufferOut, requestedProperties, didntFitProperties); if (encodeResult == OctreeElement::NONE) { + // This can happen for two reasons: + // 1. One of the properties is too large to fit in a single packet. + // 2. The requested properties don't exist in this entity type (e.g., 'modelUrl' in a Zone Entity). + // Since case #1 is more likely (and more critical), that's the one we warn about. qCWarning(entities).nospace() << "queueEditEntityMessage: some of the properties don't fit and can't be sent. entityID=" << uuidStringWithoutCurlyBraces(entityItemID); } else {