From bbf7d165375def2bc113f61376bcba4479b13a7b Mon Sep 17 00:00:00 2001
From: Howard Stearns <howard@highfidelity.io>
Date: Thu, 5 Jan 2017 13:45:03 -0800
Subject: [PATCH] process consistent select message

---
 interface/resources/qml/hifi/Pal.qml   | 18 ++++++----
 scripts/system/libraries/entityList.js |  2 +-
 scripts/system/pal.js                  | 48 ++++++++++++++------------
 3 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/interface/resources/qml/hifi/Pal.qml b/interface/resources/qml/hifi/Pal.qml
index 833cf4efe2..537e855072 100644
--- a/interface/resources/qml/hifi/Pal.qml
+++ b/interface/resources/qml/hifi/Pal.qml
@@ -427,14 +427,20 @@ Item {
             sortModel();
             break;
         case 'select':
-            var sessionId = message.params[0];
+            var sessionIds = message.params[0];
             var selected = message.params[1];
-            var userIndex = findSessionIndex(sessionId);
-            if (selected) {
-                table.selection.clear(); // for now, no multi-select
-                table.selection.select(userIndex);
+            var userIndex = findSessionIndex(sessionIds[0]);
+            if (sessionIds.length > 1) {
+                console.log('FIXME NEEDS MODAL: Only one user can be selected at a time.');
+            } else if (userIndex < 0) {
+                console.log('FIXME NEEEDS MODAL: The last editor has left.');
             } else {
-                table.selection.deselect(userIndex);
+                if (selected) {
+                    table.selection.clear(); // for now, no multi-select
+                    table.selection.select(userIndex);
+                } else {
+                    table.selection.deselect(userIndex);
+                }
             }
             break;
         // Received an "updateUsername()" request from the JS
diff --git a/scripts/system/libraries/entityList.js b/scripts/system/libraries/entityList.js
index fa09f27965..a57c299128 100644
--- a/scripts/system/libraries/entityList.js
+++ b/scripts/system/libraries/entityList.js
@@ -133,7 +133,7 @@ EntityListTool = function(opts) {
                 Window.alert('There were no recent users of the ' + selectionManager.selections.length + ' selected objects.');
             } else {
                 // No need to subscribe if we're just sending.
-                Messages.sendMessage('com.highfidelity.pal', JSON.stringify({method: 'select', params: dedupped}), 'local');
+                Messages.sendMessage('com.highfidelity.pal', JSON.stringify({method: 'select', params: [dedupped, true]}), 'local');
             }
         } else if (data.type == "delete") {
             deleteSelectedEntities();
diff --git a/scripts/system/pal.js b/scripts/system/pal.js
index 4c4a9c0eaf..c2c425ae47 100644
--- a/scripts/system/pal.js
+++ b/scripts/system/pal.js
@@ -256,34 +256,13 @@ function removeOverlays() {
     ExtendedOverlay.some(function (overlay) { overlay.deleteOverlay(); });
 }
 
-//
-// Message from other scripts, such as edit.js
-//
-var CHANNEL = 'com.highfidelity.pal';
-function receiveMessage(channel, messageString, senderID) {
-    if ((channel !== CHANNEL) ||
-        (senderID !== MyAvatar.sessionUUID)) {
-        return;
-    }
-    var message = JSON.parse(messageString);
-    switch (message.method) {
-    case 'select':
-        print('fixme processing', message.params);
-        break;
-    default:
-        print('Unrecognized PAL message', messageString);
-    }
-}
-Messages.subscribe(CHANNEL);
-Messages.messageReceived.connect(receiveMessage);
-
 //
 // Clicks.
 //
 function handleClick(pickRay) {
     ExtendedOverlay.applyPickRay(pickRay, function (overlay) {
         // Don't select directly. Tell qml, who will give us back a list of ids.
-        var message = {method: 'select', params: [overlay.key, !overlay.selected]};
+        var message = {method: 'select', params: [[overlay.key], !overlay.selected]};
         pal.sendToQml(message);
         return true;
     });
@@ -354,6 +333,31 @@ function onClicked() {
     pal.setVisible(!pal.visible);
 }
 
+//
+// Message from other scripts, such as edit.js
+//
+var CHANNEL = 'com.highfidelity.pal';
+function receiveMessage(channel, messageString, senderID) {
+    if ((channel !== CHANNEL) ||
+        (senderID !== MyAvatar.sessionUUID)) {
+        return;
+    }
+    var message = JSON.parse(messageString);
+    switch (message.method) {
+    case 'select':
+        if (!pal.visible) {
+            onClicked();
+        }
+        pal.sendToQml(message); // Accepts objects, not just strings.
+        break;
+    default:
+        print('Unrecognized PAL message', messageString);
+    }
+}
+Messages.subscribe(CHANNEL);
+Messages.messageReceived.connect(receiveMessage);
+
+
 var AVERAGING_RATIO = 0.05;
 var LOUDNESS_FLOOR = 11.0;
 var LOUDNESS_SCALE = 2.8 / 5.0;