From ba4c0f189e9600921efa5c4107858775b04b6de3 Mon Sep 17 00:00:00 2001
From: "Anthony J. Thibault" <tony@highfidelity.io>
Date: Fri, 10 Nov 2017 10:25:29 -0800
Subject: [PATCH] code review feedback

removed discontinuity in safeDeltaTime, which is used to prevent division by zero.
---
 interface/src/LODManager.cpp                               | 3 ++-
 libraries/avatars-renderer/src/avatars-renderer/Avatar.cpp | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/interface/src/LODManager.cpp b/interface/src/LODManager.cpp
index 8f01296e1c..01ccbd0d9a 100644
--- a/interface/src/LODManager.cpp
+++ b/interface/src/LODManager.cpp
@@ -54,7 +54,8 @@ void LODManager::autoAdjustLOD(float batchTime, float engineRunTime, float delta
     float renderTime = batchTime + OVERLAY_AND_SWAP_TIME_BUDGET;
     float maxTime = glm::max(renderTime, engineRunTime);
     const float BLEND_TIMESCALE = 0.3f; // sec
-    const float safeDeltaTime = (deltaTimeSec == 0.0f) ? 0.001f : deltaTimeSec;
+    const float MIN_DELTA_TIME = 0.001f;
+    const float safeDeltaTime = glm::max(deltaTimeSec, MIN_DELTA_TIME);
     float blend = BLEND_TIMESCALE / safeDeltaTime;
     if (blend > 1.0f) {
         blend = 1.0f;
diff --git a/libraries/avatars-renderer/src/avatars-renderer/Avatar.cpp b/libraries/avatars-renderer/src/avatars-renderer/Avatar.cpp
index 2335095056..49d2431098 100644
--- a/libraries/avatars-renderer/src/avatars-renderer/Avatar.cpp
+++ b/libraries/avatars-renderer/src/avatars-renderer/Avatar.cpp
@@ -453,7 +453,8 @@ void Avatar::applyPositionDelta(const glm::vec3& delta) {
 void Avatar::measureMotionDerivatives(float deltaTime) {
     PerformanceTimer perfTimer("derivatives");
     // linear
-    const float safeDeltaTime = (deltaTime == 0.0f) ? 0.001f : deltaTime;
+    const float MIN_DELTA_TIME = 0.001f;
+    const float safeDeltaTime = glm::max(deltaTime, MIN_DELTA_TIME);
     float invDeltaTime = 1.0f / safeDeltaTime;
     // Floating point error prevents us from computing velocity in a naive way
     // (e.g. vel = (pos - oldPos) / dt) so instead we use _positionOffsetAccumulator.